mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-01-30 19:03:04 +00:00
Code Issues Releases Wiki Activity

fix: recent build warnings and errors (#5711)

Browse source 
* fix: use std::empty instead of isEmpty()

* fix: fix trivially assignable warning hicpp-move-const-arg

* fix: fix clang-diagnostic-unused-but-set-variable warning

* fix: fix readability-braces-around-statements warning
This commit is contained in:
Charles Kerr 2023-07-01 10:22:15 -05:00 committed by GitHub
parent 9c17463a80
commit 4c282bdbb4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libtransmission/inout.cc
View file

@ -249,7 +249,7 @@ std::optional<tr_sha1_digest_t> recalculateHash(tr_torrent* tor, tr_piece_index_
auto& cache = tor->session->cache;
auto const [begin_byte, end_byte] = tor->block_info().byte_span_for_piece(piece);
auto const [begin_block, end_block] = tor->block_span_for_piece(piece);
auto n_bytes_checked = size_t{};
[[maybe_unused]] auto n_bytes_checked = size_t{};
for (auto block = begin_block; block < end_block; ++block)
{
auto const block_loc = tor->block_loc(block);

2
qt/FileTreeItem.cc
View file

@ -22,7 +22,9 @@ std::unordered_map<QString, int> const& FileTreeItem::getMyChildRows() const
{
// ensure that all the rows are hashed
for (int const n = childCount(); first_unhashed_row_ < n; ++first_unhashed_row_)
{
child_rows_.emplace(children_[first_unhashed_row_]->name(), first_unhashed_row_);
}
return child_rows_;
}

2
qt/FileTreeView.cc
View file

@ -269,7 +269,7 @@ void FileTreeView::onlyCheckSelectedItems()
while (!std::empty(parents_queue))
{
auto const parent_index = std::move(parents_queue.front());
auto const parent_index = parents_queue.front();
parents_queue.pop();
if (std::binary_search(wanted_indices.begin(), wanted_indices.end(), parent_index))

4
qt/RpcQueue.cc
View file

@ -48,7 +48,7 @@ void RpcQueue::stepFinished()
else
{
assert(!next_error_handler_);
assert(queue_.isEmpty());
assert(std::empty(queue_));
// one way or another, the last step returned nothing.
// assume it is OK and ensure that we're not going to give an empty response object to any of the next steps.
@ -61,7 +61,7 @@ void RpcQueue::stepFinished()
void RpcQueue::runNext(RpcResponseFuture const& response)
{
assert(!queue_.isEmpty());
assert(!std::empty(queue_));
auto next = std::move(queue_.front());
queue_.pop();