mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2024-12-22 07:42:37 +00:00
Code Issues Releases Wiki Activity

Disable a long-lived and recurrent flaky test (#6722)

Browse source
This commit is contained in:
Cœur 2024-03-25 13:32:29 +08:00 committed by GitHub
parent 3e958cfbaf
commit 4ce8a02916
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tests/libtransmission/lpd-test.cc
View file

@ -112,6 +112,7 @@ TEST_F(LpdTest, HelloWorld)
EXPECT_EQ(0U, std::size(mediator.found_));
}
// TODO: flaky test should be fixed instead of disabled
TEST_F(LpdTest, DISABLED_CanAnnounceAndRead)
{
auto mediator_a = MyMediator{ *session_ };
@ -134,6 +135,7 @@ TEST_F(LpdTest, DISABLED_CanAnnounceAndRead)
EXPECT_EQ(0U, mediator_b.found_.count(info_hash_str));
}
// TODO: flaky test should be fixed instead of disabled
TEST_F(LpdTest, DISABLED_canMultiAnnounce)
{
auto mediator_a = MyMediator{ *session_ };
@ -170,6 +172,7 @@ TEST_F(LpdTest, DISABLED_canMultiAnnounce)
}
}
// TODO: flaky test should be fixed instead of disabled
TEST_F(LpdTest, DISABLED_DoesNotReannounceTooSoon)
{
auto mediator_a = MyMediator{ *session_ };

12
tests/libtransmission/timer-test.cc
View file

@ -177,7 +177,12 @@ TEST_F(TimerTest, repeatingHonorsInterval)
EXPECT_EQ(DesiredLoops, n_calls);
}
#ifdef _WIN32
// TODO: flaky test should be fixed instead of disabled
TEST_F(TimerTest, DISABLED_restartWithDifferentInterval)
#else
TEST_F(TimerTest, restartWithDifferentInterval)
#endif
{
auto timer_maker = EvTimerMaker{ evbase_.get() };
auto timer = timer_maker.create();
@ -206,7 +211,12 @@ TEST_F(TimerTest, restartWithDifferentInterval)
test(200ms);
}
#ifdef _WIN32
// TODO: flaky test should be fixed instead of disabled
TEST_F(TimerTest, DISABLED_restartWithSameInterval)
#else
TEST_F(TimerTest, restartWithSameInterval)
#endif
{
auto timer_maker = EvTimerMaker{ evbase_.get() };
auto timer = timer_maker.create();
@ -235,6 +245,7 @@ TEST_F(TimerTest, DISABLED_restartWithSameInterval)
test(timer->interval());
}
// TODO: flaky test should be fixed instead of disabled
TEST_F(TimerTest, DISABLED_repeatingThenSingleShot)
{
auto timer_maker = EvTimerMaker{ evbase_.get() };
@ -277,6 +288,7 @@ TEST_F(TimerTest, DISABLED_repeatingThenSingleShot)
EXPECT_EQ(baseline + 1, n_calls);
}
// TODO: flaky test should be fixed instead of disabled
TEST_F(TimerTest, DISABLED_singleShotStop)
{
auto timer_maker = EvTimerMaker{ evbase_.get() };

1
tests/libtransmission/watchdir-test.cc
View file

@ -226,6 +226,7 @@ TEST_P(WatchDirTest, watch)
EXPECT_TRUE(std::empty(names));
}
// TODO: flaky test should be fixed instead of disabled
TEST_P(WatchDirTest, DISABLED_retry)
{
auto const path = sandboxDir();