From 536fe4a6e14b26dda0feac87559ac54af0fddb1b Mon Sep 17 00:00:00 2001
From: Yat Ho <lagoho7@gmail.com>
Date: Sun, 29 Dec 2024 15:39:56 +0800
Subject: [PATCH] fix(webui): dispatch `close` events when closing popups
 (#7340)

* fix: dispatch `close` event in statistics dialogue

* fix: properly dispatch `close` event in pref dialogue
---
 web/src/prefs-dialog.js      | 2 +-
 web/src/statistics-dialog.js | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/web/src/prefs-dialog.js b/web/src/prefs-dialog.js
index 3c1913ba3..0783e6c33 100644
--- a/web/src/prefs-dialog.js
+++ b/web/src/prefs-dialog.js
@@ -856,7 +856,7 @@ export class PrefsDialog extends EventTarget {
         this.update_from_session,
       );
       this.elements.root.remove();
-      dispatchEvent(new Event('close'));
+      this.dispatchEvent(new Event('close'));
       for (const key of Object.keys(this)) {
         this[key] = null;
       }
diff --git a/web/src/statistics-dialog.js b/web/src/statistics-dialog.js
index e6de0a177..0283d6546 100644
--- a/web/src/statistics-dialog.js
+++ b/web/src/statistics-dialog.js
@@ -33,6 +33,7 @@ export class StatisticsDialog extends EventTarget {
     if (!this.closed) {
       clearInterval(this.interval);
       this.elements.root.remove();
+      this.dispatchEvent(new Event('close'));
       for (const key of Object.keys(this)) {
         delete this[key];
       }