diff --git a/CMakeLists.txt b/CMakeLists.txt index 3000306a7..9ce3e372e 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -193,10 +193,6 @@ endif() set(CMAKE_FOLDER "third-party") find_package(Fmt) -add_definitions( - -DFMT_HEADER_ONLY - -DFMT_EXCEPTIONS=0) - find_package(WideInteger) find_package(FastFloat) find_package(UtfCpp) @@ -204,15 +200,16 @@ find_package(Threads) find_package(PkgConfig QUIET) find_package(CURL ${CURL_MINIMUM} REQUIRED) -if(TARGET CURL::libcurl) - set(CURL_LIBRARIES CURL::libcurl) - set(CURL_INCLUDE_DIRS) +if(NOT TARGET CURL::libcurl) + add_library(CURL::libcurl INTERFACE IMPORTED) + target_link_libraries(CURL::libcurl INTERFACE ${CURL_LIBRARIES}) + target_include_directories(CURL::libcurl INTERFACE ${CURL_INCLUDE_DIRS}) endif() if(NOT WIN32) - find_package(ICONV) + find_package(Iconv) else() - set(ICONV_FOUND OFF) + set(Iconv_FOUND OFF) endif() set(CRYPTO_PKG "") @@ -259,6 +256,7 @@ if(WITH_CRYPTO STREQUAL "AUTO" OR WITH_CRYPTO STREQUAL "mbedtls") set(CRYPTO_LIBRARIES ${MBEDTLS_LIBRARIES}) endif() endif() + # We should have found the library by now if(CRYPTO_PKG STREQUAL "") if(WITH_CRYPTO STREQUAL "AUTO") @@ -266,6 +264,16 @@ if(CRYPTO_PKG STREQUAL "") else() message(FATAL_ERROR "Requested crypto library '${WITH_CRYPTO}' is not supported.") endif() +else() + add_library(transmission::crypto_impl INTERFACE IMPORTED) + + target_include_directories(transmission::crypto_impl + INTERFACE + ${CRYPTO_INCLUDE_DIRS}) + + target_link_libraries(transmission::crypto_impl + INTERFACE + ${CRYPTO_LIBRARIES}) endif() if(ENABLE_GTK) @@ -306,6 +314,26 @@ else() set(WITH_APPINDICATOR OFF) endif() +if(GTK_FOUND) + add_library(transmission::gtk_impl INTERFACE IMPORTED) + + target_compile_options(transmission::gtk_impl + INTERFACE + ${GTK${GTK_VERSION}_CFLAGS_OTHER}) + + target_include_directories(transmission::gtk_impl + INTERFACE + ${GTK${GTK_VERSION}_INCLUDE_DIRS}) + + target_link_directories(transmission::gtk_impl + INTERFACE + ${GTK${GTK_VERSION}_LIBRARY_DIRS}) + + target_link_libraries(transmission::gtk_impl + INTERFACE + ${GTK${GTK_VERSION}_LIBRARIES}) +endif() + if(ENABLE_QT) tr_get_required_flag(ENABLE_QT QT_IS_REQUIRED) @@ -388,6 +416,14 @@ if(ENABLE_QT) tr_fixup_auto_option(ENABLE_QT QT_FOUND QT_IS_REQUIRED) endif() +if(QT_FOUND) + add_library(transmission::qt_impl INTERFACE IMPORTED) + + target_link_libraries(transmission::qt_impl + INTERFACE + ${QT_TARGETS}) +endif() + if(ENABLE_MAC) tr_get_required_flag(ENABLE_MAC MAC_IS_REQUIRED) @@ -405,12 +441,14 @@ endif() set(THIRD_PARTY_DIR ${CMAKE_SOURCE_DIR}/third-party) -tr_add_external_auto_library(DEFLATE libdeflate deflate) +tr_add_external_auto_library(DEFLATE libdeflate deflate + TARGET deflate::deflate) if(NOT USE_SYSTEM_DEFLATE) set(DEFLATE_VERSION ${DEFLATE_MINIMUM}) endif() tr_add_external_auto_library(EVENT2 libevent event + TARGET libevent::event CMAKE_ARGS -DEVENT__DISABLE_OPENSSL:BOOL=ON -DEVENT__DISABLE_BENCHMARK:BOOL=ON @@ -419,49 +457,51 @@ tr_add_external_auto_library(EVENT2 libevent event -DEVENT__DISABLE_SAMPLES:BOOL=ON -DEVENT__LIBRARY_TYPE:STRING=STATIC) -tr_add_external_auto_library(NATPMP libnatpmp natpmp) +tr_add_external_auto_library(NATPMP libnatpmp natpmp + TARGET natpmp::natpmp) if(NOT USE_SYSTEM_NATPMP) - set(NATPMP_DEFINITIONS NATPMP_STATICLIB) + target_compile_definitions(natpmp::natpmp + INTERFACE + NATPMP_STATICLIB) endif() tr_add_external_auto_library(MINIUPNPC miniupnpc miniupnpc + TARGET miniupnpc::libminiupnpc CMAKE_ARGS -DUPNPC_BUILD_STATIC=ON -DUPNPC_BUILD_SHARED=OFF -DUPNPC_BUILD_TESTS=OFF) -set(MINIUPNPC_DEFINITIONS SYSTEM_MINIUPNP) if(NOT USE_SYSTEM_MINIUPNPC) - list(APPEND MINIUPNPC_DEFINITIONS MINIUPNP_STATICLIB) + target_compile_definitions(miniupnpc::libminiupnpc + INTERFACE + MINIUPNP_STATICLIB) + set(MINIUPNPC_VERSION 1.9) set(MINIUPNPC_API_VERSION 12) endif() +target_compile_definitions(miniupnpc::libminiupnpc + INTERFACE + SYSTEM_MINIUPNP + $<$:MINIUPNPC_API_VERSION=${MINIUPNPC_API_VERSION}>) # API version macro was only added in 1.7 + add_subdirectory(third-party/jsonsl) add_subdirectory(third-party/wildmat) -tr_add_external_auto_library(DHT dht dht) +tr_add_external_auto_library(DHT dht dht + TARGET dht::dht) -tr_add_external_auto_library(PSL libpsl psl) +tr_add_external_auto_library(PSL libpsl psl + TARGET psl::psl) if(ENABLE_UTP) tr_add_external_auto_library(UTP libutp utp + TARGET libutp::libutp CMAKE_ARGS -DLIBUTP_BUILD_PROGRAMS=OFF) - - if(UTP_UPSTREAM_TARGET) - # Use C++ linker for anything that depends on static libutp - # TODO: switch to imported targets for all the dependencies - add_library(UTP::UTP STATIC IMPORTED) - set_property( - TARGET UTP::UTP - PROPERTY IMPORTED_LOCATION "${UTP_LIBRARIES}") - set_property( - TARGET UTP::UTP - PROPERTY IMPORTED_LINK_INTERFACE_LANGUAGES "CXX") - set(UTP_LIBRARIES UTP::UTP) - endif() endif() -tr_add_external_auto_library(B64 libb64 b64) +tr_add_external_auto_library(B64 libb64 b64 + TARGET libb64::libb64) if(WITH_INOTIFY) tr_get_required_flag(WITH_INOTIFY INOTIFY_IS_REQUIRED) diff --git a/cli/CMakeLists.txt b/cli/CMakeLists.txt index b38e7b8b5..bb7cd8d7a 100644 --- a/cli/CMakeLists.txt +++ b/cli/CMakeLists.txt @@ -4,18 +4,10 @@ target_sources(${TR_NAME}-cli PRIVATE cli.cc) -target_include_directories(${TR_NAME}-cli - PRIVATE - ${CMAKE_SOURCE_DIR}) - -target_include_directories(${TR_NAME}-cli SYSTEM - PRIVATE - ${LIBFMT_INCLUDE_DIRS} - ${CURL_INCLUDE_DIRS}) - target_link_libraries(${TR_NAME}-cli PRIVATE - ${TR_NAME}) + ${TR_NAME} + fmt::fmt-header-only) tr_win32_app_info(${TR_NAME}-cli "Transmission Utility ('cli', obsolete)" diff --git a/cmake/FindFastFloat.cmake b/cmake/FindFastFloat.cmake index 67f3aadb2..4ce540e2f 100644 --- a/cmake/FindFastFloat.cmake +++ b/cmake/FindFastFloat.cmake @@ -1 +1,5 @@ -set(FAST_FLOAT_INCLUDE_DIRS ${CMAKE_SOURCE_DIR}/third-party/fast_float/include) +add_library(FastFloat::fast_float INTERFACE IMPORTED) + +target_include_directories(FastFloat::fast_float + INTERFACE + ${CMAKE_CURRENT_LIST_DIR}/../third-party/fast_float/include) diff --git a/cmake/FindFmt.cmake b/cmake/FindFmt.cmake index 8e8b70b63..f1c42486d 100644 --- a/cmake/FindFmt.cmake +++ b/cmake/FindFmt.cmake @@ -1 +1,10 @@ -set(LIBFMT_INCLUDE_DIRS ${CMAKE_SOURCE_DIR}/third-party/fmt/include) +add_library(fmt::fmt-header-only INTERFACE IMPORTED) + +target_include_directories(fmt::fmt-header-only + INTERFACE + ${CMAKE_CURRENT_LIST_DIR}/../third-party/fmt/include) + +target_compile_definitions(fmt::fmt-header-only + INTERFACE + FMT_EXCEPTIONS=0 + FMT_HEADER_ONLY=1) diff --git a/cmake/FindICONV.cmake b/cmake/FindICONV.cmake deleted file mode 100644 index 213a95f14..000000000 --- a/cmake/FindICONV.cmake +++ /dev/null @@ -1,51 +0,0 @@ -# Grabbed from http://public.kitware.com/Bug/view.php?id=13517 and slightly modified. - -find_path(ICONV_INCLUDE_DIR - NAMES iconv.h) -find_library(ICONV_LIBRARY - NAMES - iconv - libiconv - libiconv-2 - c) - -set(ICONV_INCLUDE_DIRS ${ICONV_INCLUDE_DIR}) -set(ICONV_LIBRARIES ${ICONV_LIBRARY}) - -include(FindPackageHandleStandardArgs) - -find_package_handle_standard_args(ICONV - REQUIRED_VARS - ICONV_LIBRARY - ICONV_INCLUDE_DIR - VERSION_VAR ICONV_VERSION) - -if(ICONV_FOUND AND NOT DEFINED ICONV_SECOND_ARGUMENT_IS_CONST) - include(CheckCXXSourceCompiles) - - set(CMAKE_REQUIRED_INCLUDES ${ICONV_INCLUDE_DIRS}) - set(CMAKE_REQUIRED_LIBRARIES ${ICONV_LIBRARIES}) - - check_cxx_source_compiles(" - #include - int main() - { - iconv_t conv = 0; - const char * in = 0; - size_t ilen = 0; - char * out = 0; - size_t olen = 0; - iconv(conv, &in, &ilen, &out, &olen); - return 0; - }" - ICONV_SECOND_ARGUMENT_IS_CONST - FAIL_REGEX "discards qualifiers in nested pointer types" - FAIL_REGEX "incompatible pointer type" - FAIL_REGEX "invalid conversion" - FAIL_REGEX "no matching function") - - set(CMAKE_REQUIRED_INCLUDES) - set(CMAKE_REQUIRED_LIBRARIES) -endif() - -mark_as_advanced(ICONV_INCLUDE_DIR ICONV_LIBRARY ICONV_SECOND_ARGUMENT_IS_CONST) diff --git a/cmake/FindUtfCpp.cmake b/cmake/FindUtfCpp.cmake index 80384d66a..b1250039c 100644 --- a/cmake/FindUtfCpp.cmake +++ b/cmake/FindUtfCpp.cmake @@ -1 +1,5 @@ -set(UTFCPP_INCLUDE_DIRS ${CMAKE_SOURCE_DIR}/third-party/utfcpp/source) +add_library(utf8::cpp INTERFACE IMPORTED) + +target_include_directories(utf8::cpp + INTERFACE + ${CMAKE_CURRENT_LIST_DIR}/../third-party/utfcpp/source) diff --git a/cmake/FindWideInteger.cmake b/cmake/FindWideInteger.cmake index a1cdc0658..b4e44d78f 100644 --- a/cmake/FindWideInteger.cmake +++ b/cmake/FindWideInteger.cmake @@ -1 +1,5 @@ -set(WIDE_INTEGER_INCLUDE_DIRS ${CMAKE_SOURCE_DIR}/third-party/wide-integer) +add_library(WideInteger::WideInteger INTERFACE IMPORTED) + +target_include_directories(WideInteger::WideInteger + INTERFACE + ${CMAKE_CURRENT_LIST_DIR}/../third-party/wide-integer) diff --git a/cmake/TrMacros.cmake b/cmake/TrMacros.cmake index e1ed88bb4..509d9c305 100644 --- a/cmake/TrMacros.cmake +++ b/cmake/TrMacros.cmake @@ -129,6 +129,8 @@ function(tr_process_list_conditions VAR_PREFIX) endfunction() macro(tr_add_external_auto_library ID DIRNAME LIBNAME) + cmake_parse_arguments(_TAEAL_ARG "" "TARGET" "CMAKE_ARGS" ${ARGN}) + if(USE_SYSTEM_${ID}) tr_get_required_flag(USE_SYSTEM_${ID} SYSTEM_${ID}_IS_REQUIRED) find_package(${ID} ${${ID}_MINIMUM} ${SYSTEM_${ID}_IS_REQUIRED}) @@ -161,7 +163,6 @@ macro(tr_add_external_auto_library ID DIRNAME LIBNAME) ExternalProject_Add( ${${ID}_UPSTREAM_TARGET} URL "${CMAKE_SOURCE_DIR}/third-party/${DIRNAME}" - ${ARGN} PREFIX "${${ID}_PREFIX}" CMAKE_ARGS -Wno-dev # We don't want to be warned over unused variables @@ -175,9 +176,29 @@ macro(tr_add_external_auto_library ID DIRNAME LIBNAME) "-DCMAKE_INSTALL_PREFIX:PATH=" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" ${${ID}_EXT_PROJ_CMAKE_ARGS} + ${_TAEAL_ARG_CMAKE_ARGS} BUILD_BYPRODUCTS "${${ID}_LIBRARY}") set_property(TARGET ${${ID}_UPSTREAM_TARGET} PROPERTY FOLDER "third-party") + + # Imported target (below) requires include directories to be present at configuration time + file(MAKE_DIRECTORY ${${ID}_INCLUDE_DIRS}) + endif() + + if(_TAEAL_ARG_TARGET) + add_library(${_TAEAL_ARG_TARGET} INTERFACE IMPORTED) + + target_include_directories(${_TAEAL_ARG_TARGET} + INTERFACE + ${${ID}_INCLUDE_DIRS}) + + target_link_libraries(${_TAEAL_ARG_TARGET} + INTERFACE + ${${ID}_LIBRARIES}) + + if(${ID}_UPSTREAM_TARGET) + add_dependencies(${_TAEAL_ARG_TARGET} ${${ID}_UPSTREAM_TARGET}) + endif() endif() endmacro() diff --git a/daemon/CMakeLists.txt b/daemon/CMakeLists.txt index 4e1a08b19..9a966b09d 100644 --- a/daemon/CMakeLists.txt +++ b/daemon/CMakeLists.txt @@ -26,21 +26,15 @@ tr_target_compile_definitions_for_functions(${TR_NAME}-daemon daemon syslog) -target_include_directories(${TR_NAME}-daemon - PRIVATE - ${CMAKE_SOURCE_DIR}) - target_include_directories(${TR_NAME}-daemon SYSTEM PRIVATE - ${LIBFMT_INCLUDE_DIRS} - ${CURL_INCLUDE_DIRS} - ${EVENT2_INCLUDE_DIRS} $<$:${SYSTEMD_INCLUDE_DIRS}>) target_link_libraries(${TR_NAME}-daemon PRIVATE ${TR_NAME} - ${EVENT2_LIBRARIES} + libevent::event + fmt::fmt-header-only $<$:${SYSTEMD_LIBRARIES}>) tr_win32_app_info(${TR_NAME}-daemon diff --git a/gtk/CMakeLists.txt b/gtk/CMakeLists.txt index 54fd0df38..54c4ab6c4 100644 --- a/gtk/CMakeLists.txt +++ b/gtk/CMakeLists.txt @@ -101,10 +101,6 @@ target_sources(${TR_NAME}-gtk source_group(Ui/GTK4 REGULAR_EXPRESSION [[ui/gtk4/.*\.ui$]]) -target_link_directories(${TR_NAME}-gtk - PRIVATE - ${GTK${GTK_VERSION}_LIBRARY_DIRS}) - if(WITH_APPINDICATOR) set_property( SOURCE SystemTrayIcon.cc @@ -170,29 +166,22 @@ target_compile_definitions(${TR_NAME}-gtk target_compile_options(${TR_NAME}-gtk PRIVATE - ${GTK${GTK_VERSION}_CFLAGS_OTHER} $<$:$,/WX,-Werror>> $<$>:-Wno-exit-time-destructors>) target_include_directories(${TR_NAME}-gtk PRIVATE - ${CMAKE_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR}) target_include_directories(${TR_NAME}-gtk SYSTEM PRIVATE - ${LIBFMT_INCLUDE_DIRS} - ${GTK${GTK_VERSION}_INCLUDE_DIRS} - ${CURL_INCLUDE_DIRS} - ${EVENT2_INCLUDE_DIRS} $<$:${APPINDICATOR_INCLUDE_DIRS}>) target_link_libraries(${TR_NAME}-gtk PRIVATE ${TR_NAME} - ${GTK${GTK_VERSION}_LIBRARIES} - ${CURL_LIBRARIES} - ${EVENT2_LIBRARIES} + transmission::gtk_impl + fmt::fmt-header-only $<$:${APPINDICATOR_LIBRARIES}>) if(MSVC) diff --git a/libtransmission/CMakeLists.txt b/libtransmission/CMakeLists.txt index 0952965a4..f60a0e662 100644 --- a/libtransmission/CMakeLists.txt +++ b/libtransmission/CMakeLists.txt @@ -207,18 +207,6 @@ tr_allow_compile_if( file-posix.cc subprocess-posix.cc) -foreach(UT - ${EVENT2_UPSTREAM_TARGET} - ${NATPMP_UPSTREAM_TARGET} - ${MINIUPNPC_UPSTREAM_TARGET} - ${DHT_UPSTREAM_TARGET} - ${DEFLATE_UPSTREAM_TARGET} - ${UTP_UPSTREAM_TARGET} - ${PSL_UPSTREAM_TARGET} - ${B64_UPSTREAM_TARGET}) - add_dependencies(${TR_NAME} ${UT}) -endforeach() - target_compile_definitions(${TR_NAME} PRIVATE __TRANSMISSION__ @@ -231,10 +219,7 @@ target_compile_definitions(${TR_NAME} $<$:MINIUPNPC_API_VERSION=${MINIUPNPC_API_VERSION}> # API version macro was only added in 1.7 $<$:USE_SYSTEM_B64> $<$:HAVE_SO_REUSEPORT=1> - $<$:HAVE_ICONV> - $<$:ICONV_SECOND_ARGUMENT_IS_CONST> - ${NATPMP_DEFINITIONS} - ${MINIUPNPC_DEFINITIONS} + $<$:HAVE_ICONV> PUBLIC $<$>:DISABLE_GETTEXT>) @@ -274,52 +259,38 @@ tr_target_compile_definitions_for_functions(${TR_NAME} target_include_directories(${TR_NAME} PRIVATE - ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR} INTERFACE - ${CMAKE_BINARY_DIR}) - -target_include_directories(${TR_NAME} SYSTEM - PRIVATE - ${WIDE_INTEGER_INCLUDE_DIRS} - ${UTFCPP_INCLUDE_DIRS} - ${DEFLATE_INCLUDE_DIRS} - ${FAST_FLOAT_INCLUDE_DIRS} - ${CRYPTO_INCLUDE_DIRS} - ${CURL_INCLUDE_DIRS} - ${PSL_INCLUDE_DIRS} - ${NATPMP_INCLUDE_DIRS} - ${MINIUPNPC_INCLUDE_DIRS} - ${DHT_INCLUDE_DIRS} - ${UTP_INCLUDE_DIRS} - ${B64_INCLUDE_DIRS} - $<$:${ICONV_INCLUDE_DIRS}> - PUBLIC - ${EVENT2_INCLUDE_DIRS} - ${LIBFMT_INCLUDE_DIRS}) + ${CMAKE_CURRENT_SOURCE_DIR}/.. + ${CMAKE_CURRENT_BINARY_DIR}/..) target_link_libraries(${TR_NAME} PRIVATE - ${CMAKE_THREAD_LIBS_INIT} - ${DEFLATE_LIBRARIES} - ${CRYPTO_LIBRARIES} - ${CURL_LIBRARIES} - ${EVENT2_LIBRARIES} - ${PSL_LIBRARIES} - ${NATPMP_LIBRARIES} - ${MINIUPNPC_LIBRARIES} - ${DHT_LIBRARIES} - ${UTP_LIBRARIES} - ${B64_LIBRARIES} + Threads::Threads + deflate::deflate + transmission::crypto_impl + CURL::libcurl + FastFloat::fast_float + psl::psl + natpmp::natpmp + miniupnpc::libminiupnpc + dht::dht + libutp::libutp + libb64::libb64 ${LIBINTL_LIBRARY} ${LIBM_LIBRARY} ${TR_NETWORK_LIBRARIES} jsonsl + utf8::cpp wildmat - $<$:${ICONV_LIBRARIES}> + WideInteger::WideInteger + $<$:Iconv::Iconv> $<$:crypt32> $<$:shlwapi> - "$<$:-framework Foundation>") + "$<$:-framework Foundation>" + PUBLIC + fmt::fmt-header-only + libevent::event) if(INSTALL_LIB) install( diff --git a/libtransmission/utils.cc b/libtransmission/utils.cc index 2a5ea6f3c..880750576 100644 --- a/libtransmission/utils.cc +++ b/libtransmission/utils.cc @@ -307,6 +307,28 @@ namespace namespace tr_strvUtf8Clean_impl { +class SecondIconvArg +{ +public: + explicit SecondIconvArg(char const* arg) + : arg_(arg) + { + } + + operator char**() && + { + return const_cast(&arg_); + } + + operator char const**() && + { + return &arg_; + } + +private: + char const* arg_; +}; + bool validateUtf8(std::string_view sv, char const** good_end) { auto const* begin = std::data(sv); @@ -359,15 +381,10 @@ std::string to_utf8(std::string_view sv) continue; } -#ifdef ICONV_SECOND_ARGUMENT_IS_CONST - auto const* inbuf = std::data(sv); -#else - auto* inbuf = const_cast(std::data(sv)); -#endif size_t inbytesleft = std::size(sv); char* out = std::data(buf); size_t outbytesleft = std::size(buf); - auto const rv = iconv(cd, &inbuf, &inbytesleft, &out, &outbytesleft); + auto const rv = iconv(cd, SecondIconvArg(std::data(sv)), &inbytesleft, &out, &outbytesleft); iconv_close(cd); if (rv != size_t(-1)) { diff --git a/macosx/CMakeLists.txt b/macosx/CMakeLists.txt index 34f823217..b15caaec8 100644 --- a/macosx/CMakeLists.txt +++ b/macosx/CMakeLists.txt @@ -383,14 +383,6 @@ tr_target_xib_files(${TR_NAME}-mac ${XIB_FILES} ${BASE_XIB_FILES}) -target_include_directories(${TR_NAME}-mac - PRIVATE - ${CMAKE_SOURCE_DIR}) - -target_include_directories(${TR_NAME}-mac SYSTEM - PRIVATE - ${LIBFMT_INCLUDE_DIRS}) - find_library(SPARKLE_FRAMEWORK Sparkle PATHS ${CMAKE_CURRENT_SOURCE_DIR} NO_DEFAULT_PATHS) @@ -398,6 +390,7 @@ find_library(SPARKLE_FRAMEWORK Sparkle target_link_libraries(${TR_NAME}-mac PRIVATE ${TR_NAME} + fmt::fmt-header-only vdkqueue ${SPARKLE_FRAMEWORK} "-framework AppKit" diff --git a/macosx/QuickLookPlugin/CMakeLists.txt b/macosx/QuickLookPlugin/CMakeLists.txt index 5b795d165..541d9e8f4 100644 --- a/macosx/QuickLookPlugin/CMakeLists.txt +++ b/macosx/QuickLookPlugin/CMakeLists.txt @@ -75,7 +75,6 @@ set_target_properties( target_include_directories(${TR_NAME}-mac-ql PRIVATE - ${CMAKE_SOURCE_DIR} ..) target_link_libraries(${TR_NAME}-mac-ql diff --git a/qt/CMakeLists.txt b/qt/CMakeLists.txt index d5e87cb4c..2aa42a601 100644 --- a/qt/CMakeLists.txt +++ b/qt/CMakeLists.txt @@ -202,20 +202,12 @@ endif() target_include_directories(${TR_NAME}-qt PRIVATE - ${CMAKE_SOURCE_DIR} ${CMAKE_CURRENT_SOURCE_DIR}) -target_include_directories(${TR_NAME}-qt SYSTEM - PRIVATE - ${CURL_INCLUDE_DIRS} - ${EVENT2_INCLUDE_DIRS}) - target_link_libraries(${TR_NAME}-qt PRIVATE ${TR_NAME} - ${QT_TARGETS} - ${CURL_LIBRARIES} - ${EVENT2_LIBRARIES}) + transmission::qt_impl) target_compile_definitions(${TR_NAME}-qt PRIVATE diff --git a/qt/Formatter.h b/qt/Formatter.h index 320e1757d..1d3c1dd24 100644 --- a/qt/Formatter.h +++ b/qt/Formatter.h @@ -11,7 +11,7 @@ #include // Q_DECLARE_TR_FUNCTIONS #include -#include "libtransmission/utils.h" +#include #include "Speed.h" diff --git a/tests/libtransmission/CMakeLists.txt b/tests/libtransmission/CMakeLists.txt index 7465da42e..ccc9d1185 100644 --- a/tests/libtransmission/CMakeLists.txt +++ b/tests/libtransmission/CMakeLists.txt @@ -63,27 +63,17 @@ target_compile_definitions(libtransmission-test -DLIBTRANSMISSION_TEST_ASSETS_DIR="${CMAKE_CURRENT_SOURCE_DIR}/assets" __TRANSMISSION__) -target_include_directories(libtransmission-test - PRIVATE - ${CMAKE_SOURCE_DIR}/libtransmission - ${CMAKE_BINARY_DIR}/libtransmission) - -target_include_directories(libtransmission-test SYSTEM - PRIVATE - ${LIBFMT_INCLUDE_DIRS} - ${WIDE_INTEGER_INCLUDE_DIRS} - ${B64_INCLUDE_DIRS} - ${CURL_INCLUDE_DIRS} - ${DHT_INCLUDE_DIRS} - ${EVENT2_INCLUDE_DIRS}) - target_compile_options(libtransmission-test PRIVATE $<$,$>:-Wno-sign-compare>) # patches welcomed target_link_libraries(libtransmission-test PRIVATE ${TR_NAME} - gtestall) + gtestall + dht::dht + fmt::fmt-header-only + libevent::event + WideInteger::WideInteger) add_test( NAME libtransmission-test diff --git a/tests/libtransmission/announce-list-test.cc b/tests/libtransmission/announce-list-test.cc index b9bbba022..db6b8cf8d 100644 --- a/tests/libtransmission/announce-list-test.cc +++ b/tests/libtransmission/announce-list-test.cc @@ -9,13 +9,13 @@ #include #include -#include "transmission.h" +#include -#include "announce-list.h" -#include "error.h" -#include "torrent-metainfo.h" -#include "tr-strbuf.h" -#include "variant.h" +#include +#include +#include +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/announcer-test.cc b/tests/libtransmission/announcer-test.cc index 6799f8334..59fedbf89 100644 --- a/tests/libtransmission/announcer-test.cc +++ b/tests/libtransmission/announcer-test.cc @@ -9,10 +9,10 @@ #define LIBTRANSMISSION_ANNOUNCER_MODULE -#include "transmission.h" +#include -#include "announcer-common.h" -#include "net.h" +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/announcer-udp-test.cc b/tests/libtransmission/announcer-udp-test.cc index db3f8a3d2..3d032eae1 100644 --- a/tests/libtransmission/announcer-udp-test.cc +++ b/tests/libtransmission/announcer-udp-test.cc @@ -12,14 +12,14 @@ #define LIBTRANSMISSION_ANNOUNCER_MODULE -#include "transmission.h" +#include -#include "announcer.h" -#include "announcer-common.h" -#include "crypto-utils.h" // for tr_rand_obj() -#include "peer-mgr.h" // for tr_pex -#include "timer-ev.h" -#include "tr-buffer.h" +#include +#include +#include // for tr_rand_obj() +#include // for tr_pex +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/benc-test.cc b/tests/libtransmission/benc-test.cc index 10eab6b72..7a736557e 100644 --- a/tests/libtransmission/benc-test.cc +++ b/tests/libtransmission/benc-test.cc @@ -5,9 +5,9 @@ #include -#include "transmission.h" +#include -#include "benc.h" +#include #include "gtest/gtest.h" diff --git a/tests/libtransmission/bitfield-test.cc b/tests/libtransmission/bitfield-test.cc index 60b0d8866..b7547ffff 100644 --- a/tests/libtransmission/bitfield-test.cc +++ b/tests/libtransmission/bitfield-test.cc @@ -8,9 +8,9 @@ #include #include -#include "transmission.h" -#include "crypto-utils.h" -#include "bitfield.h" +#include +#include +#include #include "gtest/gtest.h" diff --git a/tests/libtransmission/block-info-test.cc b/tests/libtransmission/block-info-test.cc index a74159c27..384354b46 100644 --- a/tests/libtransmission/block-info-test.cc +++ b/tests/libtransmission/block-info-test.cc @@ -5,9 +5,9 @@ #include -#include "transmission.h" +#include -#include "block-info.h" +#include #include "gtest/gtest.h" diff --git a/tests/libtransmission/blocklist-test.cc b/tests/libtransmission/blocklist-test.cc index 9d38e11c1..05082bf25 100644 --- a/tests/libtransmission/blocklist-test.cc +++ b/tests/libtransmission/blocklist-test.cc @@ -6,14 +6,14 @@ #include // strlen() // #include // sync() -#include "transmission.h" +#include -#include "blocklist.h" -#include "file.h" -#include "net.h" -#include "peer-socket.h" -#include "session.h" // tr_session.tr_session.addressIsBlocked() -#include "tr-strbuf.h" +#include +#include +#include +#include +#include // tr_session.tr_session.addressIsBlocked() +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/buffer-test.cc b/tests/libtransmission/buffer-test.cc index 0b13d6143..1d7022cfb 100644 --- a/tests/libtransmission/buffer-test.cc +++ b/tests/libtransmission/buffer-test.cc @@ -3,9 +3,9 @@ // or any future license endorsed by Mnemosyne LLC. // License text can be found in the licenses/ folder. -#include "transmission.h" +#include -#include "tr-buffer.h" +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/clients-test.cc b/tests/libtransmission/clients-test.cc index 4c2ba4b5e..34f2cc27d 100644 --- a/tests/libtransmission/clients-test.cc +++ b/tests/libtransmission/clients-test.cc @@ -7,10 +7,10 @@ #include #include -#include "transmission.h" +#include -#include "crypto-utils.h" // tr_rand_obj() -#include "clients.h" +#include // tr_rand_obj() +#include #include "gtest/gtest.h" diff --git a/tests/libtransmission/completion-test.cc b/tests/libtransmission/completion-test.cc index 0d6c30ff5..691c74880 100644 --- a/tests/libtransmission/completion-test.cc +++ b/tests/libtransmission/completion-test.cc @@ -8,11 +8,11 @@ #include #include -#include "transmission.h" +#include -#include "block-info.h" -#include "crypto-utils.h" // for tr_rand_obj() -#include "completion.h" +#include +#include // for tr_rand_obj() +#include #include "gtest/gtest.h" diff --git a/tests/libtransmission/copy-test.cc b/tests/libtransmission/copy-test.cc index 76a7c8b9e..316ea5928 100644 --- a/tests/libtransmission/copy-test.cc +++ b/tests/libtransmission/copy-test.cc @@ -7,9 +7,9 @@ #include #include -#include "transmission.h" -#include "error.h" -#include "file.h" +#include +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/crypto-test-ref.h b/tests/libtransmission/crypto-test-ref.h index 7be0d3465..cbbe00cea 100644 --- a/tests/libtransmission/crypto-test-ref.h +++ b/tests/libtransmission/crypto-test-ref.h @@ -41,9 +41,9 @@ #undef TR_ENCRYPTION_H #undef TR_CRYPTO_UTILS_H -#include "crypto-utils.h" -#include "crypto-utils.cc" -#include "crypto-utils-openssl.cc" +#include +#include +#include #undef tr_base64_decode #undef tr_base64_decode_impl diff --git a/tests/libtransmission/crypto-test.cc b/tests/libtransmission/crypto-test.cc index 355e8642f..febf0e1bb 100644 --- a/tests/libtransmission/crypto-test.cc +++ b/tests/libtransmission/crypto-test.cc @@ -13,11 +13,11 @@ #include #include -#include "transmission.h" +#include -#include "peer-mse.h" -#include "crypto-utils.h" -#include "utils.h" +#include +#include +#include #include "crypto-test-ref.h" diff --git a/tests/libtransmission/dht-test.cc b/tests/libtransmission/dht-test.cc index b6b215c30..45a7be8e1 100644 --- a/tests/libtransmission/dht-test.cc +++ b/tests/libtransmission/dht-test.cc @@ -11,11 +11,11 @@ #include -#include "transmission.h" +#include -#include "file.h" -#include "timer-ev.h" -#include "session-thread.h" // for tr_evthread_init(); +#include +#include +#include // for tr_evthread_init(); #include "gtest/gtest.h" #include "test-fixtures.h" diff --git a/tests/libtransmission/error-test.cc b/tests/libtransmission/error-test.cc index d55a5d143..8ec6a76ee 100644 --- a/tests/libtransmission/error-test.cc +++ b/tests/libtransmission/error-test.cc @@ -3,8 +3,8 @@ // or any future license endorsed by Mnemosyne LLC. // License text can be found in the licenses/ folder. -#include "transmission.h" -#include "error.h" +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/file-piece-map-test.cc b/tests/libtransmission/file-piece-map-test.cc index 7f8a81046..66e6c6751 100644 --- a/tests/libtransmission/file-piece-map-test.cc +++ b/tests/libtransmission/file-piece-map-test.cc @@ -7,10 +7,10 @@ #include #include -#include "transmission.h" +#include -#include "block-info.h" -#include "file-piece-map.h" +#include +#include #include "gtest/gtest.h" diff --git a/tests/libtransmission/file-test.cc b/tests/libtransmission/file-test.cc index 7002d0068..220b11d12 100644 --- a/tests/libtransmission/file-test.cc +++ b/tests/libtransmission/file-test.cc @@ -18,12 +18,12 @@ #include #endif -#include "transmission.h" +#include -#include "error.h" -#include "file.h" -#include "tr-macros.h" -#include "tr-strbuf.h" +#include +#include +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/getopt-test.cc b/tests/libtransmission/getopt-test.cc index 7f025603f..52a9ebcba 100644 --- a/tests/libtransmission/getopt-test.cc +++ b/tests/libtransmission/getopt-test.cc @@ -3,8 +3,8 @@ // or any future license endorsed by Mnemosyne LLC. // License text can be found in the licenses/ folder. -#include "transmission.h" -#include "tr-getopt.h" +#include +#include #include "gtest/gtest.h" diff --git a/tests/libtransmission/handshake-test.cc b/tests/libtransmission/handshake-test.cc index d06c0f2e6..a96b48760 100644 --- a/tests/libtransmission/handshake-test.cc +++ b/tests/libtransmission/handshake-test.cc @@ -10,12 +10,12 @@ #include -#include "transmission.h" +#include -#include "handshake.h" -#include "peer-io.h" -#include "session.h" // tr_peerIdInit() -#include "timer.h" +#include +#include +#include // tr_peerIdInit() +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/history-test.cc b/tests/libtransmission/history-test.cc index 9a2303284..4990e7376 100644 --- a/tests/libtransmission/history-test.cc +++ b/tests/libtransmission/history-test.cc @@ -3,8 +3,8 @@ // or any future license endorsed by Mnemosyne LLC. // License text can be found in the licenses/ folder. -#include "transmission.h" -#include "history.h" +#include +#include #include "gtest/gtest.h" diff --git a/tests/libtransmission/json-test.cc b/tests/libtransmission/json-test.cc index 38ae2562a..7623adf68 100644 --- a/tests/libtransmission/json-test.cc +++ b/tests/libtransmission/json-test.cc @@ -9,9 +9,9 @@ #include #include -#include "transmission.h" -#include "variant.h" -#include "variant-common.h" +#include +#include +#include #include "gtest/gtest.h" diff --git a/tests/libtransmission/lpd-test.cc b/tests/libtransmission/lpd-test.cc index 0ef1e41fa..1c2cca844 100644 --- a/tests/libtransmission/lpd-test.cc +++ b/tests/libtransmission/lpd-test.cc @@ -9,11 +9,11 @@ #include #include -#include "transmission.h" +#include -#include "crypto-utils.h" // tr_rand_obj() -#include "session.h" -#include "tr-lpd.h" +#include // tr_rand_obj() +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/magnet-metainfo-test.cc b/tests/libtransmission/magnet-metainfo-test.cc index 35409525a..ac8bec91c 100644 --- a/tests/libtransmission/magnet-metainfo-test.cc +++ b/tests/libtransmission/magnet-metainfo-test.cc @@ -8,10 +8,10 @@ #include "gtest/gtest.h" -#include "transmission.h" +#include -#include "magnet-metainfo.h" -#include "crypto-utils.h" // tr_rand_buffer() +#include +#include // tr_rand_buffer() using namespace std::literals; diff --git a/tests/libtransmission/makemeta-test.cc b/tests/libtransmission/makemeta-test.cc index e2242fff4..f62befa82 100644 --- a/tests/libtransmission/makemeta-test.cc +++ b/tests/libtransmission/makemeta-test.cc @@ -14,13 +14,13 @@ #include -#include "transmission.h" +#include -#include "crypto-utils.h" -#include "file.h" -#include "makemeta.h" -#include "session.h" // TR_NAME -#include "torrent-metainfo.h" +#include +#include +#include +#include // TR_NAME +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/move-test.cc b/tests/libtransmission/move-test.cc index b2e7439df..cc5dc05ce 100644 --- a/tests/libtransmission/move-test.cc +++ b/tests/libtransmission/move-test.cc @@ -11,12 +11,12 @@ #include -#include "transmission.h" +#include -#include "cache.h" // tr_cacheWriteBlock() -#include "file.h" // tr_sys_path_*() -#include "tr-strbuf.h" -#include "variant.h" +#include // tr_cacheWriteBlock() +#include // tr_sys_path_*() +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/net-test.cc b/tests/libtransmission/net-test.cc index d9b1c465e..f696f0210 100644 --- a/tests/libtransmission/net-test.cc +++ b/tests/libtransmission/net-test.cc @@ -7,10 +7,10 @@ #include #include -#include "transmission.h" +#include -#include "net.h" -#include "peer-mgr.h" +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/open-files-test.cc b/tests/libtransmission/open-files-test.cc index 1a0ebe4bc..ca7473469 100644 --- a/tests/libtransmission/open-files-test.cc +++ b/tests/libtransmission/open-files-test.cc @@ -6,11 +6,11 @@ #include #include -#include "transmission.h" +#include -#include "error.h" -#include "file.h" -#include "tr-strbuf.h" +#include +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/peer-mgr-active-requests-test.cc b/tests/libtransmission/peer-mgr-active-requests-test.cc index 220482839..1ded8bd47 100644 --- a/tests/libtransmission/peer-mgr-active-requests-test.cc +++ b/tests/libtransmission/peer-mgr-active-requests-test.cc @@ -8,9 +8,9 @@ #include #include -#include "transmission.h" +#include -#include "peer-mgr-active-requests.h" +#include #include "gtest/gtest.h" diff --git a/tests/libtransmission/peer-mgr-wishlist-test.cc b/tests/libtransmission/peer-mgr-wishlist-test.cc index a12755d2a..3d0244424 100644 --- a/tests/libtransmission/peer-mgr-wishlist-test.cc +++ b/tests/libtransmission/peer-mgr-wishlist-test.cc @@ -9,9 +9,9 @@ #define LIBTRANSMISSION_PEER_MODULE -#include "transmission.h" +#include -#include "peer-mgr-wishlist.h" +#include #include "gtest/gtest.h" diff --git a/tests/libtransmission/peer-msgs-test.cc b/tests/libtransmission/peer-msgs-test.cc index 8b8c1d759..86f0b8869 100644 --- a/tests/libtransmission/peer-msgs-test.cc +++ b/tests/libtransmission/peer-msgs-test.cc @@ -5,8 +5,8 @@ #include -#include "transmission.h" -#include "peer-msgs.h" +#include +#include #include "gtest/gtest.h" diff --git a/tests/libtransmission/platform-test.cc b/tests/libtransmission/platform-test.cc index 0d7f240b4..63d86a406 100644 --- a/tests/libtransmission/platform-test.cc +++ b/tests/libtransmission/platform-test.cc @@ -6,11 +6,11 @@ #include #include -#include "transmission.h" +#include -#include "file.h" -#include "platform.h" -#include "tr-strbuf.h" +#include +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/quark-test.cc b/tests/libtransmission/quark-test.cc index 56a0f3e47..4b3f69bdc 100644 --- a/tests/libtransmission/quark-test.cc +++ b/tests/libtransmission/quark-test.cc @@ -3,8 +3,8 @@ // or any future license endorsed by Mnemosyne LLC. // License text can be found in the licenses/ folder. -#include "transmission.h" -#include "quark.h" +#include +#include #include "gtest/gtest.h" diff --git a/tests/libtransmission/remove-test.cc b/tests/libtransmission/remove-test.cc index d9e41500e..101d62aec 100644 --- a/tests/libtransmission/remove-test.cc +++ b/tests/libtransmission/remove-test.cc @@ -9,11 +9,11 @@ #include #include -#include "transmission.h" +#include -#include "file.h" -#include "torrent-files.h" -#include "tr-strbuf.h" +#include +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/rename-test.cc b/tests/libtransmission/rename-test.cc index 99f90b0f4..65c1f047c 100644 --- a/tests/libtransmission/rename-test.cc +++ b/tests/libtransmission/rename-test.cc @@ -3,14 +3,14 @@ // or any future license endorsed by Mnemosyne LLC. // License text can be found in the licenses/ folder. -#include "transmission.h" +#include -#include "file.h" -#include "resume.h" -#include "torrent.h" // tr_isTorrent() -#include "tr-assert.h" -#include "tr-strbuf.h" -#include "variant.h" +#include +#include +#include // tr_isTorrent() +#include +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/rpc-test.cc b/tests/libtransmission/rpc-test.cc index 313369c0e..c0fa7e1fd 100644 --- a/tests/libtransmission/rpc-test.cc +++ b/tests/libtransmission/rpc-test.cc @@ -3,9 +3,9 @@ // or any future license endorsed by Mnemosyne LLC. // License text can be found in the licenses/ folder. -#include "transmission.h" -#include "rpcimpl.h" -#include "variant.h" +#include +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/session-alt-speeds-test.cc b/tests/libtransmission/session-alt-speeds-test.cc index a572840e1..35e48afd9 100644 --- a/tests/libtransmission/session-alt-speeds-test.cc +++ b/tests/libtransmission/session-alt-speeds-test.cc @@ -8,10 +8,10 @@ #include -#include "transmission.h" -#include "session.h" -#include "session-id.h" -#include "version.h" +#include +#include +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/session-test.cc b/tests/libtransmission/session-test.cc index 2dcd05197..2242a5925 100644 --- a/tests/libtransmission/session-test.cc +++ b/tests/libtransmission/session-test.cc @@ -3,12 +3,12 @@ // or any future license endorsed by Mnemosyne LLC. // License text can be found in the licenses/ folder. -#include "transmission.h" +#include -#include "session-alt-speeds.h" -#include "session-id.h" -#include "session.h" -#include "version.h" +#include +#include +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/settings-test.cc b/tests/libtransmission/settings-test.cc index ade4f1c5f..3707a2d20 100644 --- a/tests/libtransmission/settings-test.cc +++ b/tests/libtransmission/settings-test.cc @@ -3,9 +3,9 @@ // or any future license endorsed by Mnemosyne LLC. // License text can be found in the licenses/ folder. -#include "transmission.h" +#include -#include "session-settings.h" +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/strbuf-test.cc b/tests/libtransmission/strbuf-test.cc index ecead8a20..064728c59 100644 --- a/tests/libtransmission/strbuf-test.cc +++ b/tests/libtransmission/strbuf-test.cc @@ -6,9 +6,9 @@ #include #include -#include "transmission.h" +#include -#include "tr-strbuf.h" +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/subprocess-test.cc b/tests/libtransmission/subprocess-test.cc index eb7b5b557..2bb2413de 100644 --- a/tests/libtransmission/subprocess-test.cc +++ b/tests/libtransmission/subprocess-test.cc @@ -3,11 +3,11 @@ // or any future license endorsed by Mnemosyne LLC. // License text can be found in the licenses/ folder. -#include "transmission.h" -#include "error.h" -#include "file.h" -#include "platform.h" -#include "subprocess.h" +#include +#include +#include +#include +#include #include "gtest/internal/gtest-port.h" // GetArgvs() diff --git a/tests/libtransmission/test-fixtures.h b/tests/libtransmission/test-fixtures.h index b6224aa34..4c8755f4b 100644 --- a/tests/libtransmission/test-fixtures.h +++ b/tests/libtransmission/test-fixtures.h @@ -18,14 +18,14 @@ #include -#include "crypto-utils.h" // tr_base64_decode() -#include "error.h" -#include "file.h" // tr_sys_file_*() -#include "platform.h" // TR_PATH_DELIMITER -#include "quark.h" -#include "torrent.h" -#include "utils.h" -#include "variant.h" +#include // tr_base64_decode() +#include +#include // tr_sys_file_*() +#include // TR_PATH_DELIMITER +#include +#include +#include +#include #include "gtest/gtest.h" diff --git a/tests/libtransmission/timer-test.cc b/tests/libtransmission/timer-test.cc index 9ae2d2ede..a88a619bf 100644 --- a/tests/libtransmission/timer-test.cc +++ b/tests/libtransmission/timer-test.cc @@ -3,10 +3,10 @@ // or any future license endorsed by Mnemosyne LLC. // License text can be found in the licenses/ folder. -#include "transmission.h" +#include -#include "timer-ev.h" -#include "utils-ev.h" +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/torrent-files-test.cc b/tests/libtransmission/torrent-files-test.cc index 447c89a1f..f3d17d447 100644 --- a/tests/libtransmission/torrent-files-test.cc +++ b/tests/libtransmission/torrent-files-test.cc @@ -7,9 +7,9 @@ #include #include -#include "transmission.h" +#include -#include "torrent-files.h" +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/torrent-magnet-test.cc b/tests/libtransmission/torrent-magnet-test.cc index 479d1b060..d812ad4f6 100644 --- a/tests/libtransmission/torrent-magnet-test.cc +++ b/tests/libtransmission/torrent-magnet-test.cc @@ -5,13 +5,13 @@ #include -#include "transmission.h" +#include -#include "crypto-utils.h" -#include "error.h" -#include "torrent-magnet.h" -#include "torrent-metainfo.h" -#include "torrent.h" +#include +#include +#include +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/torrent-metainfo-test.cc b/tests/libtransmission/torrent-metainfo-test.cc index 9b89480da..48c1a9137 100644 --- a/tests/libtransmission/torrent-metainfo-test.cc +++ b/tests/libtransmission/torrent-metainfo-test.cc @@ -6,14 +6,14 @@ #include #include -#include "transmission.h" +#include -#include "crypto-utils.h" -#include "error.h" -#include "torrent-metainfo.h" -#include "torrent.h" -#include "tr-strbuf.h" -#include "utils.h" +#include +#include +#include +#include +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/torrents-test.cc b/tests/libtransmission/torrents-test.cc index 36b944f2a..483157df2 100644 --- a/tests/libtransmission/torrents-test.cc +++ b/tests/libtransmission/torrents-test.cc @@ -7,10 +7,10 @@ #include #include -#include "transmission.h" +#include -#include "torrent.h" -#include "torrents.h" +#include +#include #include "gtest/gtest.h" diff --git a/tests/libtransmission/utils-test.cc b/tests/libtransmission/utils-test.cc index 64a5d09f2..ca6e0f6ae 100644 --- a/tests/libtransmission/utils-test.cc +++ b/tests/libtransmission/utils-test.cc @@ -20,12 +20,12 @@ #define unsetenv(key) SetEnvironmentVariableA(key, nullptr) #endif -#include "transmission.h" +#include -#include "crypto-utils.h" // tr_rand_int() -#include "platform.h" -#include "tr-strbuf.h" -#include "utils.h" +#include // tr_rand_int() +#include +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/variant-test.cc b/tests/libtransmission/variant-test.cc index 1dc0be2ca..2a30c8637 100644 --- a/tests/libtransmission/variant-test.cc +++ b/tests/libtransmission/variant-test.cc @@ -5,13 +5,13 @@ #define LIBTRANSMISSION_VARIANT_MODULE -#include "transmission.h" +#include -#include "benc.h" -#include "crypto-utils.h" // tr_rand_buffer(), tr_rand_int() -#include "error.h" -#include "variant-common.h" -#include "variant.h" +#include +#include // tr_rand_buffer(), tr_rand_int() +#include +#include +#include #include #include diff --git a/tests/libtransmission/watchdir-test.cc b/tests/libtransmission/watchdir-test.cc index 57423f7aa..c8b818db6 100644 --- a/tests/libtransmission/watchdir-test.cc +++ b/tests/libtransmission/watchdir-test.cc @@ -10,13 +10,13 @@ #define LIBTRANSMISSION_WATCHDIR_MODULE -#include "transmission.h" +#include -#include "file.h" -#include "net.h" -#include "watchdir.h" -#include "watchdir-base.h" -#include "timer-ev.h" +#include +#include +#include +#include +#include #include "test-fixtures.h" diff --git a/tests/libtransmission/web-utils-test.cc b/tests/libtransmission/web-utils-test.cc index 2819f473b..8c3100529 100644 --- a/tests/libtransmission/web-utils-test.cc +++ b/tests/libtransmission/web-utils-test.cc @@ -11,11 +11,11 @@ #define unsetenv(key) SetEnvironmentVariableA(key, nullptr) #endif -#include "transmission.h" +#include -#include "crypto-utils.h" -#include "platform.h" -#include "web-utils.h" +#include +#include +#include #include "test-fixtures.h" diff --git a/utils/CMakeLists.txt b/utils/CMakeLists.txt index 614f4cefd..35abbe55c 100644 --- a/utils/CMakeLists.txt +++ b/utils/CMakeLists.txt @@ -5,20 +5,12 @@ foreach(P create edit remote show) PRIVATE ${P}.cc) - target_include_directories(${TR_NAME}-${P} - PRIVATE - ${CMAKE_SOURCE_DIR}) - - target_include_directories(${TR_NAME}-${P} SYSTEM - PRIVATE - ${LIBFMT_INCLUDE_DIRS} - ${EVENT2_INCLUDE_DIRS} - ${CURL_INCLUDE_DIRS}) - target_link_libraries(${TR_NAME}-${P} PRIVATE ${TR_NAME} - ${CURL_LIBRARIES}) + CURL::libcurl + fmt::fmt-header-only + libevent::event) tr_win32_app_info(${TR_NAME}-${P} "Transmission Utility ('${P}')"