mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2024-12-24 08:43:27 +00:00
Code Issues Releases Wiki Activity

fix: assertion failed: port_empty in tr_swarm::remove_peer() (#6062)

Browse source
This commit is contained in:
Yat Ho 2023-10-03 00:57:48 +08:00 committed by GitHub
parent 170f589b64
commit 5808f72f50
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
libtransmission/peer-mgr.cc
View file

@ -273,8 +273,7 @@ public:
auto* const peer_info = peer->peer_info; auto* const peer_info = peer->peer_info;
auto const socket_address = peer->socket_address(); auto const socket_address = peer->socket_address();
auto const listen_socket_address = peer_info->listen_socket_address(); [[maybe_unused]] auto const is_incoming = peer->is_incoming_connection();
auto const was_incoming = peer->is_incoming_connection();
TR_ASSERT(peer_info != nullptr); TR_ASSERT(peer_info != nullptr);
--stats.peer_count; --stats.peer_count;
@ -288,15 +287,16 @@ public:
delete peer; delete peer;
if (was_incoming) if (std::empty(peer_info->listen_port())) // is not connectable
{ {
[[maybe_unused]] auto const port_empty = std::empty(peer_info->listen_port()); TR_ASSERT(is_incoming);
if (incoming_pool.erase(socket_address) != 0U) [[maybe_unused]] auto const count = incoming_pool.erase(socket_address);
{ TR_ASSERT(count != 0U);
TR_ASSERT(port_empty); }
} else
{
graveyard_pool.erase(peer_info->listen_socket_address());
} }
graveyard_pool.erase(listen_socket_address);
} }
void remove_all_peers() void remove_all_peers()