mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity

random code optimization: when escaping http, use an if with a lot less comparisons rather than a switch

This commit is contained in:
Mitchell Livingston 2010-01-10 14:56:04 +00:00
parent 8f6e1dedf5
commit 5af45426d4
1 changed files with 6 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
libtransmission/web.c
View File

@ -514,32 +514,14 @@ tr_http_escape( struct evbuffer * out,
len = strlen( str );
for( i = 0; i < len; i++ ) {
switch( str[i] ) {
case ',': case '-': case '.':
case '0': case '1': case '2': case '3': case '4':
case '5': case '6': case '7': case '8': case '9':
case 'a': case 'b': case 'c': case 'd': case 'e':
case 'f': case 'g': case 'h': case 'i': case 'j':
case 'k': case 'l': case 'm': case 'n': case 'o':
case 'p': case 'q': case 'r': case 's': case 't':
case 'u': case 'v': case 'w': case 'x': case 'y': case 'z':
case 'A': case 'B': case 'C': case 'D': case 'E':
case 'F': case 'G': case 'H': case 'I': case 'J':
case 'K': case 'L': case 'M': case 'N': case 'O':
case 'P': case 'Q': case 'R': case 'S': case 'T':
case 'U': case 'V': case 'W': case 'X': case 'Y': case 'Z':
if( str[i] == ',' || str[i] == '-' || str[i] == '.'
|| ( '0' <= str[i] && str[i] <= '9' )
|| ( 'a' <= str[i] && str[i] <= 'z' )
|| ( 'A' <= str[i] && str[i] <= 'Z' )
|| ( str[i] == '/' && !escape_slashes ) )
evbuffer_add( out, &str[i], 1 );
break;
case '/':
if(!escape_slashes) {
evbuffer_add( out, &str[i], 1 );
break;
}
/* Fall through. */
default:
else
evbuffer_add_printf( out, "%%%02X", (unsigned)(str[i]&0xFF) );
break;
}
}
}