mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-03-03 10:15:45 +00:00
Code Issues Releases Wiki Activity

(gtk) #1453: follow Gnome HIG; the "details" dialog should be a "properties" dialog

Browse source
This commit is contained in:
Charles Kerr 2008-11-13 04:10:04 +00:00
parent aeb6e3aac3
commit 5b96ba110c
6 changed files with 12 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
gtk/actions.c
View file

@ -152,9 +152,8 @@ static GtkActionEntry entries[] =
action_cb ) },
{ "edit-preferences", GTK_STOCK_PREFERENCES, NULL,
NULL, NULL, G_CALLBACK( action_cb ) },
{ "show-torrent-details", GTK_STOCK_INFO,
N_( "_Details" ), "<alt>Return", N_( "Torrent details" ), G_CALLBACK(
action_cb ) },
{ "show-torrent-properties", GTK_STOCK_PROPERTIES,
NULL, "<alt>Return", N_( "Torrent properties" ), G_CALLBACK( action_cb ) },
{ "open-torrent-folder", GTK_STOCK_OPEN,
N_( "_Open Folder" ), NULL, NULL, G_CALLBACK( action_cb ) },
{ "show-about-dialog", GTK_STOCK_ABOUT, NULL,

7
gtk/details.c
View file

@ -1477,16 +1477,11 @@ torrent_inspector_new( GtkWindow * parent,
guint tag;
GtkWidget * d, *n, *w;
tr_torrent * tor = tr_torrent_handle ( gtor );
char sizeStr[64];
char title[512];
const tr_info * info = tr_torrent_info ( gtor );
/* create the dialog */
tr_strlsize( sizeStr, info->totalSize, sizeof( sizeStr ) );
/* %1$s is torrent name
%2$s its file size */
g_snprintf( title, sizeof( title ), _(
"Details for %1$s (%2$s)" ), info->name, sizeStr );
g_snprintf( title, sizeof( title ), _( "%s Properties" ), info->name );
d = gtk_dialog_new_with_buttons ( title, parent, 0,
GTK_STOCK_CLOSE, GTK_RESPONSE_CLOSE,
NULL );

6
gtk/file-list.c
View file

@ -794,7 +794,7 @@ file_list_new( TrTorrent * gtor )
col = GTK_TREE_VIEW_COLUMN ( g_object_new ( GTK_TYPE_TREE_VIEW_COLUMN,
"expand", TRUE,
/* Translators: this is a column
header in Files tab, Details
header in Files tab, Properties
dialog;
Don't include the prefix
"filedetails|" in the
@ -816,7 +816,7 @@ file_list_new( TrTorrent * gtor )
rend = gtk_cell_renderer_progress_new( );
/* Translators: this is a column header in Files tab, Details dialog;
/* Translators: this is a column header in Files tab, Properties dialog;
Don't include the prefix "filedetails|" in the translation. */
col = gtk_tree_view_column_new_with_attributes( Q_( "filedetails|Progress" ), rend, NULL );
gtk_tree_view_column_set_cell_data_func( col, rend, renderProgress, NULL, NULL );
@ -825,7 +825,7 @@ file_list_new( TrTorrent * gtor )
/* add "enabled" column */
rend = gtk_cell_renderer_toggle_new( );
/* Translators: this is a column header in Files tab, Details dialog;
/* Translators: this is a column header in Files tab, Properties dialog;
Don't include the prefix "filedetails|" in the translation.
The items for this column are checkboxes (yes/no) */
col = gtk_tree_view_column_new_with_attributes( Q_( "filedetails|Download" ), rend, NULL );

4
gtk/main.c
View file

@ -220,7 +220,7 @@ refreshTorrentActions( GtkTreeSelection * s )
action_sensitize( "delete-torrent", counts.totalCount != 0 );
action_sensitize( "verify-torrent", counts.totalCount != 0 );
action_sensitize( "open-torrent-folder", counts.totalCount == 1 );
action_sensitize( "show-torrent-details", counts.totalCount == 1 );
action_sensitize( "show-torrent-properties", counts.totalCount == 1 );
canUpdate = 0;
gtk_tree_selection_selected_foreach( s, accumulateCanUpdateForeach,
@ -1484,7 +1484,7 @@ doAction( const char * action_name,
GtkTreeSelection * s = tr_window_get_selection( data->wind );
gtk_tree_selection_selected_foreach( s, openFolderForeach, data );
}
else if( !strcmp ( action_name, "show-torrent-details" ) )
else if( !strcmp ( action_name, "show-torrent-properties" ) )
{
GtkTreeSelection * s = tr_window_get_selection( data->wind );
gtk_tree_selection_selected_foreach( s, showInfoForeach, data );

2
gtk/tr-window.c
View file

@ -128,7 +128,7 @@ view_row_activated( GtkTreeView * tree_view UNUSED,
GtkTreeViewColumn * column UNUSED,
gpointer user_data UNUSED )
{
action_activate( "show-torrent-details" );
action_activate( "show-torrent-properties" );
}
static gboolean is_row_visible( GtkTreeModel *,

6
gtk/ui.h
View file

@ -5,7 +5,7 @@ static const char * fallback_ui_file =
" <menuitem action='add-torrent-menu'/>\n"
" <menuitem action='new-torrent'/>\n"
" <separator/>\n"
" <menuitem action='show-torrent-details'/>\n"
" <menuitem action='show-torrent-properties'/>\n"
" <menuitem action='open-torrent-folder'/>\n"
" <separator/>\n"
" <menuitem action='start-torrent'/>\n"
@ -55,11 +55,11 @@ static const char * fallback_ui_file =
" <toolitem action='pause-torrent'/>\n"
" <toolitem action='remove-torrent'/>\n"
" <separator/>\n"
" <toolitem action='show-torrent-details'/>\n"
" <toolitem action='show-torrent-properties'/>\n"
" </toolbar>\n"
"\n"
" <popup name='main-window-popup'>\n"
" <menuitem action='show-torrent-details'/>\n"
" <menuitem action='show-torrent-properties'/>\n"
" <menuitem action='open-torrent-folder'/>\n"
" <separator/>\n"
" <menuitem action='start-torrent'/>\n"