mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-02-22 14:10:34 +00:00
Code Issues Releases Wiki Activity

(trunk libT) #3154 "crash when saving a blocklist to disk when the disk is full" -- fixed in trunk for 2.00

Browse source
This commit is contained in:
Charles Kerr 2010-04-19 16:18:12 +00:00
parent f939207703
commit 657a2a4588
1 changed files with 33 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
libtransmission/rpcimpl.c
View file

@ -12,6 +12,7 @@
#include <assert.h>
#include <ctype.h> /* isdigit */
#include <errno.h>
#include <stdlib.h> /* strtol */
#include <string.h> /* strcmp */
#include <unistd.h> /* unlink */
@ -903,26 +904,44 @@ gotNewBlocklist( tr_session * session,
tr_snprintf( result, sizeof( result ), "http error %ld: %s",
response_code, tr_webGetResponseStr( response_code ) );
}
else /* success */
else /* successfully fetched the blocklist... */
{
int ruleCount;
char * filename = tr_buildPath( tr_sessionGetConfigDir( session ), "blocklist.tmp", NULL );
FILE * fp;
const char * configDir = tr_sessionGetConfigDir( session );
char * filename = tr_buildPath( configDir, "blocklist.tmp", NULL );
FILE * fp = fopen( filename, "w+" );
/* download a new blocklist */
fp = fopen( filename, "w+" );
fwrite( response, 1, response_byte_count, fp );
fclose( fp );
if( fp == NULL )
{
tr_snprintf( result, sizeof( result ),
_( "Couldn't save file \"%1$s\": %2$s" ),
filename, tr_strerror( errno ) );
}
else
{
const size_t n = fwrite( response, 1, response_byte_count, fp );
fclose( fp );
/* feed it to the session */
ruleCount = tr_blocklistSetContent( session, filename );
if( n != response_byte_count )
{
tr_snprintf( result, sizeof( result ),
_( "Couldn't save file \"%1$s\": %2$s" ),
filename, tr_strerror( errno ) );
}
else
{
/* feed it to the session */
const int ruleCount = tr_blocklistSetContent( session, filename );
/* give the client a response */
tr_bencDictAddInt( data->args_out, "blocklist-size", ruleCount );
tr_snprintf( result, sizeof( result ), "success" );
/* give the client a response */
tr_bencDictAddInt( data->args_out, "blocklist-size", ruleCount );
tr_snprintf( result, sizeof( result ), "success" );
}
/* cleanup */
unlink( filename );
}
/* cleanup */
unlink( filename );
tr_free( filename );
}