From 65a3a7d04293c104d5991b151649fed9651f077e Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Wed, 13 Oct 2021 18:12:51 -0500 Subject: [PATCH] build: have clang-tidy check for NULL in libtransmission (#1945) --- libtransmission/.clang-tidy | 7 +++++++ libtransmission/session.cc | 2 +- libtransmission/tr-lpd.cc | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) create mode 100644 libtransmission/.clang-tidy diff --git a/libtransmission/.clang-tidy b/libtransmission/.clang-tidy new file mode 100644 index 000000000..738b43bf4 --- /dev/null +++ b/libtransmission/.clang-tidy @@ -0,0 +1,7 @@ +--- +# Many of these checks are disabled only because the code hasn't been +# cleaned up yet. Pull requests welcomed. +Checks: > + modernize-use-nullptr, + modernize-use-override + diff --git a/libtransmission/session.cc b/libtransmission/session.cc index 228197da0..4cb1eb395 100644 --- a/libtransmission/session.cc +++ b/libtransmission/session.cc @@ -1140,7 +1140,7 @@ static void sessionSetImpl(void* vdata) tr_sessionSetScriptEnabled(session, TR_SCRIPT_ON_TORRENT_ADDED, boolVal); } - if (tr_variantDictFindStr(settings, TR_KEY_script_torrent_added_filename, &strVal, NULL)) + if (tr_variantDictFindStr(settings, TR_KEY_script_torrent_added_filename, &strVal, nullptr)) { tr_sessionSetScript(session, TR_SCRIPT_ON_TORRENT_ADDED, strVal); } diff --git a/libtransmission/tr-lpd.cc b/libtransmission/tr-lpd.cc index bd50cbc1b..37df3b6c0 100644 --- a/libtransmission/tr-lpd.cc +++ b/libtransmission/tr-lpd.cc @@ -296,7 +296,7 @@ int tr_lpdInit(tr_session* ss, [[maybe_unused]] tr_address* tr_addr) * string handling in tr_lpdSendAnnounce() and tr_lpdConsiderAnnounce(). * However, the code should work as long as interfaces to the rest of * libtransmission are compatible with char* strings. */ - TR_STATIC_ASSERT(sizeof(((struct tr_info*)0)->hashString[0]) == sizeof(char), ""); + TR_STATIC_ASSERT(sizeof(((struct tr_info*)nullptr)->hashString[0]) == sizeof(char), ""); struct ip_mreq mcastReq; int const opt_on = 1;