mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-03-03 18:25:35 +00:00
Code Issues Releases Wiki Activity

DL/UL speed typography changes for web ui

Browse source 
The current icons are very hard to read at the current font size and it's not immediately visible which icon i which.

Additionally, spaces after icons are removed because upload icon is equally positioned between DL/UL speeds (like so `↓ 273 kB/s **↑** 0 kB/s`) which requires reading the whole line to make sense of which number the arrow applies to.

To further separate one type of information from another the hyphen is replaced by the slightly wider en dash.

Old vs New:
Downloading from 7 of 19 peers - ↓ 273 kB/s ↑ 167 kB/s
Downloading from 7 of 19 peers – ▼273 kB/s ▲167 kB/s
This commit is contained in:
Alexander Futekov 2017-08-07 06:34:00 +03:00 committed by GitHub
parent 30467baa87
commit 660b44da70
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
web/javascript/torrent-row.js
View file

@ -100,11 +100,11 @@ TorrentRendererHelper.renderProgressbar = function (controller, t, progressbar)
}; };
TorrentRendererHelper.formatUL = function (t) { TorrentRendererHelper.formatUL = function (t) {
return '↑ ' + Transmission.fmt.speedBps(t.getUploadSpeed()); return '▲' + Transmission.fmt.speedBps(t.getUploadSpeed());
}; };
TorrentRendererHelper.formatDL = function (t) { TorrentRendererHelper.formatDL = function (t) {
return '↓ ' + Transmission.fmt.speedBps(t.getDownloadSpeed()); return '▼' + Transmission.fmt.speedBps(t.getDownloadSpeed());
}; };
TorrentRendererHelper.formatETA = function(t) { TorrentRendererHelper.formatETA = function(t) {
@ -181,7 +181,7 @@ TorrentRendererFull.prototype = {
fmt.countString('peer', 'peers', peer_count), fmt.countString('peer', 'peers', peer_count),
'and', 'and',
fmt.countString('web seed', 'web seeds', webseed_count), fmt.countString('web seed', 'web seeds', webseed_count),
'-', '–',
TorrentRendererHelper.formatDL(t), TorrentRendererHelper.formatDL(t),
TorrentRendererHelper.formatUL(t) TorrentRendererHelper.formatUL(t)
].join(' '); ].join(' ');
@ -189,7 +189,7 @@ TorrentRendererFull.prototype = {
// Downloading from 2 webseed(s) // Downloading from 2 webseed(s)
return ['Downloading from', return ['Downloading from',
fmt.countString('web seed', 'web seeds', webseed_count), fmt.countString('web seed', 'web seeds', webseed_count),
'-', '–',
TorrentRendererHelper.formatDL(t), TorrentRendererHelper.formatDL(t),
TorrentRendererHelper.formatUL(t) TorrentRendererHelper.formatUL(t)
].join(' '); ].join(' ');
@ -199,7 +199,7 @@ TorrentRendererFull.prototype = {
t.getPeersSendingToUs(), t.getPeersSendingToUs(),
'of', 'of',
fmt.countString('peer', 'peers', peer_count), fmt.countString('peer', 'peers', peer_count),
'-', '–',
TorrentRendererHelper.formatDL(t), TorrentRendererHelper.formatDL(t),
TorrentRendererHelper.formatUL(t) TorrentRendererHelper.formatUL(t)
].join(' '); ].join(' ');