From 6a212e7e8ec83528aa88fa925928b2eeb4f6d2f1 Mon Sep 17 00:00:00 2001 From: Hendrik Luup Date: Sat, 9 Mar 2024 17:34:44 +0200 Subject: [PATCH] fix(web): do not close all popups on successful rpc requests (#6675) Fixes regression introduced in 250f43ae --- web/src/remote.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/web/src/remote.js b/web/src/remote.js index fb7aaba79..1c7b5b7db 100644 --- a/web/src/remote.js +++ b/web/src/remote.js @@ -57,7 +57,10 @@ export class Remote { callback.call(context, payload, response_argument); } - this._connection_alert = null; + if (this._connection_alert) { + this._connection_alert.close(); + this._connection_alert = null; + } }) .catch((error) => { if (error.message === Remote._SessionHeader) { @@ -74,8 +77,6 @@ export class Remote { message: 'Could not connect to the server. You may need to reload the page to reconnect.', }); - }) - .finally(() => { this._controller.setCurrentPopup(this._connection_alert); }); }