mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-01-03 05:25:52 +00:00
Code Issues Releases Wiki Activity

fixup! perf: improve sorting performance in tr_peerMgrGetPeers() (#5807)

Browse source
This commit is contained in:
tearfur 2023-08-14 11:02:11 +08:00 committed by GitHub
parent 629f7cb86f
commit 72f604dbf8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
libtransmission/peer-mgr.cc
View file

@ -1312,26 +1312,31 @@ std::vector<tr_pex> tr_peerMgrGetPeers(tr_torrent const* tor, uint8_t address_ty
tr_swarm const* s = tor->swarm;
// build a list of atoms
// build a list of peer info objects
auto infos = std::vector<tr_peer_info const*>{};
if (list_mode == TR_PEERS_CONNECTED) /* connected peers only */
{
auto const& peers = s->peers;
infos.reserve(std::size(peers));
std::transform(
std::begin(peers),
std::end(peers),
std::back_inserter(infos),
[](auto const* peer) { return peer->peer_info; });
for (auto const* peer : peers)
{
if (peer->socket_address().address().type == address_type)
{
infos.emplace_back(peer->peer_info);
}
}
}
else /* TR_PEERS_INTERESTING */
{
for (auto const& [socket_address, peer_info] : s->connectable_pool)
auto const& pool = s->connectable_pool;
infos.reserve(std::size(pool));
for (auto const& [socket_address, peer_info] : pool)
{
if (is_peer_interesting(tor, peer_info))
TR_ASSERT(socket_address == peer_info.listen_socket_address());
if (socket_address.address().type == address_type && is_peer_interesting(tor, peer_info))
{
infos.push_back(&peer_info);
infos.emplace_back(&peer_info);
}
}
}
@ -1349,11 +1354,9 @@ std::vector<tr_pex> tr_peerMgrGetPeers(tr_torrent const* tor, uint8_t address_ty
{
auto const& [addr, port] = info->listen_socket_address();
if (addr.type == address_type)
{
TR_ASSERT(addr.is_valid());
pex.emplace_back(addr, port, info->pex_flags());
}
TR_ASSERT(addr.is_valid());
TR_ASSERT(addr.type == address_type);
pex.emplace_back(addr, port, info->pex_flags());
}
std::sort(std::begin(pex), std::end(pex));