mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity

Do not use void to denote argumentless functions in C++ code

This commit is contained in:
Mike Gelfand 2014-12-14 11:57:23 +00:00
parent c845e35ce1
commit 737fdab775
4 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qt/app.cc
View File

@ -61,14 +61,14 @@ namespace
};
const char*
getUsage (void)
getUsage ()
{
return "Usage:\n"
" transmission [OPTIONS...] [torrent files]";
}
void
showUsage (void)
showUsage ()
{
tr_getopt_usage (MY_READABLE_NAME, getUsage (), opts);
exit (0);

4
qt/mainwin.h
View File

@ -145,8 +145,8 @@ class TrMainWindow: public QMainWindow
QWidget * myFilterBar;
private:
QMenu * createOptionsMenu (void);
QWidget * createStatusBar (void);
QMenu * createOptionsMenu ();
QWidget * createStatusBar ();
QWidget * myStatusBar;
QPushButton * myAltSpeedButton;
QAction * myAltSpeedAction;

6
qt/make-dialog.cc
View File

@ -354,7 +354,7 @@ MakeDialog::MakeDialog (Session& session, QWidget * parent):
myDestination = QDir::homePath();
b->setText (myDestination);
connect (b, SIGNAL(clicked(bool)),
this, SLOT(onDestinationClicked(void)));
this, SLOT(onDestinationClicked()));
myDestinationButton = b;
hig->addRow (tr ("Sa&ve to:"), b);
@ -366,7 +366,7 @@ MakeDialog::MakeDialog (Session& session, QWidget * parent):
myFolderButton->setText (tr ("(None)"));
myFolderButton->setStyleSheet (QString::fromUtf8 ("text-align: left; padding-left: 5; padding-right: 5"));
connect (myFolderButton, SIGNAL(clicked(bool)),
this, SLOT(onFolderClicked(void)));
this, SLOT(onFolderClicked()));
hig->addRow (myFolderRadio, myFolderButton);
enableBuddyWhenChecked (myFolderRadio, myFolderButton);
@ -381,7 +381,7 @@ MakeDialog::MakeDialog (Session& session, QWidget * parent):
myFileButton->setIcon (filePixmap);
myFileButton->setStyleSheet (QString::fromUtf8 ("text-align: left; padding-left: 5; padding-right: 5"));
connect (myFileButton, SIGNAL(clicked(bool)),
this, SLOT(onFileClicked(void)));
this, SLOT(onFileClicked()));
hig->addRow (myFileRadio, myFileButton);
enableBuddyWhenChecked (myFileRadio, myFileButton);

16
qt/prefs-dialog.cc
View File

@ -476,7 +476,7 @@ PrefsDialog::createPrivacyTab ()
***/
void
PrefsDialog::onScriptClicked (void)
PrefsDialog::onScriptClicked ()
{
const QString title = tr ("Select \"Torrent Done\" Script");
const QString myPath = myPrefs.getString (Prefs::SCRIPT_TORRENT_DONE_FILENAME);
@ -487,7 +487,7 @@ PrefsDialog::onScriptClicked (void)
}
void
PrefsDialog::onIncompleteClicked (void)
PrefsDialog::onIncompleteClicked ()
{
const QString title = tr ("Select Incomplete Directory");
const QString myPath = myPrefs.getString (Prefs::INCOMPLETE_DIR);
@ -498,7 +498,7 @@ PrefsDialog::onIncompleteClicked (void)
}
void
PrefsDialog::onWatchClicked (void)
PrefsDialog::onWatchClicked ()
{
const QString title = tr ("Select Watch Directory");
const QString myPath = myPrefs.getString (Prefs::DIR_WATCH);
@ -509,7 +509,7 @@ PrefsDialog::onWatchClicked (void)
}
void
PrefsDialog::onDestinationClicked (void)
PrefsDialog::onDestinationClicked ()
{
const QString title = tr ("Select Destination");
const QString myPath = myPrefs.getString (Prefs::DOWNLOAD_DIR);
@ -572,7 +572,7 @@ PrefsDialog::createDownloadingTab ()
b = myWatchButton = new QPushButton;
b->setIcon (folderPixmap);
b->setStyleSheet (QString::fromUtf8 ("text-align: left; padding-left: 5; padding-right: 5"));
connect (b, SIGNAL(clicked(bool)), this, SLOT(onWatchClicked(void)));
connect (b, SIGNAL(clicked(bool)), this, SLOT(onWatchClicked()));
hig->addRow (l, b);
enableBuddyWhenChecked (qobject_cast<QCheckBox*>(l), b);
@ -585,7 +585,7 @@ PrefsDialog::createDownloadingTab ()
b = myDestinationButton = new QPushButton;
b->setIcon (folderPixmap);
b->setStyleSheet (QString::fromUtf8 ("text-align: left; padding-left: 5; padding-right: 5"));
connect (b, SIGNAL(clicked(bool)), this, SLOT(onDestinationClicked(void)));
connect (b, SIGNAL(clicked(bool)), this, SLOT(onDestinationClicked()));
hig->addRow (tr ("Save to &Location:"), b);
const QString downloadDir (myPrefs.getString(Prefs::DOWNLOAD_DIR));
@ -610,7 +610,7 @@ PrefsDialog::createDownloadingTab ()
b = myIncompleteButton = new QPushButton;
b->setIcon (folderPixmap);
b->setStyleSheet (QString::fromUtf8 ("text-align: left; padding-left: 5; padding-right: 5"));
connect (b, SIGNAL(clicked(bool)), this, SLOT(onIncompleteClicked(void)));
connect (b, SIGNAL(clicked(bool)), this, SLOT(onIncompleteClicked()));
hig->addRow (myIncompleteCheckbox, b);
enableBuddyWhenChecked (qobject_cast<QCheckBox*>(l), b);
@ -618,7 +618,7 @@ PrefsDialog::createDownloadingTab ()
b = myTorrentDoneScriptButton = new QPushButton;
b->setIcon (filePixmap);
b->setStyleSheet (QString::fromUtf8 ("text-align: left; padding-left: 5; padding-right: 5"));
connect (b, SIGNAL(clicked(bool)), this, SLOT(onScriptClicked(void)));
connect (b, SIGNAL(clicked(bool)), this, SLOT(onScriptClicked()));
hig->addRow (myTorrentDoneScriptCheckbox, b);
enableBuddyWhenChecked (qobject_cast<QCheckBox*>(l), b);