From 765ed4a0d2c9a4174714a40949a922d9522ed9be Mon Sep 17 00:00:00 2001 From: Jordan Lee Date: Fri, 28 Dec 2012 23:46:34 +0000 Subject: [PATCH] (trunk, libT) #5201 'tr_variantDict can be much faster' -- don't test to see if each dictionary value that's a string is a quark... it almost never is, so the lookup isn't worth it. --- libtransmission/variant.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/libtransmission/variant.c b/libtransmission/variant.c index 3b7d34039..b7e58d507 100644 --- a/libtransmission/variant.c +++ b/libtransmission/variant.c @@ -117,7 +117,6 @@ tr_variant_string_set_string (struct tr_variant_string * str, const char * bytes, int len) { - tr_quark quark; tr_variant_string_clear (str); if (bytes == NULL) @@ -125,13 +124,7 @@ tr_variant_string_set_string (struct tr_variant_string * str, else if (len < 0) len = strlen (bytes); - if (tr_quark_lookup (bytes, len, &quark)) - { - str->type = TR_STRING_TYPE_QUARK; - str->quark = quark; - str->str.str = tr_quark_get_string (quark, &str->len); - } - else if ((size_t)len < sizeof(str->str.buf)) + if ((size_t)len < sizeof(str->str.buf)) { str->type = TR_STRING_TYPE_BUF; memcpy (str->str.buf, bytes, len);