more logging to try to smoke out #3041

libtransmission/blocklist.c

@@ -10,7 +10,6 @@
  * $Id$
  */
 
-#include <ctype.h> /* isprint() */
 #include <stdio.h>
 #include <stdlib.h> /* free() */
 #include <string.h>
@@ -285,6 +284,7 @@ _tr_blocklistSetContent( tr_blocklist * b,
         if( !tr_pton( rangeBegin, &addr ) )
         {
             printf( "error rangeBegin: %s", line );
+            /* don't try to display the actual lines - it causes issues */
             tr_err( _( "blocklist skipped invalid address at line %d" ), inCount );
             free( line );
             continue;
@@ -294,6 +294,7 @@ _tr_blocklistSetContent( tr_blocklist * b,
         if( !tr_pton( rangeEnd, &addr ) )
         {
             printf( "error rangeEnd: %s", line );
+            /* don't try to display the actual lines - it causes issues */
             tr_err( _( "blocklist skipped invalid address at line %d" ), inCount );
             free( line );
             continue;

macosx/BlocklistDownloader.m

@@ -118,6 +118,10 @@ BlocklistDownloader * fDownloader = nil;
 
 - (void) download: (NSURLDownload *) download didFailWithError: (NSError *) error
 {
+    #warning remove
+    NSLog(@"%@", [error localizedDescription]);
+    NSLog(@"%@", [error localizedFailureReason]);
+    NSLog(@"%@", [error localizedRecoverySuggestion]);
     [fViewController setFailed: [error localizedDescription]];
     
     [[BlocklistScheduler scheduler] updateSchedule];
@@ -145,7 +149,7 @@ BlocklistDownloader * fDownloader = nil;
     NSURLRequest * request = [NSURLRequest requestWithURL: [NSURL URLWithString: LIST_URL]];
     
     fDownload = [[NSURLDownload alloc] initWithRequest: request delegate: self];
-    [fDownload setDestination: [NSTemporaryDirectory() stringByAppendingPathComponent: FILE_NAME] allowOverwrite: NO];
+    [fDownload setDestination: [NSTemporaryDirectory() stringByAppendingPathComponent: FILE_NAME] allowOverwrite: YES];
 }
 
 - (void) finishDownloadSuccess

macosx/BlocklistDownloaderViewController.m

@@ -115,8 +115,7 @@
     [alert setMessageText: NSLocalizedString(@"Download of the blocklist failed.", "Blocklist -> message")];
     [alert setAlertStyle: NSWarningAlertStyle];
     
-    [alert setInformativeText: [NSString stringWithFormat: @"%@ - %@", NSLocalizedString(@"Error", "Blocklist -> message"),
-        error]];
+    [alert setInformativeText: error];
     
     [alert beginSheetModalForWindow: [fPrefsController window] modalDelegate: self
         didEndSelector: @selector(failureSheetClosed:returnCode:contextInfo:) contextInfo: nil];