#6006: Don't use newlocale/uselocale with uClibc below 0.9.34

Incomplete locale internals initialization in uClibc leads to crash upon
`newlocale` call.

See also: http://git.uclibc.org/uClibc/commit/?id=3902d0c472

libtransmission/file-posix.c

@@ -67,17 +67,10 @@
 
 /* don't use pread/pwrite on old versions of uClibc because they're buggy.
  * https://trac.transmissionbt.com/ticket/3826 */
-#ifdef __UCLIBC__
-#define TR_UCLIBC_CHECK_VERSION(major,minor,micro) \
-  (__UCLIBC_MAJOR__ > (major) || \
-   (__UCLIBC_MAJOR__ == (major) && __UCLIBC_MINOR__ > (minor)) || \
-   (__UCLIBC_MAJOR__ == (major) && __UCLIBC_MINOR__ == (minor) && \
-      __UCLIBC_SUBLEVEL__ >= (micro)))
-#if !TR_UCLIBC_CHECK_VERSION (0,9,28)
+#if defined (__UCLIBC__) && !TR_UCLIBC_CHECK_VERSION (0, 9, 28)
  #undef HAVE_PREAD
  #undef HAVE_PWRITE
 #endif
-#endif
 
 #ifdef __APPLE__
  #ifndef HAVE_PREAD

libtransmission/utils.h

@@ -82,6 +82,16 @@ struct tr_error;
  #define __has_extension __has_feature
 #endif
 
+#ifdef __UCLIBC__
+ #define TR_UCLIBC_CHECK_VERSION(major, minor, micro) \
+   (__UCLIBC_MAJOR__ > (major) || \
+    (__UCLIBC_MAJOR__ == (major) && __UCLIBC_MINOR__ > (minor)) || \
+    (__UCLIBC_MAJOR__ == (major) && __UCLIBC_MINOR__ == (minor) && \
+       __UCLIBC_SUBLEVEL__ >= (micro)))
+#else
+ #define TR_UCLIBC_CHECK_VERSION(major, minor, micro) 0
+#endif
+
 /**
  * @def TR_STATIC_ASSERT
  * @brief This helper allows to perform static checks at compile time

libtransmission/variant.c

@@ -43,6 +43,12 @@
 #include "variant.h"
 #include "variant-common.h"
 
+/* don't use newlocale/uselocale on old versions of uClibc because they're buggy.
+ * https://trac.transmissionbt.com/ticket/6006 */
+#if defined (__UCLIBC__) && !TR_UCLIBC_CHECK_VERSION (0, 9, 34)
+ #undef HAVE_USELOCALE
+#endif
+
 /**
 ***
 **/