mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-01-31 03:12:44 +00:00
Code Issues Releases Wiki Activity

refactor: faster action sensitivity updates (#1333)

Browse source 
* refactor: faster action sensitivity updates

Currently we walk through every row in the model and pump its TorrentRole data, which can be expensive for long lists. However since we're only interested in the selected rows, let's save some traversal overhead by getting that list directly and walking it instead.
This commit is contained in:
Charles Kerr 2020-06-23 12:16:07 -05:00 committed by GitHub
parent 8fcfc1e4ae
commit 83e4e4ca55
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 37 additions and 48 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
qt/MainWindow.cc
View file

@ -8,6 +8,7 @@
#include <array> #include <array>
#include <cassert> #include <cassert>
#include <functional>
#include <utility> #include <utility>
#include <QCheckBox> #include <QCheckBox>
@ -849,39 +850,24 @@ void MainWindow::refreshTorrentViewHeader()
void MainWindow::refreshActionSensitivity() void MainWindow::refreshActionSensitivity()
{ {
int paused(0); auto const* model = ui_.listView->model();
int selected(0); auto const* selection_model = ui_.listView->selectionModel();
int selected_and_can_announce(0); auto const row_count = model->rowCount();
int selected_and_paused(0);
int selected_and_queued(0);
int selected_with_metadata(0);
QAbstractItemModel const* model(ui_.listView->model());
QItemSelectionModel const* selection_model(ui_.listView->selectionModel());
bool const has_selection = selection_model->hasSelection();
int const row_count(model->rowCount());
// count how many torrents are selected, paused, etc // count how many torrents are selected, paused, etc
auto selected = int{};
auto selected_and_can_announce = int{};
auto selected_and_paused = int{};
auto selected_and_queued = int{};
auto selected_with_metadata = int{};
auto const now = time(nullptr); auto const now = time(nullptr);
for (int row = 0; row < row_count; ++row) for (auto const& row : selection_model->selectedRows())
{ {
QModelIndex const model_index(model->index(row, 0)); auto const& tor = model->data(row, TorrentModel::TorrentRole).value<Torrent const*>();
auto const& tor = model->data(model_index, TorrentModel::TorrentRole).value<Torrent const*>();
if (tor != nullptr)
{
bool const is_selected = has_selection && selection_model->isSelected(model_index);
bool const is_paused = tor->isPaused();
if (is_paused)
{
++paused;
}
if (is_selected)
{
++selected; ++selected;
if (is_paused) if (tor->isPaused())
{ {
++selected_and_paused; ++selected_and_paused;
} }
@ -901,12 +887,15 @@ void MainWindow::refreshActionSensitivity()
++selected_and_can_announce; ++selected_and_can_announce;
} }
} }
}
}
bool const have_selection(selected > 0); auto const& torrents = model_.torrents();
bool const have_selection_with_metadata = selected_with_metadata > 0; auto const is_paused = [](auto const* tor) { return tor->isPaused(); };
bool const one_selection(selected == 1); auto const any_paused = std::any_of(std::begin(torrents), std::end(torrents), is_paused);
auto const any_not_paused = std::any_of(std::begin(torrents), std::end(torrents), std::not_fn(is_paused));
auto const have_selection = selected > 0;
auto const have_selection_with_metadata = selected_with_metadata > 0;
auto const one_selection = selected == 1;
ui_.action_Verify->setEnabled(have_selection_with_metadata); ui_.action_Verify->setEnabled(have_selection_with_metadata);
ui_.action_Remove->setEnabled(have_selection); ui_.action_Remove->setEnabled(have_selection);
@ -919,8 +908,8 @@ void MainWindow::refreshActionSensitivity()
ui_.action_CopyMagnetToClipboard->setEnabled(one_selection); ui_.action_CopyMagnetToClipboard->setEnabled(one_selection);
ui_.action_SelectAll->setEnabled(selected < row_count); ui_.action_SelectAll->setEnabled(selected < row_count);
ui_.action_StartAll->setEnabled(paused > 0); ui_.action_StartAll->setEnabled(any_paused);
ui_.action_PauseAll->setEnabled(paused < row_count); ui_.action_PauseAll->setEnabled(any_not_paused);
ui_.action_Start->setEnabled(selected_and_paused > 0); ui_.action_Start->setEnabled(selected_and_paused > 0);
ui_.action_StartNow->setEnabled(selected_and_paused + selected_and_queued > 0); ui_.action_StartNow->setEnabled(selected_and_paused + selected_and_queued > 0);
ui_.action_Pause->setEnabled(selected_and_paused < selected); ui_.action_Pause->setEnabled(selected_and_paused < selected);