mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2024-12-23 16:24:02 +00:00
Code Issues Releases Wiki Activity

(gtk) avoid a tr_torrentStat() call when filtering by all, downloading, seeding, or paused

Browse source
This commit is contained in:
Charles Kerr 2008-04-01 11:53:50 +00:00
parent 7328a68b4f
commit 85c57c00cb
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
gtk/tr-window.c
View file

@ -301,26 +301,26 @@ checkFilterText( filter_text_mode_t filter_text_mode,
static int static int
checkFilterMode( filter_mode_t filter_mode, checkFilterMode( filter_mode_t filter_mode,
const tr_stat * torStat ) tr_torrent * tor )
{ {
int ret = 0; int ret = 0;
const int haveDown = torStat->peersSendingToUs > 0;
const int haveUp = torStat->peersGettingFromUs > 0;
switch( filter_mode ) switch( filter_mode )
{ {
case FILTER_MODE_ACTIVE:
ret = haveUp || haveDown;
break;
case FILTER_MODE_DOWNLOADING: case FILTER_MODE_DOWNLOADING:
ret = torStat->status == TR_STATUS_DOWNLOAD; ret = tr_torrentGetStatus( tor ) == TR_STATUS_DOWNLOAD;
break; break;
case FILTER_MODE_SEEDING: case FILTER_MODE_SEEDING:
ret = torStat->status == TR_STATUS_SEED; ret = tr_torrentGetStatus( tor ) == TR_STATUS_SEED;
break; break;
case FILTER_MODE_PAUSED: case FILTER_MODE_PAUSED:
ret = torStat->status == TR_STATUS_STOPPED; ret = tr_torrentGetStatus( tor ) == TR_STATUS_STOPPED;
break; break;
case FILTER_MODE_ACTIVE: {
const tr_stat * s = tr_torrentStatCached( tor );
ret = s->peersSendingToUs>0 || s->peersGettingFromUs>0;
break;
}
default: /* all */ default: /* all */
ret = 1; ret = 1;
} }
@ -337,7 +337,7 @@ is_row_visible( GtkTreeModel * model,
tr_torrent * tor; tr_torrent * tor;
gtk_tree_model_get( model, iter, MC_TORRENT_RAW, &tor, -1 ); gtk_tree_model_get( model, iter, MC_TORRENT_RAW, &tor, -1 );
return checkFilterMode( p->filter_mode, tr_torrentStatCached( tor ) ) return checkFilterMode( p->filter_mode, tor )
&& checkFilterText( p->filter_text_mode, tr_torrentInfo( tor ), p->filter_text ); && checkFilterText( p->filter_text_mode, tr_torrentInfo( tor ), p->filter_text );
} }