mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-03-12 15:14:12 +00:00
Code Issues Releases Wiki Activity

#7290: Resolve group rows rendering incorrectly (#7321)

Browse source 
The outline view was apply its own styling. Instead, don't mark our groups as groups.
This commit is contained in:
Mitch Livingston 2024-12-22 13:10:24 -05:00 • committed by GitHub
parent 59c1c1e83b
commit 8a308cf9d9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
macosx/TorrentTableView.mm
View file

@ -123,8 +123,8 @@ static NSTimeInterval const kToggleProgressSeconds = 0.175;
NSMutableIndexSet* visibleIndexSet = [[NSMutableIndexSet alloc] init];
[fullIndexSet enumerateIndexesUsingBlock:^(NSUInteger row, BOOL*) {
id rowView = [self rowViewAtRow:row makeIfNecessary:NO];
if ([rowView isGroupRowStyle])
id rowItem = [self itemAtRow:row];
if ([rowItem isKindOfClass:[TorrentGroup class]])
{
[visibleIndexSet addIndex:row];
}
@ -149,8 +149,8 @@ static NSTimeInterval const kToggleProgressSeconds = 0.175;
//redraw fControlButton
BOOL minimal = [self.fDefaults boolForKey:@"SmallView"];
[rowIndexes enumerateIndexesUsingBlock:^(NSUInteger row, BOOL*) {
id rowView = [self rowViewAtRow:row makeIfNecessary:NO];
if (![rowView isGroupRowStyle])
id rowItem = [self itemAtRow:row];
if (![rowItem isKindOfClass:[TorrentGroup class]])
{
if (minimal)
{
@ -199,11 +199,9 @@ static NSTimeInterval const kToggleProgressSeconds = 0.175;
- (BOOL)outlineView:(NSOutlineView*)outlineView isGroupItem:(id)item
{
if ([item isKindOfClass:[Torrent class]])
{
return NO;
}
return YES;
// We are implementing our own group styling.
// Apple's default group styling conflicts with this.
return NO;
}
- (CGFloat)outlineView:(NSOutlineView*)outlineView heightOfRowByItem:(id)item