mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2024-12-25 01:03:01 +00:00
Code Issues Releases Wiki Activity

feat: add tr_bitfield::intersects() (#5155)

Browse source
This commit is contained in:
Charles Kerr 2023-04-14 18:45:46 -05:00 committed by GitHub
parent ed4919a4f4
commit 9158ae7126
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 84 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
libtransmission/bitfield.cc
View file

@ -485,3 +485,26 @@ tr_bitfield& tr_bitfield::operator&=(tr_bitfield const& that) noexcept
rebuildTrueCount();
return *this;
}
bool tr_bitfield::intersects(tr_bitfield const& that) const noexcept
{
if (hasNone() || that.hasNone())
{
return false;
}
if (hasAll() || that.hasAll())
{
return true;
}
for (size_t i = 0, n = std::min(std::size(flags_), std::size(that.flags_)); i < n; ++i)
{
if ((flags_[i] & that.flags_[i]) != 0U)
{
return true;
}
}
return false;
}

1
libtransmission/bitfield.h
View file

@ -114,6 +114,7 @@ public:
tr_bitfield& operator|=(tr_bitfield const& that) noexcept;
tr_bitfield& operator&=(tr_bitfield const& that) noexcept;
[[nodiscard]] bool intersects(tr_bitfield const& that) const noexcept;
private:
[[nodiscard]] size_t countFlags() const noexcept;

60
tests/libtransmission/bitfield-test.cc
View file

@ -445,3 +445,63 @@ TEST(Bitfield, bitwiseAnd)
b &= a;
EXPECT_NEAR(0.1F, a.percent(), 0.01);
}
TEST(Bitfield, intersects)
{
auto a = tr_bitfield{ 100 };
auto b = tr_bitfield{ 100 };
a.setHasAll();
b.setHasNone();
EXPECT_FALSE(a.intersects(b));
EXPECT_FALSE(b.intersects(a));
a.setHasAll();
b.setHasAll();
EXPECT_TRUE(a.intersects(b));
EXPECT_TRUE(b.intersects(a));
a.setHasNone();
b.setHasNone();
EXPECT_FALSE(a.intersects(b));
EXPECT_FALSE(b.intersects(a));
a.setHasNone();
b.setHasNone();
a.setSpan(0, std::size(a) / 2U);
b.setSpan(std::size(a) / 2U, std::size(a));
EXPECT_EQ(0.5, a.percent());
EXPECT_EQ(0.5, b.percent());
EXPECT_FALSE(a.intersects(b));
EXPECT_FALSE(b.intersects(a));
a.setHasNone();
b.setHasNone();
for (size_t i = 0; i < std::size(a); ++i)
{
if ((i % 2U) != 0U)
{
a.set(i);
}
else
{
b.set(i);
}
}
EXPECT_FALSE(a.intersects(b));
EXPECT_FALSE(b.intersects(a));
a.setHasNone();
a.setSpan(0U, std::size(a) / 10U);
b.setHasNone();
b.setSpan(0U, std::size(a) / 20U);
EXPECT_TRUE(a.intersects(b));
EXPECT_TRUE(b.intersects(a));
a.setHasNone();
a.setSpan(0U, std::size(a) / 10U);
b.setHasNone();
b.setSpan(0U, std::size(a) / 20U);
EXPECT_TRUE(a.intersects(b));
EXPECT_TRUE(b.intersects(a));
}