only remove a torrent from the queue for a local error, not tracker error; miscellaneous trivial adjustments

macosx/BlocklistDownloaderViewController.m

@@ -47,7 +47,7 @@
 {
     [fButton setTitle: NSLocalizedString(@"Cancel", "Blocklist -> cancel button")];
     
-    CGFloat oldWidth = [fButton frame].size.width;
+    const CGFloat oldWidth = [fButton frame].size.width;
     [fButton sizeToFit];
     NSRect buttonFrame = [fButton frame];
     buttonFrame.size.width += 12.0f; //sizeToFit sizes a bit too small

macosx/Controller.m

@@ -893,7 +893,7 @@ static void sleepCallback(void * controller, io_service_t y, natural_t messageTy
         //ensure torrent doesn't already exist
         tr_ctor * ctor = tr_ctorNew(fLib);
         tr_ctorSetMetainfoFromFile(ctor, [torrentPath UTF8String]);
-        int result = tr_torrentParse(ctor, &info);
+        tr_parse_result result = tr_torrentParse(ctor, &info);
         if (result != TR_PARSE_OK)
         {
             if (result == TR_PARSE_DUPLICATE)
@@ -903,8 +903,8 @@ static void sleepCallback(void * controller, io_service_t y, natural_t messageTy
                 if (type != ADD_AUTO)
                     [self invalidOpenAlert: [torrentPath lastPathComponent]];
             }
-            else //this shouldn't happen
+            else
-                NSLog(@"Unknown error code (%d) when attempting to open \"%@\"", result, torrentPath);
+                NSAssert2(NO, @"Unknown error code (%d) when attempting to open \"%@\"", result, torrentPath);
             
             tr_ctorFree(ctor);
             tr_metainfoFree(&info);
@@ -3983,7 +3983,7 @@ static void sleepCallback(void * controller, io_service_t y, natural_t messageTy
     if (seeding > 0 || downloading > 0)
     {
         if (!hasSeparator)
-            [fDockMenu insertItem: [NSMenuItem separatorItem] atIndex: seeding > 0 && downloading > 0 ? 2 : 1];
+            [fDockMenu insertItem: [NSMenuItem separatorItem] atIndex: (seeding > 0 && downloading > 0) ? 2 : 1];
     }
     else
     {

macosx/StatsWindowController.m

@@ -72,7 +72,7 @@ tr_session * fLib;
                                             stringByAppendingString: @":"]];
     
     //size all elements
-    CGFloat oldWidth = [fUploadedLabelField frame].size.width;
+    const CGFloat oldWidth = [fUploadedLabelField frame].size.width;
     
     [fUploadedLabelField sizeToFit];
     [fDownloadedLabelField sizeToFit];
@@ -111,7 +111,7 @@ tr_session * fLib;
     [[self window] setFrame: windowRect display: YES];
     
     //resize reset button
-    CGFloat oldButtonWidth = [fResetButton frame].size.width;
+    const CGFloat oldButtonWidth = [fResetButton frame].size.width;
     
     [fResetButton setTitle: NSLocalizedString(@"Reset", "Stats window -> reset button")];
     [fResetButton sizeToFit];

macosx/Torrent.h

@@ -161,7 +161,7 @@
 - (BOOL) allDownloaded;
 - (BOOL) isComplete;
 - (BOOL) isError;
-- (BOOL) isErrorOrWarning;
+- (BOOL) isAnyErrorOrWarning;
 - (NSString *) errorMessage;
 
 - (NSArray *) peers;

macosx/Torrent.m

@@ -851,17 +851,17 @@ int trashDataFile(const char * filename)
 
 - (BOOL) isError
 {
-    return fStat->error == TR_STAT_LOCAL_ERROR || fStat->error == TR_STAT_TRACKER_ERROR;
+    return fStat->error == TR_STAT_LOCAL_ERROR;
 }
 
-- (BOOL) isErrorOrWarning
+- (BOOL) isAnyErrorOrWarning
 {
     return fStat->error != TR_STAT_OK;
 }
 
 - (NSString *) errorMessage
 {
-    if (![self isErrorOrWarning])
+    if (![self isAnyErrorOrWarning])
         return @"";
     
     NSString * error;
@@ -994,7 +994,7 @@ int trashDataFile(const char * filename)
 {
     NSString * string;
     
-    if ([self isErrorOrWarning])
+    if ([self isAnyErrorOrWarning])
     {
         switch (fStat->error)
         {

macosx/TorrentCell.m

@@ -429,7 +429,7 @@
         [gradient release];
     }
     
-    const BOOL error = [torrent isErrorOrWarning];
+    const BOOL error = [torrent isAnyErrorOrWarning];
     
     //icon
     if (!minimal || !(!fTracking && fHoverAction)) //don't show in minimal mode when hovered over

macosx/TorrentTableView.m

@@ -139,7 +139,7 @@
 
 - (NSCell *) outlineView: (NSOutlineView *) outlineView dataCellForTableColumn: (NSTableColumn *) tableColumn item: (id) item
 {
-    BOOL group = ![item isKindOfClass: [Torrent class]];
+    const BOOL group = ![item isKindOfClass: [Torrent class]];
     if (!tableColumn)
         return !group ? fTorrentCell : nil;
     else