mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-02-01 12:08:24 +00:00
Code Issues Releases Wiki Activity

fix: a couple of logging format issues (#6463)

Browse source 
* Fix swapped log args in `do_log_system_error()`

* Fix invalid fmt use in `tr_rpc_server::load()` logging
This commit is contained in:
Mike Gelfand 2023-12-30 14:56:34 +00:00 committed by GitHub
parent 7573a98bb4
commit 9c4d28dd08
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
daemon/daemon-win32.cc
View file

@ -43,7 +43,7 @@ static void set_system_error(tr_error& error, DWORD code, char const* message)
static void do_log_system_error(char const* file, int line, tr_log_level level, DWORD code, char const* message)
{
auto const system_message = tr_win32_format_message(code);
tr_logAddMessage(file, line, level, "tr_daemon", fmt::format("[tr_daemon] {} ({:#x}): {}", message, code, system_message));
tr_logAddMessage(file, line, level, fmt::format("{} ({:#x}): {}", message, code, system_message), "tr_daemon");
}
#define log_system_error(level, code, message) \

4
libtransmission/rpc-server.cc
View file

@ -881,8 +881,8 @@ void tr_rpc_server::load(tr_variant const& src)
// NOTE: bind_address_ is default initialized to INADDR_ANY
tr_logAddWarn(fmt::format(
_("The '{key}' setting is '{value}' but must be an IPv4 or IPv6 address or a Unix socket path. Using default value '0.0.0.0'"),
fmt::format("key", tr_quark_get_string_view(TR_KEY_rpc_bind_address)),
fmt::format("value", bind_address_str_)));
fmt::arg("key", tr_quark_get_string_view(TR_KEY_rpc_bind_address)),
fmt::arg("value", bind_address_str_)));
}
if (bind_address_->is_unix_addr())