From 9c886b5d3e67e18d4fa64a5e2994711d190e4d89 Mon Sep 17 00:00:00 2001 From: Mitchell Livingston Date: Thu, 17 Sep 2009 04:52:17 +0000 Subject: [PATCH] remove unnecessary alloca --- macosx/PiecesView.m | 1 + macosx/TorrentTableView.m | 3 ++- macosx/TrackerTableView.m | 3 ++- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/macosx/PiecesView.m b/macosx/PiecesView.m index 286be08c6..f1c397af1 100644 --- a/macosx/PiecesView.m +++ b/macosx/PiecesView.m @@ -201,6 +201,7 @@ rect.origin = NSMakePoint(j * (fWidth + BETWEEN) + BETWEEN + fExtraBorder, [image size].width - (i + 1) * (fWidth + BETWEEN) - fExtraBorder); + #warning use NSRectFillListWithColors [pieceColor set]; NSRectFill(rect); } diff --git a/macosx/TorrentTableView.m b/macosx/TorrentTableView.m index c44097a5e..a3fcf208d 100644 --- a/macosx/TorrentTableView.m +++ b/macosx/TorrentTableView.m @@ -682,7 +682,7 @@ const CGFloat totalRowHeight = [self rowHeight] + [self intercellSpacing].height; - NSRect * gridRects = (NSRect *)alloca(sizeof(NSRect) * (ceil(visibleRect.size.height / totalRowHeight) / 2)); + NSRect gridRects[(NSInteger)(ceil(visibleRect.size.height / totalRowHeight) / 2)]; NSInteger rectNum = 0; if (rows.length > 0) @@ -729,6 +729,7 @@ visibleRect.size.height = totalRowHeight; if (start) visibleRect.origin.y += totalRowHeight; + for (NSInteger i = start ? 1 : 0; i < numberBlankRows; i += 2) { gridRects[rectNum++] = visibleRect; diff --git a/macosx/TrackerTableView.m b/macosx/TrackerTableView.m index 9c625adeb..704ae9b85 100644 --- a/macosx/TrackerTableView.m +++ b/macosx/TrackerTableView.m @@ -46,7 +46,7 @@ const CGFloat totalRowHeight = [self rowHeight] + [self intercellSpacing].height; - NSRect * gridRects = (NSRect *)alloca(sizeof(NSRect) * (ceil(visibleRect.size.height / totalRowHeight) / 2)); + NSRect gridRects[(NSInteger)(ceil(visibleRect.size.height / totalRowHeight) / 2)]; NSInteger rectNum = 0; if (rows.length > 0) @@ -93,6 +93,7 @@ visibleRect.size.height = totalRowHeight; if (start) visibleRect.origin.y += totalRowHeight; + for (NSInteger i = start ? 1 : 0; i < numberBlankRows; i += 2) { gridRects[rectNum++] = visibleRect;