mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity

small optimization in obtaining error image

This commit is contained in:
Mitchell Livingston 2007-08-08 16:14:52 +00:00
parent 076af9872b
commit a84f0cd9e6
1 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
macosx/TorrentCell.m
View File

@ -40,7 +40,7 @@
@implementation TorrentCell @implementation TorrentCell
#warning release? //only called one, so don't worry about release
- (id) init - (id) init
{ {
if ((self = [super init])) if ((self = [super init]))
@ -58,9 +58,6 @@
fYellowGradient = [[CTGradient progressYellowGradient] retain]; fYellowGradient = [[CTGradient progressYellowGradient] retain];
fTransparentGradient = [[CTGradient progressTransparentGradient] retain]; fTransparentGradient = [[CTGradient progressTransparentGradient] retain];
fErrorImage = [[NSImage imageNamed: @"Error.png"] copy];
[fErrorImage setFlipped: YES];
NSMutableParagraphStyle * paragraphStyle = [[NSParagraphStyle defaultParagraphStyle] mutableCopy]; NSMutableParagraphStyle * paragraphStyle = [[NSParagraphStyle defaultParagraphStyle] mutableCopy];
[paragraphStyle setLineBreakMode: NSLineBreakByTruncatingTail]; [paragraphStyle setLineBreakMode: NSLineBreakByTruncatingTail];
@ -207,6 +204,12 @@
//error badge //error badge
if ([[info objectForKey: @"Error"] boolValue]) if ([[info objectForKey: @"Error"] boolValue])
{ {
if (!fErrorImage)
{
fErrorImage = [[NSImage imageNamed: @"Error.png"] copy];
[fErrorImage setFlipped: YES];
}
NSSize errorIconSize = [fErrorImage size]; NSSize errorIconSize = [fErrorImage size];
[fErrorImage drawAtPoint: NSMakePoint(pen.x + iconSize.width - errorIconSize.width, [fErrorImage drawAtPoint: NSMakePoint(pen.x + iconSize.width - errorIconSize.width,
pen.y + iconSize.height - errorIconSize.height) pen.y + iconSize.height - errorIconSize.height)
@ -253,7 +256,18 @@
else //small size else //small size
{ {
//icon //icon
NSImage * icon = ![[info objectForKey: @"Error"] boolValue] ? [info objectForKey: @"Icon"] : fErrorImage; NSImage * icon;
if ([[info objectForKey: @"Error"] boolValue])
{
if (!fErrorImage)
{
fErrorImage = [[NSImage imageNamed: @"Error.png"] copy];
[fErrorImage setFlipped: YES];
}
icon = fErrorImage;
}
else
icon = [info objectForKey: @"Icon"];
NSSize iconSize = [icon size]; NSSize iconSize = [icon size];
pen.x += PADDING; pen.x += PADDING;