mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-01-31 19:34:05 +00:00
Code Issues Releases Wiki Activity

build: add clang-tidy check modernize-pass-by-value (#1946)

Browse source
This commit is contained in:
Charles Kerr 2021-10-13 19:14:27 -05:00 committed by GitHub
parent 65a3a7d042
commit af2af2a57e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libtransmission/.clang-tidy
View file

@ -2,6 +2,8 @@
# Many of these checks are disabled only because the code hasn't been
# cleaned up yet. Pull requests welcomed.
Checks: >
modernize-pass-by-value,
modernize-use-default-member-init,
modernize-use-nullptr,
modernize-use-override

6
libtransmission/announcer-udp.cc
View file

@ -459,10 +459,10 @@ struct tau_tracker
tr_ptrArray announces = {};
tr_ptrArray scrapes = {};
tau_tracker(tr_session* session_in, std::string const& key_in, std::string const& host_in, int port_in)
tau_tracker(tr_session* session_in, std::string key_in, std::string host_in, int port_in)
: session{ session_in }
, key{ key_in }
, host{ host_in }
, key{ std::move(key_in) }
, host{ std::move(host_in) }
, port{ port_in }
{
}

4
libtransmission/announcer.cc
View file

@ -135,8 +135,8 @@ struct tr_scrape_info
int multiscrape_max;
tr_scrape_info(std::string const& url_in, int const multiscrape_max_in)
: url{ url_in }
tr_scrape_info(std::string url_in, int const multiscrape_max_in)
: url{ std::move(url_in) }
, multiscrape_max{ multiscrape_max_in }
{
}

2
libtransmission/peer-msgs.cc
View file

@ -199,10 +199,8 @@ public:
tr_peerMsgsImpl(tr_torrent* torrent_in, peer_atom* atom_in, tr_peerIo* io_in, tr_peer_callback callback, void* callbackData)
: tr_peerMsgs{ torrent_in, atom_in }
, outMessagesBatchPeriod{ LOW_PRIORITY_INTERVAL_SECS }
, state{ AWAITING_BT_LENGTH }
, torrent{ torrent_in }
, outMessages{ evbuffer_new() }
, outMessagesBatchedAt{ 0 }
, io{ io_in }
, callback_{ callback }
, callbackData_{ callbackData }