build: minor ci cleanup (#4652)

* chore: show js webpack stats when building

* chore: use npm ci for code_style to avoid overwriting package-lock.json

* chore: add brew-update to macos ci

* remove webpack-dev-server from deps

.github/workflows/actions.yml

@@ -185,6 +185,7 @@ jobs:
           echo '${{ toJSON(runner) }}'
           sw_vers
       - name: Get Dependencies
+        run: brew update
         run: brew install cmake gettext libdeflate libevent libnatpmp libpsl miniupnpc ninja node
       - name: Get Dependencies (GTK)
         if: ${{ needs.what-to-make.outputs.make-gtk == 'true' }}
@@ -458,6 +459,7 @@ jobs:
           echo '${{ toJSON(runner) }}'
           sw_vers
       - name: Get Dependencies
+        run: brew update
         run: brew install cmake gettext libdeflate libevent libnatpmp libpsl miniupnpc ninja node
       - name: Get Dependencies (GTK)
         if: ${{ needs.what-to-make.outputs.make-gtk == 'true' }}

code_style.sh

@@ -78,8 +78,8 @@ fi
 # format JS
 cd "${root}/web" || exit 1
 npm_lint_args="$([ -n "$fix" ] && echo 'lint:fix' || echo 'lint')"
-if ! npm install --no-audit --no-fund --no-progress &>/dev/null; then
-  [ -n "$fix" ] || echo 'JS code could not be checked -- "npm install" failed'
+if ! npm ci --no-audit --no-fund --no-progress &>/dev/null; then
+  [ -n "$fix" ] || echo 'JS code could not be checked -- "npm ci" failed'
   exitcode=1
 elif ! npm run --silent $npm_lint_args; then
   [ -n "$fix" ] || echo 'JS code needs formatting'

web/CMakeLists.txt

@@ -73,7 +73,7 @@ add_custom_command(
     COMMAND "${CMAKE_COMMAND}" -E copy_directory
         "${CMAKE_CURRENT_SOURCE_DIR}/src" "src"
     COMMAND "${NPM}" ci --no-audit --no-fund --no-progress
-    COMMAND "${NPM}" run --silent build
+    COMMAND "${NPM}" run build
     DEPENDS
         ${WEB_SOURCES}
         ${WEB_STYLES}

web/package.json

@@ -45,8 +45,7 @@
     "terser-webpack-plugin": "~5.3.6",
     "webpack": "~5.75.0",
     "webpack-bundle-analyzer": "~4.7.0",
-    "webpack-cli": "~4.7.2",
-    "webpack-dev-server": "~3.10.3"
+    "webpack-cli": "~4.7.2"
   },
   "dependencies": {
     "lodash.isequal": "~4.5.0"