mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity

(trunk libT) #4473 "underflow from malformed ssha1 can crash tr_ssha1_matches()" -- fixed. Thanks to Volfram for finding this crash and tracking down the cause.

This commit is contained in:
Jordan Lee 2011-09-16 22:53:26 +00:00
parent e095bba052
commit bb59768557
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libtransmission/crypto.c
View File

@ -377,9 +377,12 @@ tr_ssha1_matches( const char * source, const char * pass )
char * hashed;
uint8_t buf[SHA_DIGEST_LENGTH];
bool result;
const size_t sourcelen = strlen( source );
/* extract the salt */
saltlen = strlen( source ) - 2*SHA_DIGEST_LENGTH-1;
if( sourcelen < 2*SHA_DIGEST_LENGTH-1 )
return false;
saltlen = sourcelen - SHA_DIGEST_LENGTH-1;
salt = tr_malloc( saltlen );
memcpy( salt, source + 2*SHA_DIGEST_LENGTH+1, saltlen );