mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity

avoid unnecessary callback closures in the inspector.

This commit is contained in:
Jordan Lee 2011-09-03 19:15:03 +00:00
parent 3efa1bfba4
commit bd1e5b8e12
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
web/javascript/inspector.js
View File

@ -37,7 +37,9 @@ function Inspector(controller) {
} }
}, },
onTabClicked = function (ev, tab) { onTabClicked = function (ev) {
var tab = ev.currentTarget;
if (isMobileDevice) if (isMobileDevice)
ev.stopPropagation(); ev.stopPropagation();
@ -203,7 +205,7 @@ function Inspector(controller) {
filesAllClicked = function(s) { filesAllClicked = function(s) {
var i, row, rows=[], t=data.file_torrent; var i, row, rows=[], t=data.file_torrent;
if (!t) if (!t)
return; return;
for (i=0; row=data.file_rows[i]; ++i) for (i=0; row=data.file_rows[i]; ++i)
if (row.isEditable() && (t.getFile(i).wanted !== s)) if (row.isEditable() && (t.getFile(i).wanted !== s))
rows.push(row); rows.push(row);
@ -212,16 +214,16 @@ function Inspector(controller) {
}, },
changeFileCommand = function(rows, command) { changeFileCommand = function(rows, command) {
var torrentId = data.file_torrent.getId(); var torrentId = data.file_torrent.getId();
var rowIndices = $.map(rows.slice(0),function (row) {return row.getIndex();}); var rowIndices = $.map(rows.slice(0),function (row) {return row.getIndex();});
data.controller.changeFileCommand(torrentId, rowIndices, command); data.controller.changeFileCommand(torrentId, rowIndices, command);
}, },
onFileWantedToggled = function(row, want) { onFileWantedToggled = function(ev, row, want) {
changeFileCommand([row], want?'files-wanted':'files-unwanted'); changeFileCommand([row], want?'files-wanted':'files-unwanted');
}, },
onFilePriorityToggled = function(row, priority) { onFilePriorityToggled = function(ev, row, priority) {
var command; var command;
switch(priority) { switch(priority) {
case -1: command = 'priority-low'; break; case -1: command = 'priority-low'; break;
@ -260,8 +262,8 @@ function Inspector(controller) {
for (i=0; i<n; ++i) { for (i=0; i<n; ++i) {
row = data.file_rows[i] = new FileRow(tor, i); row = data.file_rows[i] = new FileRow(tor, i);
fragment.appendChild(row.getElement()); fragment.appendChild(row.getElement());
$(row).bind('wantedToggled',function(e,row,want) {onFileWantedToggled(row,want);}); $(row).bind('wantedToggled',onFileWantedToggled);
$(row).bind('priorityToggled',function(e,row,priority) {onFilePriorityToggled(row,priority);}); $(row).bind('priorityToggled',onFilePriorityToggled);
} }
file_list.appendChild(fragment); file_list.appendChild(fragment);
@ -450,9 +452,9 @@ function Inspector(controller) {
data.controller = controller; data.controller = controller;
$('.inspector_tab').click(function (e) {onTabClicked(e, this);}); $('.inspector_tab').click(onTabClicked);
$('#files_select_all').live('click', function(e) { filesSelectAllClicked(); }); $('#files_select_all').click(filesSelectAllClicked);
$('#files_deselect_all').live('click', function(e) { filesDeselectAllClicked(); }); $('#files_deselect_all').click(filesDeselectAllClicked);
data.elements.info_page = $('#inspector_tab_info_container')[0]; data.elements.info_page = $('#inspector_tab_info_container')[0];
data.elements.files_page = $('#inspector_tab_files_container')[0]; data.elements.files_page = $('#inspector_tab_files_container')[0];