mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity

fix: -Wnull-dereference warning in VariantHelpers::change(TrackerStat&, tr_variant*)

This commit is contained in:
Charles Kerr 2023-12-16 09:10:02 -06:00
parent d765bcff70
commit be1b9b650d
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qt/Application.h
View File

@ -97,6 +97,8 @@ private:
void quitLater() const; void quitLater() const;
void notifyTorrentAdded(Torrent const*) const; void notifyTorrentAdded(Torrent const*) const;
std::unordered_set<QString> interned_strings_;
std::unique_ptr<Prefs> prefs_; std::unique_ptr<Prefs> prefs_;
std::unique_ptr<Session> session_; std::unique_ptr<Session> session_;
std::unique_ptr<TorrentModel> model_; std::unique_ptr<TorrentModel> model_;
@ -114,8 +116,6 @@ private:
QString const config_name_ = QStringLiteral("transmission"); QString const config_name_ = QStringLiteral("transmission");
QString const display_name_ = QStringLiteral("transmission-qt"); QString const display_name_ = QStringLiteral("transmission-qt");
std::unordered_set<QString> interned_strings_;
#ifdef QT_DBUS_LIB #ifdef QT_DBUS_LIB
QString const fdo_notifications_service_name_ = QStringLiteral("org.freedesktop.Notifications"); QString const fdo_notifications_service_name_ = QStringLiteral("org.freedesktop.Notifications");
QString const fdo_notifications_path_ = QStringLiteral("/org/freedesktop/Notifications"); QString const fdo_notifications_path_ = QStringLiteral("/org/freedesktop/Notifications");

2
qt/VariantHelpers.cc
View File

@ -178,7 +178,7 @@ bool change(TrackerStat& setme, tr_variant const* value)
changed = true; changed = true;
} }
if (site_changed && !setme.sitename.isEmpty() && !setme.announce.isEmpty()) if (site_changed && !setme.sitename.isEmpty() && !setme.announce.isEmpty() && trApp != nullptr)
{ {
setme.announce = trApp->intern(setme.announce); setme.announce = trApp->intern(setme.announce);
trApp->load_favicon(setme.announce); trApp->load_favicon(setme.announce);