mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity

(trunk libT) heap pruning: using the same mechanism as in r12388, avoid an unnecessary malloc+memcpy+free in tr_bencToFile()

This commit is contained in:
Jordan Lee 2011-04-27 21:33:52 +00:00
parent c9b54799e3
commit c061390f65
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libtransmission/bencode.c
View File

@ -1683,8 +1683,10 @@ tr_bencToFile( const tr_benc * top, tr_fmt_mode mode, const char * filename )
/* save the benc to a temporary file */ /* save the benc to a temporary file */
{ {
char * buf = tr_bencToStr( top, mode, &nleft ); struct evbuffer * buf = tr_bencToBuf( top, mode );
const char * walk = buf; const char * walk = (const char *) evbuffer_pullup( buf, -1 );
nleft = evbuffer_get_length( buf );
while( nleft > 0 ) { while( nleft > 0 ) {
const int n = write( fd, walk, nleft ); const int n = write( fd, walk, nleft );
if( n >= 0 ) { if( n >= 0 ) {
@ -1696,7 +1698,8 @@ tr_bencToFile( const tr_benc * top, tr_fmt_mode mode, const char * filename )
break; break;
} }
} }
tr_free( buf );
evbuffer_free( buf );
} }
if( nleft > 0 ) if( nleft > 0 )