mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity

when pruning message log messages, sort them in reverse chronological before trimming and use removeObjectsAtIndexes: for assumedly more efficient removal

This commit is contained in:
Mitchell Livingston 2009-10-19 03:10:29 +00:00
parent 3e26db6ed0
commit c2f8e82c3d
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
macosx/MessageWindowController.m
View File

@ -96,7 +96,7 @@
saveButtonFrame.size.width += 10.0;
[fSaveButton setFrame: saveButtonFrame];
float oldClearButtonWidth = [fClearButton frame].size.width;
const CGFloat oldClearButtonWidth = [fClearButton frame].size.width;
[fClearButton setTitle: NSLocalizedString(@"Clear", "Message window -> save button")];
[fClearButton sizeToFit];
@ -170,11 +170,11 @@
NSUInteger total = [fMessages count];
if (total > MAX_MESSAGES)
{
//remove the oldest
NSSortDescriptor * descriptor = [[[NSSortDescriptor alloc] initWithKey: @"Index" ascending: YES] autorelease];
//remove the oldest - move oldest to end for (assumedly) most efficient removal
NSSortDescriptor * descriptor = [[[NSSortDescriptor alloc] initWithKey: @"Index" ascending: NO] autorelease];
[fMessages sortUsingDescriptors: [NSArray arrayWithObject: descriptor]];
[fMessages removeObjectsInRange: NSMakeRange(0, total-MAX_MESSAGES)];
[fMessages removeObjectsAtIndexes: [NSIndexSet indexSetWithIndexesInRange: NSMakeRange(MAX_MESSAGES, total-MAX_MESSAGES)]];
[fMessageTable noteHeightOfRowsWithIndexesChanged: [NSIndexSet indexSetWithIndexesInRange: NSMakeRange(0, MAX_MESSAGES)]];
total = MAX_MESSAGES;