mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity

fixup! fixup! fix: ensure all bytes read / written to file (#2682) (#2780) (#3033) 

fix spurious tr_error being set when reading up to EOF.

This regression generated invalid error messages when no error occurred.
This commit is contained in:
Charles Kerr 2022-04-30 16:57:11 -05:00 committed by GitHub
parent 7eecdca68e
commit c8f5cff564
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libtransmission/file-posix.cc
View File

@ -58,6 +58,7 @@
#include "file.h"
#include "log.h"
#include "tr-assert.h"
#include "tr-strbuf.h"
#include "utils.h"
#ifndef O_LARGEFILE
@ -386,7 +387,7 @@ char* tr_sys_path_resolve(char const* path, tr_error** error)
std::string tr_sys_path_basename(std::string_view path, tr_error** error)
{
auto tmp = std::string{ path };
auto tmp = tr_pathbuf{ path };
if (char const* ret = basename(std::data(tmp)); ret != nullptr)
{
@ -399,7 +400,7 @@ std::string tr_sys_path_basename(std::string_view path, tr_error** error)
std::string tr_sys_path_dirname(std::string_view path, tr_error** error)
{
auto tmp = std::string{ path };
auto tmp = tr_pathbuf{ path };
if (char const* ret = dirname(std::data(tmp)); ret != nullptr)
{
@ -783,7 +784,7 @@ bool tr_sys_file_read_at(
ret = true;
}
else
else if (my_bytes_read == -1)
{
set_system_error(error, errno);
}