fix small memory leak that has been around forever

This commit is contained in:
Mitchell Livingston 2007-09-16 00:40:15 +00:00
parent b74cfa9358
commit e03c677828
4 changed files with 8 additions and 9 deletions

View File

@ -2647,8 +2647,7 @@ void sleepCallBack(void * controller, io_service_t y, natural_t messageType, voi
- (void) doNothing: (id) sender {} - (void) doNothing: (id) sender {}
- (NSToolbarItem *) toolbar: (NSToolbar *) t itemForItemIdentifier: - (NSToolbarItem *) toolbar: (NSToolbar *) t itemForItemIdentifier: (NSString *) ident willBeInsertedIntoToolbar: (BOOL) flag
(NSString *) ident willBeInsertedIntoToolbar: (BOOL) flag
{ {
NSToolbarItem * item = [[NSToolbarItem alloc] initWithItemIdentifier: ident]; NSToolbarItem * item = [[NSToolbarItem alloc] initWithItemIdentifier: ident];
@ -2743,7 +2742,7 @@ void sleepCallBack(void * controller, io_service_t y, natural_t messageType, voi
return nil; return nil;
} }
return item; return [item autorelease];
} }
- (NSArray *) toolbarAllowedItemIdentifiers: (NSToolbar *) t - (NSArray *) toolbarAllowedItemIdentifiers: (NSToolbar *) t

View File

@ -792,13 +792,13 @@
return [[peer objectForKey: @"Connected"] boolValue] ? fDotGreen : fDotRed; return [[peer objectForKey: @"Connected"] boolValue] ? fDotGreen : fDotRed;
else if ([ident isEqualToString: @"Encryption"]) else if ([ident isEqualToString: @"Encryption"])
{ {
/*if ([[peer objectForKey: @"Encryption"] boolValue]) if ([[peer objectForKey: @"Encryption"] boolValue])
{ {
if (!fLockImage) if (!fLockImage)
fLockImage = [NSImage imageNamed: @"Lock.tiff"]; fLockImage = [NSImage imageNamed: @"Lock.tiff"];
return fLockImage; return fLockImage;
} }
else*/ else
return nil; return nil;
} }
else if ([ident isEqualToString: @"Client"]) else if ([ident isEqualToString: @"Client"])
@ -863,8 +863,8 @@
NSLocalizedString(@"Progress: %.1f%%", "Inspector -> Peers tab -> table row tooltip"), NSLocalizedString(@"Progress: %.1f%%", "Inspector -> Peers tab -> table row tooltip"),
[[peer objectForKey: @"Progress"] floatValue] * 100.0]]; [[peer objectForKey: @"Progress"] floatValue] * 100.0]];
/*if ([[peer objectForKey: @"Encryption"] boolValue]) if ([[peer objectForKey: @"Encryption"] boolValue])
[components addObject: NSLocalizedString(@"Encrypted Connection", "Inspector -> Peers tab -> table row tooltip")];*/ [components addObject: NSLocalizedString(@"Encrypted Connection", "Inspector -> Peers tab -> table row tooltip")];
} }
int port; int port;

View File

@ -209,7 +209,7 @@
return nil; return nil;
} }
return item; return [item autorelease];
} }
- (NSArray *) toolbarSelectableItemIdentifiers: (NSToolbar *) toolbar - (NSArray *) toolbarSelectableItemIdentifiers: (NSToolbar *) toolbar

View File

@ -1039,7 +1039,7 @@ static int static_lastid = 0;
if (peer->isUploading) if (peer->isUploading)
[dic setObject: [NSNumber numberWithFloat: peer->downloadFromRate] forKey: @"DL From Rate"]; [dic setObject: [NSNumber numberWithFloat: peer->downloadFromRate] forKey: @"DL From Rate"];
//[dic setObject: [NSNumber numberWithBool: peer->isEncrypted] forKey: @"Encryption"]; [dic setObject: [NSNumber numberWithBool: /*peer->isEncrypted*/NO] forKey: @"Encryption"];
[dic setObject: [NSString stringWithCString: (char *) peer->client encoding: NSUTF8StringEncoding] forKey: @"Client"]; [dic setObject: [NSString stringWithCString: (char *) peer->client encoding: NSUTF8StringEncoding] forKey: @"Client"];
} }