From ea368388ed8b1762a4b1b91f72dcb427b48ec824 Mon Sep 17 00:00:00 2001 From: Mike Gelfand Date: Wed, 22 Apr 2015 20:36:28 +0000 Subject: [PATCH] Fix JS error on undefined creator during inspector update Since torrents' info is fetched asynchronously, it may not yet be available when inspector updates. Account for possibly undefined creator. Refine logic used to construct torrent origin phrase to prevent results such as "Created by on " or "Created by on ". --- web/javascript/inspector.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/web/javascript/inspector.js b/web/javascript/inspector.js index 8e97a2d0d..6fe26bcaf 100644 --- a/web/javascript/inspector.js +++ b/web/javascript/inspector.js @@ -422,13 +422,15 @@ function Inspector(controller) { if(date != t.getDateCreated()) mixed_date = true; } + var empty_creator = !creator || !creator.length, + empty_date = !date; if(mixed_creator && mixed_date) str = mixed; - else if(!creator.length && !date) + else if(empty_creator && empty_date) str = unknown; - else if(mixed_date && creator.length) + else if((mixed_date || empty_date) && !empty_creator) str = 'Created by ' + creator; - else if(mixed_creator && date) + else if((mixed_creator || empty_creator) && !empty_date) str = 'Created on ' + (new Date(date*1000)).toDateString(); else str = 'Created by ' + creator + ' on ' + (new Date(date*1000)).toDateString();