mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity

perf: avoid vector temporary in announcer-udp (#4519)

This commit is contained in:
Charles Kerr 2023-01-02 12:41:47 -06:00 committed by GitHub
parent 2d2a5e1ad6
commit eb27220662
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libtransmission/announcer-udp.cc
View File

@ -230,8 +230,8 @@ struct tau_announce_request
response.leechers = buf.toUint32();
response.seeders = buf.toUint32();
auto const contiguous = std::vector<std::byte>{ std::begin(buf), std::end(buf) };
response.pex = tr_pex::from_compact_ipv4(std::data(contiguous), std::size(contiguous), nullptr, 0);
auto const [bytes, n_bytes] = buf.pullup();
response.pex = tr_pex::from_compact_ipv4(bytes, n_bytes, nullptr, 0);
requestFinished();
}
else
@ -383,8 +383,8 @@ struct tau_tracker
buf.addUint32(TAU_ACTION_CONNECT);
buf.addUint32(this->connection_transaction_id);
auto const contiguous = std::vector<std::byte>(std::begin(buf), std::end(buf));
this->sendto(std::data(contiguous), std::size(contiguous));
auto const [bytes, n_bytes] = buf.pullup();
this->sendto(bytes, n_bytes);
}
if (timeout_reqs)
@ -544,8 +544,8 @@ private:
buf.addUint64(this->connection_id);
buf.add(payload, payload_len);
auto const contiguous = std::vector<std::byte>(std::begin(buf), std::end(buf));
this->sendto(std::data(contiguous), std::size(contiguous));
auto const [bytes, n_bytes] = buf.pullup();
this->sendto(bytes, n_bytes);
}
public:

2
libtransmission/peer-socket.cc
View File

@ -80,7 +80,7 @@ size_t tr_peer_socket::try_write(Buffer& buf, size_t max, tr_error** error) cons
#ifdef WITH_UTP
if (is_utp())
{
auto [data, datalen] = buf.pullup();
auto const [data, datalen] = buf.pullup();
errno = 0;
auto const n_written = utp_write(handle.utp, data, std::min(datalen, max));