mirror/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission synced 2025-03-11 14:43:42 +00:00
Code Issues Releases Wiki Activity

chore: remove unused tr_announce_list::announce_to_scrape(tr_quark) (#6157)

Browse source 
* chore: remove unused tr_announce_list::announce_to_scrape(tr_quark)

* fixup! chore: remove unused tr_announce_list::announce_to_scrape(tr_quark)

fix test oops
This commit is contained in:
Charles Kerr 2023-10-24 10:58:01 -04:00 • committed by GitHub
parent 6d958bd5fc
commit eb58996c9f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
libtransmission/announce-list.cc
View file

@ -152,16 +152,6 @@ std::optional<std::string> tr_announce_list::announce_to_scrape(std::string_view
return {};
}
tr_quark tr_announce_list::announce_to_scrape(tr_quark announce)
{
if (auto const scrape_str = announce_to_scrape(tr_quark_get_string_view(announce)); scrape_str)
{
return tr_quark_new(*scrape_str);
}
return TR_KEY_NONE;
}
tr_tracker_tier_t tr_announce_list::nextTier() const
{
return std::empty(trackers_) ? 0 : trackers_.back().tier + 1;

1
libtransmission/announce-list.h
View file

@ -131,7 +131,6 @@ public:
bool save(std::string_view torrent_file, tr_error** error = nullptr) const;
[[nodiscard]] static std::optional<std::string> announce_to_scrape(std::string_view announce);
[[nodiscard]] static tr_quark announce_to_scrape(tr_quark announce);
private:
[[nodiscard]] tr_variant to_tiers_variant() const;

4
tests/libtransmission/announce-list-test.cc
View file

@ -339,8 +339,8 @@ TEST_F(AnnounceListTest, announceToScrape)
for (auto const& test : Tests)
{
auto const scrape = tr_announce_list::announce_to_scrape(tr_quark_new(test.announce));
EXPECT_EQ(tr_quark_new(test.expected_scrape), scrape);
auto const scrape = tr_announce_list::announce_to_scrape(test.announce);
EXPECT_EQ(test.expected_scrape, scrape.value_or(""));
}
}