mirror
/
transmission
mirror of https://github.com/transmission/transmission
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix drag-and-drop. 

It's better to use memory before you free it, not after.
This commit is contained in:
Josh Elsasser 2006-06-25 19:03:54 +00:00
parent f75fbbd82c
commit eba089b5ed
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gtk/main.c
View File

@ -561,7 +561,7 @@ gotdrag(GtkWidget *widget SHUTUP, GdkDragContext *dc, gint x SHUTUP,
GList *errs; GList *errs;
struct stat sb; struct stat sb;
int prelen = strlen(prefix); int prelen = strlen(prefix);
GList *paths; GList *paths, *freeables;
#ifdef DND_DEBUG #ifdef DND_DEBUG
char *sele = gdk_atom_name(sel->selection); char *sele = gdk_atom_name(sel->selection);
@ -582,6 +582,7 @@ gotdrag(GtkWidget *widget SHUTUP, GdkDragContext *dc, gint x SHUTUP,
errs = NULL; errs = NULL;
paths = NULL; paths = NULL;
freeables = NULL;
if(gdk_atom_intern("XdndSelection", FALSE) == sel->selection && if(gdk_atom_intern("XdndSelection", FALSE) == sel->selection &&
8 == sel->format) { 8 == sel->format) {
/* split file list on carriage returns and linefeeds */ /* split file list on carriage returns and linefeeds */
@ -600,6 +601,7 @@ gotdrag(GtkWidget *widget SHUTUP, GdkDragContext *dc, gint x SHUTUP,
len = strlen(files + ii); len = strlen(files + ii);
/* de-urlencode the URI */ /* de-urlencode the URI */
decoded = urldecode(files + ii, len); decoded = urldecode(files + ii, len);
freeables = g_list_append(freeables, decoded);
if(g_utf8_validate(decoded, -1, NULL)) { if(g_utf8_validate(decoded, -1, NULL)) {
/* remove the file: prefix */ /* remove the file: prefix */
if(prelen < len && 0 == strncmp(prefix, decoded, prelen)) { if(prelen < len && 0 == strncmp(prefix, decoded, prelen)) {
@ -616,16 +618,14 @@ gotdrag(GtkWidget *widget SHUTUP, GdkDragContext *dc, gint x SHUTUP,
paths = g_list_append(paths, deslashed); paths = g_list_append(paths, deslashed);
} }
} }
g_free(decoded);
} }
} }
/* try to add any torrents we found */ /* try to add any torrents we found */
if(NULL != paths) { if(NULL != paths)
addtorrents(data, NULL, paths, NULL, addtorrents(data, NULL, paths, NULL,
addactionflag(cf_getpref(PREF_ADDSTD))); addactionflag(cf_getpref(PREF_ADDSTD)));
freestrlist(paths); freestrlist(freeables);
}
g_free(files); g_free(files);
} }