From ec8cb83711f2672ff3e6923a582991b3daa41202 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Sun, 30 Mar 2008 03:03:42 +0000 Subject: [PATCH] (gtk) better error recording in the prefs dialog when updating the blocklist --- gtk/tr-prefs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gtk/tr-prefs.c b/gtk/tr-prefs.c index 72c447423..820a7960e 100644 --- a/gtk/tr-prefs.c +++ b/gtk/tr-prefs.c @@ -309,7 +309,6 @@ updateBlocklist( gpointer vdata ) const char * url; char * text = NULL; gchar * filename = NULL; - GError * err = NULL; int fd = -1; int ok = 1; @@ -325,18 +324,22 @@ updateBlocklist( gpointer vdata ) ok = FALSE; g_snprintf( data->secondary, sizeof( data->secondary ), _( "Unable to get blocklist." ) ); + g_message( data->secondary ); g_idle_add( blocklistDialogSetSecondary, data ); } } if( ok && !data->abortFlag ) { + GError * err = NULL; fd = g_file_open_tmp( "transmission-blockfile-XXXXXX.gz", &filename, &err ); if( err ) { g_snprintf( data->secondary, sizeof( data->secondary ), _( "Unable to get blocklist: %s" ), err->message ); + g_warning( data->secondary ); g_idle_add( blocklistDialogSetSecondary, data ); g_clear_error( &err ); + ok = FALSE; } else { write( fd, text, size ); close( fd );