Commit Graph

688 Commits

Author SHA1 Message Date
Hakjoon Sim 5f811e4604
chore(web): dev environment (#1489) 2020-10-30 19:25:33 -05:00
Charles Kerr 61d221c8bb
Web client add licensing info (#1481)
* chore: add '@license' tag to web sources' comments

Webpack's tersify plugin looks for that JSDoc tag in order to decide
which comments to extract into the generated license file.

* chore: address sonarcloud.io warnings

* chore: address sonarcloud.io code smells

* fixup! chore: address sonarcloud.io warnings
2020-10-25 16:13:48 -05:00
Charles Kerr cd453764b1
feat: web client refresh (#1476)
Give the web client a major overhaul.

User-visible highlights include:

* Mobile is now fully supported.
* Added fullscreen support on mobile.
* Better support for dark mode.
* Added mime icons to the torrent list.
* Improved theme consistency across the app.

Maintainer highlights include:

* Updated code to use ES6 APIs.
* No longer uses jQuery UI.
* No longer uses jQuery.
* Use Webpack to bundle the Javascript, CSS, and assets together -- the entire bundle size is now 68K gzipped.
* Added eslint / prettier / stylelint tooling.
* Uses torrent-get's 'table' mode for more efficient RPC calls.
2020-10-23 20:04:25 -05:00
Mike Gelfand 4c7153fa48
Remove autotools-based build system (#1465)
* Support .git files (e.g. for worktrees, submodules)
* Fix symlinks in source tarball, switch to TXZ, adjust non-release name
* Remove autotools stuff
2020-10-13 03:15:19 +03:00
Charles Kerr 54a7cac25a
chore: run uncrustify in parallel; add package.json to web directory (#1454)
* refactor: add package.json for web client

* refactor: call uncrustify in parallel
2020-09-20 15:41:45 -05:00
Charles Kerr 017fa1cf1e fixup! chore: add precommit hook for testing code style (#1448) 2020-09-14 13:02:03 -05:00
Charles Kerr be219ddee0
chore: add precommit hook for testing code style (#1448)
* chore: add precommit hook for testing code style

* chore: use prettier + eslint for js code
2020-09-13 21:41:32 -05:00
Charles Kerr 09cc4c7a68
fix: broken HTML (#1446)
* chore: refresh css files with sass 1.26.10

* fix: css selector for toolbar-separator

* chore: fix duplicate html ids in mac client faq

* fix: duplicate ID 'pagetitle' tags in Mac help

* fix: duplicate ID 'taskbox' tags in Mac help

* chore: fix mismatched div
2020-09-12 21:44:47 -05:00
Charles Kerr 83cc7e04c8
Fix more coverity warnings (#1445)
cast intentionally-ignored function retval to null

remove superfluous JSON polyfill from web client.
2020-09-12 08:17:18 -05:00
Charles Kerr efaa66a920
fix: resolve some lgtm warnings (#1444)
* fix: warnings found by LGTM static analyzer
2020-09-11 16:07:45 -05:00
Pedro Scarapicchia Junior 0a897cb3aa
Remove unused html (#1313) 2020-06-14 16:04:26 -05:00
Charles Kerr 8739cb9c88
fixup! (trunk) update credits (#1205) 2020-05-02 11:42:18 -05:00
Mike Gelfand 3ba0b9df15 Fixup some formatting leftovers (JS) 2019-02-17 17:51:13 +03:00
Mike Gelfand c951848a5b Merge branch '2.9x' 2018-05-01 22:44:51 +03:00
Mike Gelfand 913d9d3f37 HTML-escape torrent name displayed in trackers inspector tab
This will prevent injection of arbitrary HTML when multiple torrents are
selected. Follow-up to the previous commit.
2018-04-17 13:25:49 +03:00
Mike Gelfand 523d8c1317 Tracker error XSS in inspector (web client)
Tracker error messages are inadequately output encoded when rendered by the
tracker information page inside the WebUI, allowing a malicious tracker to
inject an XSS payload into the page. Esploiting this issue allows an
attacker to supply arbitrary client-side code that will ultimately be
rendered and executed within the end user's web browser.

Found by Rory McNamara (Gotham Digital Science). CVE pending.
2018-04-17 13:25:49 +03:00
Mike Gelfand aa2730d47c Switch to HTTPS links, adjust wiki links where possible
Fixes #39
2018-01-16 01:12:59 +03:00
Robert Vehse a6ef87b92d Update all instances of the donation link. Fixes #26. 2018-01-15 23:57:46 +03:00
Mike Gelfand edf158b509
Merge pull request #364 from futekov/patch-2
Download/upload speed typography changes for web ui
2017-11-28 22:48:10 +03:00
Mike Gelfand 486f040be4 Fix torrent list styling issue in Chrome 59+ (patch by @kyleinprogress)
Fixes: #384
2017-08-27 09:52:02 +03:00
clyang f21c9109ee Disable browser to autocomplete on torrent url field
It disrupts the view and I can't come up a daily usage scenario that needs to utilize autocomplete function.
2017-08-11 00:52:40 +08:00
Alexander Futekov 660b44da70 DL/UL speed typography changes for web ui
The current icons are very hard to read at the current font size and it's not immediately visible which icon i which.

Additionally, spaces after icons are removed because upload icon is equally positioned between DL/UL speeds (like so `↓ 273 kB/s **↑** 0 kB/s`) which requires reading the whole line to make sense of which number the arrow applies to.

To further separate one type of information from another the hyphen is replaced by the slightly wider en dash.

Old vs New:
Downloading from 7 of 19 peers - ↓ 273 kB/s ↑ 167 kB/s
Downloading from 7 of 19 peers – ▼273 kB/s ▲167 kB/s
2017-08-07 06:34:00 +03:00
Sven Depondt 7ded47bb7c Revert indentation from commit d94f44b
`switch` and `case` are on the same level everywhere else.
2017-07-30 14:36:58 +02:00
Sven Depondt d94f44b777 Rework hotkeys for focused input fields and open dialogs
Also added 2 hotkeys:
    1. `i` Toggle inspector
    2. `l` Set location
2017-07-30 13:54:13 +02:00
Sven Depondt 0978dbf890 Use id when handling hotkeys for specific dialogs
Identifying a dialog by it's header title is kinda dirty and now we use
the dialogs id instead. We also check if the dialog is visible before executing
the hotkey action.
2017-07-28 22:32:18 +02:00
Sven Depondt a52ef89161 Add keyboard hotkeys for web interface 2017-07-28 18:56:50 +02:00
Mike Gelfand 54b786c9f3 Merge pull request #320 from gonstr/master
(web) show upload torrent file button on mobile devices
2017-07-16 21:01:09 +03:00
Mike Gelfand 7e6f1a8dc8 Set idle seed limit range to 1..40320 (4 weeks tops) in all clients
Fixes: #212
2017-07-05 21:07:16 +03:00
gonstr bb426c47c4 Removed freespace-info class from sass file 2017-07-01 19:44:38 +02:00
gonstr 2624c6b73b Unhide upload file button 2017-07-01 19:26:34 +02:00
Fish2 b0e3d4c37d lossless compression of images saved 72KB 2017-06-03 23:52:34 +01:00
Mike Gelfand 4df187885f Merge pull request #146 from tonsV2/master
ETA is now shown in compact view.
2017-05-21 07:24:59 +03:00
Mike Gelfand bcfe147e6a Fix web UI loading on mobile devices 2017-05-21 06:49:41 +03:00
Sebastian Jensen cad82b64d9 ETA is now shown in compact view. 2017-05-21 06:48:56 +03:00
lisenenkov b4068e39f0 Merge branch 'master' into master 2017-02-12 18:44:06 +03:00
lisenenkov 076535e3d3 Update inspector.js
https info not showed
2017-02-12 18:41:50 +03:00
Mike Gelfand a3654c65a5 Replace setInterval() with setTimeout() for web UI refresh (patch by WGH)
Fixes: TRAC-6031
2017-01-15 11:17:31 +03:00
Markus Amalthea Magnuson 727b9671f7 Update all website links to canonical HTTPS version. 2016-10-31 10:00:11 +01:00
Robert Vehse 13bae8179e Update all instances of the donation link. Fixes #26. 2016-09-23 04:36:41 +02:00
Mike Gelfand 66285a525b Web UI: main() refactoring (patch by skybon @ GH-9)
Less jQuery, more Web API. Moved main() away from common.
2016-04-12 19:03:01 +00:00
Mike Gelfand 5569efc3d4 #6089: Beautified JavaScript (patch by skybon) 2016-03-10 19:05:13 +00:00
Mike Gelfand 5e3c60f565 #5974: Torrents queued should be able to "Resume Now" (patch by JJTagy) 2016-01-03 20:57:42 +00:00
Mike Gelfand 8b4da8c22e #4518: Mark appropriate fields in prefs as html5 number fields (patch by e-moe) 2015-10-08 18:54:43 +00:00
Mike Gelfand 7177d43ba1 #5944: Unify indentation style and strip trailing whitespaces across JS code, no functional changes (patch by xzcvczx + a lot more) 2015-05-05 19:12:48 +00:00
Mike Gelfand 50364a7883 #4866: Replace existing menus with jQueryUI menu 2015-04-30 05:20:48 +00:00
Mike Gelfand 9674df5c4d Use jQuery UI's `ui-helper-hidden` CSS class instead of our own 2015-04-26 03:35:44 +00:00
Mike Gelfand cd8ed4ff10 #5894: Get rid of eval() in JS code (patch by Ancient; 2nd part) 2015-04-23 19:30:40 +00:00
Mike Gelfand fd8e1e25a4 #5894: Get rid of inline styles in HTML (patch by Ancient; 1st part, slightly modified per IRC discussion) 2015-04-23 19:02:38 +00:00
Mike Gelfand 06d73853b9 Even better (and unified) torrent origin logic for GTK+, Qt and web clients 2015-04-22 21:04:49 +00:00
Mike Gelfand ea368388ed Fix JS error on undefined creator during inspector update
Since torrents' info is fetched asynchronously, it may not yet be
available when inspector updates. Account for possibly undefined
creator.

Refine logic used to construct torrent origin phrase to prevent
results such as "Created by  on <date>" or "Created by <creator>
on ".
2015-04-22 20:36:28 +00:00
Mike Gelfand dc1eb80dca #5894: Fix autotools build ("trailing backslash on last line") 2015-04-21 21:23:15 +00:00
Mike Gelfand ff7638d901 #5894: Update jQuery to 1.11.2 (with Migrate plugin 1.2.1), jQuery UI to 1.11.4 2015-04-21 21:17:45 +00:00
Jordan Lee d11f016ae8 (trunk, libT) #5699 'Toggle Inspector's Origin: is incorrect' -- fixed, patch by enzotrew 2014-07-03 19:31:59 +00:00
Jordan Lee 157bbe73f6 (trunk, web) #5620 'Inspector - Clickable urls in Comment field' -- added with patch by e-moe, thanks also to cfpp2p for testing 2014-04-15 21:30:38 +00:00
Jordan Lee e02b244300 (trunk) #5619 'Invalid magnet link gives no error dialog' -- fixed with patch by dale2507 2014-04-15 21:26:52 +00:00
Jordan Lee 5f2daaafb3 (trunk, gtk/qt/web) #5581: 'Inconsistent ordering of Upload and Download speed limits' -- fixed. 2014-01-20 23:56:06 +00:00
Jordan Lee 49c4b8b42a (trunk, web) #5589 'Magnet torrent shows 'retrieving' even when stopped' -- fix by JJTagy 2014-01-20 22:32:20 +00:00
Jordan Lee ce6b9dfad4 (trunk, web) #5510 'add file renaming to transmission web interface' -- whoops, forgot index.html in r14210 2013-10-20 19:41:37 +00:00
Jordan Lee 258b6cf029 (trunk, web) #5510 'add file renaming to transmission web interface' -- added with patch from mark ablov 2013-10-20 18:39:07 +00:00
Jordan Lee c79a5a191f (trunk, web) #5500 - don't add the X-Transmission-Session-Id header if we don't have a value for it. 2013-10-20 17:09:46 +00:00
Jordan Lee f217dc2a60 (trunk, web) #5439: fix web client issue in IE 11 2013-07-24 22:35:52 +00:00
Jordan Lee b38d819690 (trunk, web) #5440: fix syntax error in index.html's meta name='viewport' entry. 2013-07-24 22:33:59 +00:00
Jordan Lee 94fd3b486b (trunk) slightly better image compression by passing them through pngwolf 2013-07-14 23:03:31 +00:00
Jordan Lee a95b6c1e6c (trunk) #5382: better compression of our bundled png files. recompressed by Mangix 2013-06-26 02:06:43 +00:00
Jordan Lee adb8077706 (trunk web) #5380 'numeric input method not compatible with non-querty keyboards' -- fixed w/patch from lechevalierd3on 2013-06-09 19:41:51 +00:00
Jordan Lee 4a28e82f3f #5343 slightly better compression in two jQueryUI png files, compressed by Mangix 2013-04-13 12:31:44 +00:00
Jordan Lee c3be9b9afc (web) fix add-by-URL regression in the nightlies 2013-04-10 03:00:37 +00:00
Jordan Lee c51132ad78 #5335: better compression of .png files by Mangix 2013-04-10 02:27:42 +00:00
Jordan Lee a2ce709d8c (web) #5290 'Use HTML5's FileReader to upload .torrent files': done 2013-02-18 00:12:51 +00:00
Jordan Lee 8ed90f00cf (web) remove vim tmpfiles 2013-02-10 18:46:56 +00:00
Jordan Lee a7c6e78985 In Web Client, use jQuery.ajax() to upload files
If we use FormData and jQuery.ajax() calls to upload a torrent,
we can stop bundling the jquery.form.js module. In addition, this
simplifies passing arguments in the headers s.t. rpc-server.c doesn't
have to look for the CSRF token as one of the multiparts.

This changes the upload POST behavior, so give it a new name (upload2).
The old function (upload) will be deprecated but kept until 2.90 so
that third-party web clients using the old POST semantics will have
time to update.

Bug #5290 <https://trac.transmissionbt.com/ticket/5290>
2013-02-10 18:33:04 +00:00
Jordan Lee 32fc85641a Make accidentally-public function names private
inspector.js' functions, beginning with addSubtreeToView(), are leaked
into the DOM due to a missing comma at the end of the previous func.
Bug #5289 <https://trac.transmissionbt.com/ticket/5289>
2013-02-10 18:32:40 +00:00
Jordan Lee f70c4d88c7 (web) remove the freespace-info label from the web client.
As discussed at https://trac.transmissionbt.com/ticket/4076#comment:25
the freespace indicator is being moved out of the statusbar to another
place.
2013-02-10 18:32:15 +00:00
Jordan Lee 69aeed3226 (web) #5214 'add storage free space indicator' -- added with patch by taem 2013-02-05 14:45:41 +00:00
Jordan Lee 282ef8adfd use 'folder' instead of 'directory' in the freespace tooltips 2013-01-27 18:48:59 +00:00
Jordan Lee 729ef84e62 (web) #5214 'add free space indicator': added with patch by taem 2013-01-27 17:41:35 +00:00
Jordan Lee 0644020154 (web) #5138 'sort setting lost after some days' -- set the cookies to expire after a year, rather than a month. 2013-01-05 03:29:22 +00:00
Jordan Lee 5b89991e51 (web) #5210 'filter bar on iOS is too short' -- another tweak based on bmw's feedback 2013-01-05 03:05:46 +00:00
Jordan Lee 7e46d5087f (web) #5210 'filter bar on iOS is too short' -- tweak to undo r13756 regression 2013-01-05 02:46:59 +00:00
Jordan Lee 892b01ecff (web) #4873 -- fix the margins of the toolbar buttons in mobile css 2013-01-04 05:59:18 +00:00
Jordan Lee d5bae06433 (web) #4873 -- fix left margin of the torrent list in the mobile css 2013-01-04 05:25:51 +00:00
Jordan Lee dbaf0bcbeb (trunk, web) #5119 'Error when displaying tracker list' -- fixed. 2012-11-11 15:13:47 +00:00
Mitchell Livingston 79c7bab472 #5118 (web client) Tracker tier count should start at 1 2012-11-02 21:42:10 +00:00
Mitchell Livingston 96e77053b4 #5108 Multi-file torrent selection bug 2012-10-29 22:14:46 +00:00
Mitchell Livingston ede2511b03 #5103 Restore DL/UL Arrows and Rates While Downloading 2012-10-25 03:56:57 +00:00
Jordan Lee fcf5690476 remove unused functions 2012-10-19 17:21:45 +00:00
Jordan Lee d6635829d5 remove dead code Inspector.accumulateString 2012-10-19 15:31:42 +00:00
Jordan Lee 2dedc1c4c6 (trunk, web) #5091 'Disable file selection for non-multi-file transfers' -- fixed. 2012-10-15 04:32:48 +00:00
Jordan Lee 25bee8d4a2 remove unneeded background-image rules for the inspector's file list's 'file wanted' checkbox; we use the browser's checkbox now 2012-10-15 04:20:55 +00:00
Mitchell Livingston 40a7634c78 #5086 Fix web interface ngettext 2012-10-10 03:03:32 +00:00
Jordan Lee 4dd6e35bd7 (trunk, web) replace Transmission.formatter.plural() with a slightly less brittle pluralization tool 2012-10-07 18:10:26 +00:00
Jordan Lee 7219f26dae (trunk, T) #5072 "In the torrent list, show how many web seeds we're downloading from" -- made the Qt, GTK+, and web client text consistent 2012-10-07 17:51:56 +00:00
Jordan Lee f8f5fa930f (trunk, web) #5072 "web client doesn't show webseed count" -- pluralization refinement to r13551 2012-10-07 16:33:55 +00:00
Jordan Lee 4f64831711 (web, trunk) #5072 'web client does not show webseed download count' -- use cfpp2p's patch to make it behave like the Mac client. 2012-10-06 18:22:57 +00:00
Jordan Lee 682d257808 (trac, web) #5072 'web client does not show webseed download count' -- fixed. 2012-10-05 21:23:50 +00:00
Jordan Lee ed2d2de530 (trunk, web) fix #5055 'torrents that include HTML in the comment section don't display properly in the web browser.' 2012-10-05 02:23:17 +00:00
Jordan Lee d063c4fb1d (trunk, web) #5013: finish by syncing common.css with common.scss 2012-09-26 02:44:24 +00:00
Jordan Lee 245ed7c7e2 (trunk, web) #5013: remove redundant buttons, these were supposed to be removed in r13523 2012-09-26 02:41:47 +00:00
Jordan Lee ee3eca112d (trunk web) #5013 fix r13523 regression with initializing file priority buttons 2012-09-23 22:55:21 +00:00
Jordan Lee 6438568d66 (trunk web) #5013 fix r13523 tyop 2012-09-23 22:33:55 +00:00