Commit Graph

50 Commits

Author SHA1 Message Date
Noobsai 79d3133ebc
Fixed showing popup menu on RMB at tray icon (#1210) 2020-05-11 16:19:33 -05:00
Charles Kerr b0e33117c5
Fix some gtk warnings (#1038)
* fix gtk deprecation warning: gtk_misc_set_alignment

* fix gtk deprecation warning: gtk_alignment_new

* fix gtk deprecation warning: gtk_tree_view_set_rules_hint

* fix gtk deprecation warning: gtk_image_new_from_stock

* fixup! fix gtk deprecation warning: gtk_alignment_new

* fix gtk deprecation warning: gtk_dialog_set_alternative_button_order

* fix gtk deprecation warning: gtk_show_uri

* fix gtk deprecation warning: gtk_widget_set_margin_left

* fix gtk deprecation warning: gtk_button_set_alignment

* fix gtk deprecation warning: g_type_class_add_private

* fix gtk deprecation warning: gtk_menu_popup

* fix gtk deprecation warning: gtk_misc_set_padding

* chore: uncrustify

* fix: silence G_TYPE_INSTANCE_GET_PRIVATE warning

Deprecaed starting in glib 2.58

* chore: uncrustify
2019-11-06 13:09:27 -06:00
Mike Gelfand 4f9d9ad92b Code style change leftovers
For some reason, GTK client wasn't fully processed. All the rest of changes
are mostly in comments.
2017-04-21 10:40:57 +03:00
Mike Gelfand dadffa2c0f Align type qualifiers to the right (code style)
This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped
together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading
types right-to-left, e.g. "constant pointer to constant T" vs. "constant
pointer to T which is constant".
2017-04-20 19:53:20 +03:00
Mike Gelfand d7930984ef Adjust uncrustify config, reformat all but Mac client
There're places where manual intervention is still required as uncrustify
is not ideal (unfortunately), but at least one may rely on it to do the
right thing most of the time (e.g. when sending in a patch).

The style itself is quite different from what we had before but making it
uniform across all the codebase is the key. I also hope that it'll make the
code more readable (YMMV) and less sensitive to further changes.
2017-04-20 10:01:22 +03:00
Mike Gelfand 2248d3670f Get rid of $Id$ SVN keywords in source files 2016-09-02 23:10:15 +03:00
Jordan Lee 02cff80c2d Copyedit the license's revised text: (1) remove unnecessary repitition use of the word 'license' from the top of the header and source files (2) add the standard 'we hope it's useful, but no warranty' clause to COPYING (3) make explicit that linking OpenSSL is allowed (see https://people.gnome.org/~markmc/openssl-and-the-gpl.html for background) (4) sync the Qt and GTK+ clients' license popups with COPYING's revised text 2014-01-21 03:10:30 +00:00
Jordan Lee 4b9626bb83 Licensing changes:
1. add the option the code to be used under GPLv2 or GPLv3; previously only GPLv2 was allowed

2. add the "proxy option" as described in GPLv3 so we can add future licenses without having to bulk-edit everything again :)

3. remove the awkward "exception for MIT code in Mac client" clause; it was unnecessary and confusing.
2014-01-19 01:09:44 +00:00
Jordan Lee 4904b923fb (trunk) restore copyright year as suggested in email by rms 2014-01-18 20:56:57 +00:00
Jordan Lee cc1b1cd430 since Transmission supports older versions of glib, add a portability wrapper for G_DEFINE_QUARK 2013-07-24 00:13:31 +00:00
Jordan Lee 6a47b4a5d3 don't use a '-' character in the QN argument to G_DEFINE_QUARK. https://forum.transmissionbt.com/viewtopic.php?p=65548#p65548 2013-07-22 23:00:10 +00:00
Jordan Lee d244545979 use G_DEFINE_QUARK instead of rolling our own quark getters 2013-07-09 22:44:24 +00:00
Jordan Lee 59af132947 replace deprecated gtk_icon_info_free() calls with g_object_unref() in GTK+ >= 3.8.0 2013-07-08 16:25:18 +00:00
Jordan Lee 10b96f0f12 (gtk) copyediting: update several files to be closer to the gtk+ indentation style. 2013-01-04 19:45:39 +00:00
Jordan Lee 3d38723ad9 Follow more common whitespace style conventions in the C code (libtransmission, daemon, utils, cli, gtk). 2012-12-05 17:29:46 +00:00
Jordan Lee 5ad842b6a8 (trunk, gtk) fix #4871 'appindicator does not set its title' w/patch from seb128 2012-04-16 18:42:26 +00:00
Jordan Lee 10aa77490a (trunk gtk) remove an unnecessary GTK_CHECK_VERSION(2,10,0) check now that the minimum gtk+ version's been bumped 2011-08-08 16:02:37 +00:00
Jordan Lee 0e48418f26 (trunk gtk) since we're bumping glib's requirement to 2.26 (27 Sept 2010), it's a good time to bump the gtk+ requirement to 2.22 (32 Sept 2010). 2011-08-07 18:41:13 +00:00
Jordan Lee fb2ffbc542 (trunk gtk) use GQuarks instead of strings for keys in tr-icon and tr-window 2011-04-05 16:16:06 +00:00
Jordan Lee 9c7caec13f (trunk gtk) minor copyediting for clarity/readability 2011-03-04 14:31:23 +00:00
Jordan Lee c7006ed8b3 (trunk gtk) remove the TrTorrent GObject subclass. 2011-03-03 01:59:25 +00:00
Jordan Lee 879a2afcbd Update the copyright year in the source code comments.
The Berne Convention says that the copyright year is moot, so instead of adding another year to each file as in previous years, I've removed the year altogether from the source code comments in libtransmission, gtk, qt, utils, daemon, and cli.

Juliusz's copyright notice in tr-dht and Johannes' copyright notice in tr-lpd have been left alone; it didn't seem appropriate to modify them.
2011-01-19 13:48:47 +00:00
Charles Kerr e5bb3205a1 (trunk) Join the 21st century and use only 1 space at the end sentences. This commit is nearly as important as the semi-annual ones that remove trailing spaces from the ends of lines of code... :) 2010-12-27 19:18:17 +00:00
Charles Kerr 5eafe91824 (trunk gtk) general cleanup to make function's naming scheme and API more consistent. This is only a fraction of what the GTK+ client's codebase needs, unfortunately. 2010-12-21 19:20:58 +00:00
Charles Kerr 70be70d85f nice job. 2010-08-05 13:24:46 +00:00
Charles Kerr d63b719e43 (trunk gtk) have the GtkStatusIcon code use the same icon fallback scheme as the AppInd code 2010-07-04 18:27:03 +00:00
Charles Kerr 6e5af03d78 (trunk) #3045 "speed units" -- change the public API of libtransmission based on feedback from livings 2010-07-04 06:07:21 +00:00
Charles Kerr cdcc4705aa (trunk) #3045 "make libtransmission's API byte-oriented instead of KiB-oriented." -- implemented. This is a largish commit and will break the mac build for a little while. 2010-07-03 00:25:22 +00:00
Charles Kerr fe3d9ed95a (trunk) one of the least interesting commits ever: remove trailing spaces from source code lines... 2010-03-17 17:07:40 +00:00
Charles Kerr 6ddd5c4f12 (trunk gtk) #2900 "Indicator Application can only work with icon names, not rendered icons" -- patched for 1.90 in trunk. Thanks to qense for the patch. 2010-02-14 14:26:45 +00:00
Charles Kerr 5074c0c021 (trunk gtk) #2873 "optional appindicator support" -- committed patch to trunk for 1.90 2010-02-07 19:32:35 +00:00
Charles Kerr 67b9c83df5 (trunk gtk) #2780 "for themability, T needs unique icon names for window, system tray, and popup icons" -- added to trunk for 1.81 2010-01-21 20:51:48 +00:00
Charles Kerr 5c26afdb52 happy new year! 2010-01-04 21:00:47 +00:00
Charles Kerr 78ead8c3dd (trunk) update the copyright notices 2009-12-05 02:19:24 +00:00
Charles Kerr 84f8fb5258 (trunk gtk) #2587: speed display isn't the same in the main window and in the system tray icon's tooltip 2009-11-18 06:21:01 +00:00
Charles Kerr cb79214854 (trunk) remove trailing spaces 2009-08-10 20:04:08 +00:00
Charles Kerr 58ba65f55b (trunk, gtk/qt) use Monsoon's strings for encryption preferences and Deluge's system tray tooltip. 2009-06-30 18:08:50 +00:00
Charles Kerr a8a4259f3a (trunk gtk) update some of the gtk+ calls s.t. we're not using deprecated API calls anymore 2009-06-20 23:55:36 +00:00
Charles Kerr fe816d8135 (trunk) update the GPL code's copyright dates 2009-01-10 23:09:07 +00:00
Charles Kerr e44239fc4e (trunk gtk) #1585: use g_timeout_add_seconds() where appropriate to group timers together for fewer scheduled wakeups 2008-12-22 05:39:03 +00:00
Charles Kerr 9594112d27 updated email address 2008-12-16 00:20:44 +00:00
Charles Kerr cc89872dd4 run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened 2008-09-23 19:11:04 +00:00
Charles Kerr d39b7dced7 (gtk) #942: Option to inhibit / allow hibernation
(gtk) #943: Option to show / hide the tray icon
2008-05-24 23:23:20 +00:00
Charles Kerr d6373c9f6b (gtk) use the new libtransmission tweaks s.t. our update pulse causes less CPU load 2008-04-01 02:36:41 +00:00
Charles Kerr 531dd851ad more string work before the freeze. (1) use %'d to get thousands' grouping in end-user strings (2) follow HiG capitalization, quotation guidelines (3) fold a few more strings 2008-03-19 20:07:27 +00:00
Charles Kerr 1268a06337 (gtk) minor HIG: use "Toolbar" and "Statusbar" instead of "Tool Bar" and "Status Bar" 2008-03-19 19:30:03 +00:00
Charles Kerr 6ef6ac0928 the last i18n-centric commit for awhile, I hope. 2008-03-08 04:53:11 +00:00
Charles Kerr 909cb89b43 even more i18n string work, w/more feedback and reading through the transmission.pot file. 2008-03-08 01:43:20 +00:00
Charles Kerr 5efb7e626e (gtk) more i18n string work w/suggestions from andre and vuntz to use format strings with positions to allow argument reordering. 2008-03-07 21:59:27 +00:00
Charles Kerr 851e6ce008 (gtk) make the filename naming scheme a little more consistent. 2008-02-26 19:58:03 +00:00
Renamed from gtk/tr_icon.c (Browse further)