Commit Graph

4854 Commits

Author SHA1 Message Date
Charles Kerr 8183d7fddf
refactor: utils naming (#5696)
* chore: rename tr_strvContains to tr_strv_contains

* chore: rename tr_strvStartsWith to tr_strv_starts_with

* chore: rename tr_strvEndsWith to tr_strv_ends_with

* chore: rename tr_strvSep to tr_strv_sep

* chore: rename tr_strvStrip to tr_strv_strip

* chore: rename tr_strvToBuf to tr_strv_to_buf

* refactor: rename tr_saveFile() to tr_file_save()

rename tr_loadFile() to tr_file_read()

rename tr_moveFile() to tr_file_move()

* refactor: rename tr_parseNum() to tr_num_parse()

refactor: rename tr_parseNumRange() to tr_num_parse_range()

* chore: group related functions together in header
2023-06-30 09:49:58 -05:00
SweetPPro 635268854b
refactor: view-based TorrentTableView in macOS client (#5147)
Converted TorrentTableView from older style cell based table to more modern view based
* floating group rows are now used for an improved groups experience
* individual group indicators are hidden when _Use Groups_ is selected to minimize visual clutter (see #3328 )
* removed negated `usesAlternatingRowBackgroundColors` flag for minimal view in Controller.mm (personal preference - easy to restore)
2023-06-27 14:40:44 -05:00
Emir SARI 38ea020eca
i18n: Apply i18n to percentage values (#5568)
Some languages use different percentage formatting style other than
100% (e.g. Turkish and French, %100-100 %). This commit enables the use
of NSNumberFormatter(), in order to provide localized formatting.
2023-06-21 23:21:24 -05:00
Gary Elshaw 0fd7989b18
fix: restore png files that were corrupted in recent "compression" script 2023-06-18 14:11:56 -05:00
Cœur bd9d110d45
fix 'setNeedsDisplay' is deprecated: first deprecated in macOS 10.14 (#5633) 2023-06-18 13:32:34 -05:00
Cœur 76166d8fa7
refactor: replace NSMutableDictionary with constant attributes (#5221) 2023-06-12 11:03:22 -05:00
Charles Kerr 0ef58c2a20
chore: improve lossless compression of png files (#5586) 2023-06-05 17:03:11 -05:00
Cœur 61679e1adc
Support localized punctuation for "Port:" (#4452)
* Support localized punctuation for "Port:"

* Code review: adopting "Port: %@"

* updating other locales for "Port" -> "Port: %@"
2023-05-29 09:43:43 -04:00
Charles Kerr c61d8b7cf7
refactor: rename tr_tracker_view.host to .host_and_port for clarity (#5508) 2023-05-08 20:28:10 -05:00
Charles Kerr 0d3b321bac
refactor: use snake_case for libtransmission class methods (#5497) 2023-05-05 23:11:05 -05:00
Gary Elshaw 52c45eb85f
fix: some typos in macos source code comments (#5475) 2023-04-29 14:00:35 -05:00
Zhenfu Shi f34b1e624c
fix: wrong case in AppKit.h (#5456) 2023-04-27 13:39:52 -05:00
Mike Gelfand e8fcb025a0
fix: use user-preferred locale (#5444)
* Use user-preferred locale

Previous fix adding `L` format specifier was correct but only fixed half
of the problem, as C++ locale is set up to be "C" by default. GTK client
used to call `setlocale(LC_ALL, "")` to set up user-preferred locale
which only affected C functions and `std::locale` (used by libfmt) was
unaware of those changes.

Apply the fix to all the binaries since they're all doing some sort of
output to the user and calling libtransmission helpers, as well as using
libfmt directly.

* Improve libtransmission's json-test

Set the locale C++ way to avoid any sort of inconsistencies, and also
restore it to the old one once finished testing.

* Improve transmission-show test runner script

Quote outputs to avoid CMake error about `message()` being called with
no arguments. Capture stderr to the same output file. Fallback to `git
diff` if `diff` wasn't found. A few other minor changes.
2023-04-27 09:10:33 -05:00
Charles Kerr 9d2507c7e3
refactor: snake_case in libtransmission class methods (#5428) 2023-04-22 20:25:55 -05:00
Cœur e2c3eb50a6
quicklook: alternate row background color (#5216) 2023-04-15 17:07:03 -05:00
Dmitry Serov ca392ba5da
refactor: use idiomatic enum names & types in objc (#5090) 2023-04-15 16:33:43 -05:00
Cœur 6156d90917
build: use RECOMMENDED_MACOSX_DEPLOYMENT_TARGET (#5282) 2023-04-14 15:02:52 -05:00
Cœur febc5b7ef4
feat: add "Show Toolbar" toggle (#4419) 2023-04-14 13:09:12 -05:00
Cœur 1851b80d8c
feat: add sort-by-ETA for macOS (#4169) 2023-04-14 12:19:06 -05:00
Cœur 91717fe91d
fix: potential NSString leak in tr_strv_convert_utf8() 2023-04-11 17:36:22 -05:00
Cœur 1b81883e66
fix: crash on launch from tapping on a notification (#5280) 2023-03-24 08:04:30 -05:00
Cœur d64ec27106
fix: "Unrecognized colorspace number -1" (#5219) 2023-03-13 23:41:38 -05:00
Cœur 066d655493
fix: precision in stringForSpeedCompact (#5213) 2023-03-13 14:43:39 -05:00
Cœur b1f6fbc05d
fix: change badge font size, position and precision (#5184) 2023-03-10 01:05:21 -06:00
Mike Gelfand 8cdb6ec798
chore: sync translations (#5182) 2023-03-08 23:29:22 -06:00
Cœur 60ef92ee99
fix: hardcode BadgeView font size (#5168) 2023-03-07 21:16:06 -06:00
Cœur d2c8ff3683
feat: add up/down arrows to badge (#5095) 2023-03-05 17:20:48 -06:00
Cœur 264437d6d9
Complete copyWithZone for TorrentCell (#5079) 2023-03-02 08:31:23 -06:00
Cœur 03a23cf797
fix: max 4 significant digits for speed (#5100) 2023-03-01 11:33:17 -06:00
Dzmitry Neviadomski 4430f72a72
feat: Use updated minimal NSColorWell style for Groups. (#5016)
* feat: Use updated minimal NSColorWell style for Groups.

Only on macOS Ventura (13.0+), as AppKit changes were introduced here.

Somewhat fixes #5011

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
2023-02-26 19:11:36 -06:00
Cœur dcc1d14fc1
Set fPiecesControl segmentDistribution to fillProportionally (#5066) 2023-02-26 09:42:26 -06:00
Cœur 8a374a3310
fix: macOS watchdirs (#5058) 2023-02-25 22:50:30 -06:00
Dzmitry Neviadomski 7e353588dc
fix: Add tooltip explaining why auto adding for magnets is unavailable. (#5035)
Fixes #5034

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
2023-02-24 16:44:55 -06:00
Dzmitry Neviadomski 394defe98e
fix: Adjust sizes to fix Call Script control cutoff. (#5018)
Fixes #5010

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
2023-02-24 12:24:34 -06:00
Dzmitry Neviadomski c43ed9a8a1
fix: Update Inspector window frame to fix AutoLayout warning. (#5021)
Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
2023-02-23 19:06:47 -06:00
Dzmitry Neviadomski 026ab5ffc6
fix: Use bounds for relative NSPopover positioning. (#5019)
Fixes #5013

Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
2023-02-23 18:40:29 -06:00
SweetPPro 3ae8107ca9
fix: highlight the selected group in Group View (#4896) 2023-02-15 13:01:24 -06:00
SweetPPro 4243a33e01
fix an issue where the pieces view can jump around (#4884) 2023-02-14 16:31:19 -06:00
Charles Kerr f551b4adbf
fix: magnet links are always paused when added (#4856) 2023-02-13 12:33:33 -06:00
Gary Elshaw 94e1668e1c
style: dock badge colours follow Apple a11y colour guide (#4813) 2023-02-12 00:05:22 -06:00
Julien 4b8cfa2e57
chore: update copyrights to 2023 (#4834) 2023-02-11 14:49:42 -06:00
SweetPPro 7ad3dfa8e5
fix: added padding to widgets in macOS client to avoid being hidden below scroller (#4788) 2023-02-10 15:33:28 -06:00
Cœur 3fb1f8bcd7
fix: CoreAutoLayout hang during runCustomizationPalette on macOS 13.2 (#4709) 2023-02-06 12:54:38 -06:00
SweetPPro 1e988c9ce4
fix magnet link start logic (#4528) 2023-02-02 00:19:20 -06:00
Dzmitry Neviadomski e0cc4f50e0
fix: Add precheck for tar archive test. (#4705)
Recently we discovered we do not properly handle broken tar archives.

The problem is running tar (in linting mode) on invalid archive and
piping stdout to NSPipe introduces a hang as NSPipe cannot process
such huge data amounts.

Fixing this problem by adding a precheck with tar (listing mode) with
piping stdout to /dev/null.

Fixes: #4702
2023-02-01 15:05:32 -06:00
Cœur 41b8044b88
fix ToolbarItemIdentifierPauseResumeAll (regression from #3974) (#4692) 2023-01-31 11:04:41 -06:00
Cœur 18277a6dd0
#warning in header file should start with capital letter (#4689) 2023-01-30 08:20:38 -06:00
Charles Kerr f01191edbc
fix: ensure prefs window is centered the first time shown (#4659) 2023-01-25 14:30:06 -06:00
Charles Kerr 74c8248237
refactor: remove vector from pieces view (#4587) 2023-01-17 09:10:23 -06:00
Gary Elshaw 6a3ead4c5d
Add files via upload (#4557) 2023-01-16 23:55:52 -06:00