14370e5353
Fix a number of other style inconsistencies met along the way (part 2)
2017-05-01 18:47:49 +03:00
e1d53855f4
Avoid declaring multiple variables on the same line
2017-05-01 18:46:41 +03:00
a762c770f2
Make conditional expressions explicitly boolean
2017-04-30 19:26:01 +03:00
4f9d9ad92b
Code style change leftovers
...
For some reason, GTK client wasn't fully processed. All the rest of changes
are mostly in comments.
2017-04-21 10:40:57 +03:00
dadffa2c0f
Align type qualifiers to the right (code style)
...
This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped
together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading
types right-to-left, e.g. "constant pointer to constant T" vs. "constant
pointer to T which is constant".
2017-04-20 19:53:20 +03:00
d7930984ef
Adjust uncrustify config, reformat all but Mac client
...
There're places where manual intervention is still required as uncrustify
is not ideal (unfortunately), but at least one may rely on it to do the
right thing most of the time (e.g. when sending in a patch).
The style itself is quite different from what we had before but making it
uniform across all the codebase is the key. I also hope that it'll make the
code more readable (YMMV) and less sensitive to further changes.
2017-04-20 10:01:22 +03:00
2248d3670f
Get rid of $Id$ SVN keywords in source files
2016-09-02 23:10:15 +03:00
02cff80c2d
Copyedit the license's revised text: (1) remove unnecessary repitition use of the word 'license' from the top of the header and source files (2) add the standard 'we hope it's useful, but no warranty' clause to COPYING (3) make explicit that linking OpenSSL is allowed (see https://people.gnome.org/~markmc/openssl-and-the-gpl.html for background) (4) sync the Qt and GTK+ clients' license popups with COPYING's revised text
2014-01-21 03:10:30 +00:00
4b9626bb83
Licensing changes:
...
1. add the option the code to be used under GPLv2 or GPLv3; previously only GPLv2 was allowed
2. add the "proxy option" as described in GPLv3 so we can add future licenses without having to bulk-edit everything again :)
3. remove the awkward "exception for MIT code in Mac client" clause; it was unnecessary and confusing.
2014-01-19 01:09:44 +00:00
4904b923fb
(trunk) restore copyright year as suggested in email by rms
2014-01-18 20:56:57 +00:00
63fb848f3e
(gtk) in makemeta-ui.c, don't rely on g_clear_pointer()... our GLIB_MINIMUM is 2.32.0
2013-01-05 00:19:11 +00:00
10b96f0f12
(gtk) copyediting: update several files to be closer to the gtk+ indentation style.
2013-01-04 19:45:39 +00:00
2a52ebab20
(gtk) copyediting: use G_SOURCE_REMOVE and G_SOURCE_CONTINUE where appropriate
2013-01-04 16:36:52 +00:00
3d38723ad9
Follow more common whitespace style conventions in the C code (libtransmission, daemon, utils, cli, gtk).
2012-12-05 17:29:46 +00:00
cdd71c6427
(trunk gtk) #4970 remove deprecated GTK+ API calls, raise GTK+ dependency to 3.2
2012-07-14 19:26:55 +00:00
631a77287d
(trunk gtk) replace the three single dots '...' with the unicode symbol U+2026 (…).
2012-02-03 15:51:36 +00:00
f9388714b7
(trunk gtk) add portability wrappers for gtk_hbox_new() and gtk_vbox_new(), which are deprecated now in GTK+ 3.2
2011-10-11 04:11:08 +00:00
b5de483362
(trunk gtk) the row and col arguments passed to gtk_table_attach() should be guint. we were using "int" in several places.
2011-08-13 21:08:53 +00:00
6d1869c33b
remove the gtr_timeout_add_seconds() portability wrapper around gdk_threads_add_timeout_seconds(); it's unnecessary now that the minimum gtk version's been bumped.
2011-08-08 17:06:46 +00:00
270126820a
(trunk gtk) bump the glib2 requirement from 2.8 to 2.26 s.t. transmission-gtk can use glib's GDBus module and drop the glib-dbus library dependency
2011-08-07 16:42:38 +00:00
45bdc18210
(trunk gtk) use ngettext() instead of gtr_dngettext() to address https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/760761
2011-05-02 17:58:27 +00:00
bd88521332
(trunk) yet more "#include" tweaks
2011-03-25 15:03:42 +00:00
375694eda9
(trunk) copyediting: remove some unneeded #includes, and annotate some needed ones
2011-03-24 21:49:42 +00:00
c7006ed8b3
(trunk gtk) remove the TrTorrent GObject subclass.
2011-03-03 01:59:25 +00:00
aea77bc9f6
(trunk gtk) make "gtr_label_set_text" public and use it everywhere instead of gtk_label_set_text()
...
Some of the refresh events to the main window's torrent list are caused by main window relayout caused by the toolbar's GtkLabels recalculating their size after being updated once per second. To prevent relayout in some trivial cases, I'm replacing the gtk_label_set_text() calls with gtr_label_set_text() because the latter doesn't update the label widget if the old and new text strings are the same.
There are other changes that can handle more important cases -- I'll test those out next.
2011-01-21 16:32:27 +00:00
879a2afcbd
Update the copyright year in the source code comments.
...
The Berne Convention says that the copyright year is moot, so instead of adding another year to each file as in previous years, I've removed the year altogether from the source code comments in libtransmission, gtk, qt, utils, daemon, and cli.
Juliusz's copyright notice in tr-dht and Johannes' copyright notice in tr-lpd have been left alone; it didn't seem appropriate to modify them.
2011-01-19 13:48:47 +00:00
e5bb3205a1
(trunk) Join the 21st century and use only 1 space at the end sentences. This commit is nearly as important as the semi-annual ones that remove trailing spaces from the ends of lines of code... :)
2010-12-27 19:18:17 +00:00
0a160aec49
(trunk gtk) GTK_DIALOG_NO_SEPARATOR will be removed in GTK 3, so don't use it.
2010-12-25 02:05:15 +00:00
6627aade08
(trunk gtk) don't use the GSEAL'ed variable vbox GtkDialog directly... use gtk_dialog_get_content_area() instead
2010-12-22 03:12:47 +00:00
5eafe91824
(trunk gtk) general cleanup to make function's naming scheme and API more consistent. This is only a fraction of what the GTK+ client's codebase needs, unfortunately.
2010-12-21 19:20:58 +00:00
27a1b2dc33
(trunk) one of the periodic, banal "remove-trailing-spaces from lines of source code" cleanup commits
2010-12-12 16:43:19 +00:00
e934290980
(trunk gtk) portability: use g_dngettext() instead of ngettext()
2010-08-06 14:38:54 +00:00
49e23db0fe
(trunk gtk) more dead code removal
2010-08-02 22:45:38 +00:00
36064b8120
(trunk gtk) rewrite the main window's drag-and-drop handler s.t. it's GTK+ 3 compliant
2010-08-02 22:31:31 +00:00
5182600179
(trunk) add drag-and-drop support to the "create new torrent" dialogs in the Qt and GTK+ clients
2010-08-02 20:55:11 +00:00
b5e93da8f4
(trunk T) #3404 "crash when creating a .torrent containing empty content" -- fixed
2010-07-07 22:50:18 +00:00
7a129d9cf9
(trunk gtk) #3033 "wrong calls to GtkFileChooserDialog" -- fixed in trunk for 2.00
2010-03-09 22:00:43 +00:00
28726d031d
(trunk gtk) make it easier to change the periodic refresh intervals at the code level
2010-02-01 04:54:10 +00:00
704261527c
(trunk gtk) oops, that last commit should've used g_free() instead of tr_free()
2010-01-20 14:27:48 +00:00
d31e93163d
(trunk gtk) fix a couple of small memory leaks in the gtk+ client, found by valgrind
2010-01-20 14:16:44 +00:00
182cbb8b90
(trunk) one of the less-interesting commits in a while: remove trailing spaces from lines
2010-01-05 23:47:50 +00:00
5c26afdb52
happy new year!
2010-01-04 21:00:47 +00:00
4e252aa106
(trunk) fix warnings found by the clang static analyzer, reported & patched by wereHamster
2009-12-07 04:06:14 +00:00
78ead8c3dd
(trunk) update the copyright notices
2009-12-05 02:19:24 +00:00
c5835f711e
(trunk, gtk) remove an unwanted console debug message
2009-10-05 21:48:50 +00:00
6a1e524aac
(trunk gtk) fix the editing of tracker URLs in the GTK+ client
2009-10-04 02:32:38 +00:00
f5fa70141c
(trunk gtk) gah, I'm so stupid. I go to the trouble of writing a backwards-compatable wrapper for gdk_threads_add_timeout_seconds(), but then when rewriting the "create torrent" ui and I need to use a timer to update the progressbar, what do I use... my fingers have "g_timeout_add" programmed into them.
2009-09-20 14:13:02 +00:00
3ca7f7f63c
(trunk gtk) rewrite the 'create torrent' dialog
2009-09-17 01:28:45 +00:00
cb79214854
(trunk) remove trailing spaces
2009-08-10 20:04:08 +00:00
bd5c9cf3a8
(trunk gtk) #2251 : gtk client should use GDK-safe versions of g_idle_add() and g_timeout_add*()
2009-06-29 17:22:35 +00:00
Mike Gelfand