1e16912ae4
refactor: new `tr_variant` API in `transmission-remote` and other cleanup ( #6798 )
...
* refactor: remove `Arguments`
* refactor: replace pointer args with lvalue reference
* refactor: use `uint16_t` for port number
* chore: housekeeping
* refactor: replace `char*` with `std::string_view`
* refactor: simplify argument parsing code
* refactor: use new `tr_variant` API in remote
* chore: rename function to snake_case
* chore: move `break` statements in switches outside of compound statements
* chore: use `std::string` literals
* refactor: extract tor start/stop to `MODE_TORRENT_START_STOP`
* refactor: extract tor actions to `MODE_TORRENT_ACTION`
* chore: iwyu
* fix: msvc build failure
* chore: misc cleanup
* fix: dereference optional
* chore: misc cleanup
* ui: fix minor formatting errors
* fix: remove redundant if branches for response string
* code review: remove `o` prefix for optionals
* code review: add condition clause
* code review: check `left_until_done` instead
* fix: unchecked nullptr
* code review: don't reassign method name
* code review: revert accidentally renaming `addIdArg` to `get_id_arg`
* code review: use `TR_ASSERT` instead of `assert`
* refactor: fix static auto constexpr naming
* code review: assert array size
* code review: assert that `arguments` key exists
2024-08-17 20:04:49 +01:00
88d280be8f
feat(remote): implement idle seeding limits ( #2947 )
2024-05-27 15:08:33 -05:00
edddf9d80e
fix: torrent details speed info unit ( #6845 )
2024-05-25 16:43:38 -05:00
3f6969217c
chore: remove FMT_STRING macros ( #6497 )
2024-01-06 14:05:18 -06:00
646883174b
chore: fix misc-use-anonymous-namespace warnings from clang-tidy ( #6488 )
2024-01-04 23:12:51 -06:00
7573a98bb4
ui: unify percent done format in `transmission-remote` ( #6447 )
...
* ui: unify percent done display format in `remote`
* fix: adjust field width for the new format
2023-12-29 14:55:06 -06:00
69f4b6cb2e
fix: `sequentialDownload` support in `transmission-remote` ( #6454 )
2023-12-29 13:25:55 -06:00
0ef34878de
refactor: remove tr_str_is_empty() ( #6432 )
...
* refactor: do not u se tr_str_is_empty() in tr_torrentSetLocation()
* refactor: do not use tr_str_is_empty() in remote.cc
* refactor: do not use tr_str_is_empty() in subprocess-win32
* refactor: remove tr_str_is_empty()
2023-12-24 12:01:49 -06:00
07d96036d9
refactor: Values pt. 6 - remove deprecated API ( #6250 )
2023-11-14 17:23:51 -06:00
2e32789193
refactor: add libtransmission::Values ( #6215 )
2023-11-09 08:39:06 -06:00
8ac323d5d6
chore: removed copyright timespans in headers ( #4850 )
2023-11-01 16:11:11 -05:00
bbc3ce039f
refactor: remove quark support from tr_variant ( #6159 )
2023-10-24 14:49:23 -04:00
32a62d85ea
refactor: more tr_variant API ( #6057 )
2023-10-02 16:18:35 -05:00
fbfbfac3ae
fix: minor coverity warnings ( #5916 )
...
* fix: unchecked return value from tr_variantDictFindInt()
coverity 1541113
* fix: unchecked return value from tr_variantDictFindBool()
coverity 1541112
* fix: copy-instead-of-move in tr_strlower()
coverity 1541092
* fix: use auto& instead of auto in test
coverity 1541084
* fix: logically dead code
coverity 1541065
* fix: copy-instead-of-move in tr_announcer_impl::addTorrent()
coverity 1541062
* fix: unchecked return value of tr_variantDictFindInt()
coverity 1541061
* fix: copy-instead-of-move in FilterBar::Impl::tracker_filter_model_update()
coverity 1541058
* fix: copy-instead-of-move in gtr_window_on_close()
* fix: silence invalid resource leak warning
coverity 1520595
* fix: unchecked return value from setsockopt()
coverity 1518345
* fix: dereference after null check (FORWARD_NULL)
coverity 1517816
2023-08-21 21:59:47 -05:00
59c638c63d
refactor: replace tr_variant::is_*() with tr_variant::holds_alternative() ( #5930 )
2023-08-21 16:16:54 -05:00
5837603b6f
refactor: make tr_variant follow RAII ( #5923 )
2023-08-20 23:15:23 -05:00
a4d205612a
refactor: add tr_variant_serde ( #5903 )
2023-08-17 11:02:45 -05:00
5ec4ca550e
chore: iwyu ( #5746 )
2023-07-08 10:24:03 -05:00
8b96e2616a
transmission-remote: for '-l', implement default sorting by addedDate ( #5608 )
2023-07-07 14:56:49 -05:00
2211086338
fix: conform to libcurl requirements to avoid memory leak ( #5702 )
2023-07-05 22:05:03 -05:00
8183d7fddf
refactor: utils naming ( #5696 )
...
* chore: rename tr_strvContains to tr_strv_contains
* chore: rename tr_strvStartsWith to tr_strv_starts_with
* chore: rename tr_strvEndsWith to tr_strv_ends_with
* chore: rename tr_strvSep to tr_strv_sep
* chore: rename tr_strvStrip to tr_strv_strip
* chore: rename tr_strvToBuf to tr_strv_to_buf
* refactor: rename tr_saveFile() to tr_file_save()
rename tr_loadFile() to tr_file_read()
rename tr_moveFile() to tr_file_move()
* refactor: rename tr_parseNum() to tr_num_parse()
refactor: rename tr_parseNumRange() to tr_num_parse_range()
* chore: group related functions together in header
2023-06-30 09:49:58 -05:00
ce66e5c442
iwyu: remove, add std headers where used ( #5694 )
...
* chore: remove unused #include <array>
* chore: remove unused #include <chrono>
* chore: remove unused #include <set>
* chore: remove unused #include <algorithm>
* chore: remove unused #include "interned-string.h"
* chore: remove unused #include <list>
* chore: remove unused #include <optional>
* chore: iwyu <cstddef>
* chore: iwyu <ctime>
* chore: remove unused #include <cerrno>
* chore: remove unused #include <deque>
* chore: remove unused #include <vector>
* chore: remove unused #include <memory>
* chore: remove unused #include <unordered_set>
* chore: remove unused #include <array>
* chore: remove unused #include <mutex>
* chore: remove unused #include <functional>
* chore: remove unused #include <cmath>
2023-06-29 23:51:55 -05:00
d0b0810457
fix: add 'years' and 'Infinity' to ETA in transmission-remote ( #5584 )
2023-06-20 12:29:57 -05:00
c379cd727f
fix: transmission-remote only list every other label ( fixes #5571 ) ( #5572 )
2023-06-11 20:19:54 -05:00
60c68afdde
Revert "fix: some labels not displayed in transmission-remote ( #5600 )"
...
This reverts commit ebd5080a93
2023-06-11 11:25:35 -05:00
ebd5080a93
fix: some labels not displayed in transmission-remote ( #5600 )
...
Fixes #5571 .
2023-06-10 19:01:32 -05:00
e8fcb025a0
fix: use user-preferred locale ( #5444 )
...
* Use user-preferred locale
Previous fix adding `L` format specifier was correct but only fixed half
of the problem, as C++ locale is set up to be "C" by default. GTK client
used to call `setlocale(LC_ALL, "")` to set up user-preferred locale
which only affected C functions and `std::locale` (used by libfmt) was
unaware of those changes.
Apply the fix to all the binaries since they're all doing some sort of
output to the user and calling libtransmission helpers, as well as using
libfmt directly.
* Improve libtransmission's json-test
Set the locale C++ way to avoid any sort of inconsistencies, and also
restore it to the old one once finished testing.
* Improve transmission-show test runner script
Quote outputs to avoid CMake error about `message()` being called with
no arguments. Capture stderr to the same output file. Fallback to `git
diff` if `diff` wasn't found. A few other minor changes.
2023-04-27 09:10:33 -05:00
7d86d67bc7
chore: prefer fmt/core.h over fmt/format.h ( #5404 )
2023-04-16 15:34:19 -05:00
ebfba686b0
feat: sequential download ( #4795 )
2023-04-14 11:47:54 -05:00
652c4666dc
fix: 'downloaded' field ( #5265 )
2023-03-20 16:42:32 -05:00
3aeefec203
chore: remove unused header includes ( #5227 )
2023-03-14 18:36:15 -05:00
5ada8c46d4
fix: transmission-remote warning when adding magnet link ( #5088 )
2023-02-27 15:58:38 -06:00
4b8cfa2e57
chore: update copyrights to 2023 ( #4834 )
2023-02-11 14:49:42 -06:00
977a190646
fix: msvc warnings ( #4651 )
...
* fix: C4189 local variable is initialized but not referenced
* fix: C4706 assignment within conditional expression
* fix: C4018 signed/unsigned mismatch
* fix: warning C4996 High-DPI scaling is always enabled.
* fix: C4996: QApplication::fontMetrics() is deprecated
eed5514eaf
2023-01-23 19:24:52 -06:00
980cc6f922
fix(remote): Crash caused by typo when displaying tracker info ( #4633 )
2023-01-22 08:50:46 -06:00
7eef715105
fix(remote): Don't draw "Yes" or "No" as an integer ( #4624 )
2023-01-21 12:42:53 -06:00
a46bcf7381
fix(remote): Fix tr_strltime to output days correctly ( #4506 )
2023-01-01 13:01:48 -06:00
5fd0aff818
Automatically (re)order include directives (GTK client) ( #4475 )
...
* Automatically (re)order include directives (GTK client)
Include our headers first to ease IWYU enforcement.
* Fix includes missing from headers (GTK client)
* Fix build on Mac after includes reordering
2022-12-26 21:13:21 +00:00
59335eac03
fix: sonarcloud cpp:S6004 ( #4270 )
...
reduce scope of variables by using if-based initializer
2022-11-28 21:03:28 -06:00
d8327949ac
refactor: do not reimplement tr_getRatio() in transmission-remote ( #4257 )
2022-11-27 16:58:58 -06:00
22c14c9266
fix: sonarcloud warnings ( #4180 )
2022-11-15 10:25:12 -06:00
12e564096b
fix: "Implicit conversion loses integer precision" warnings ( #3960 )
2022-10-25 11:14:42 -05:00
9313e42866
remote: improve and document the rename command ( #3973 )
2022-10-19 00:02:23 +01:00
4ed61a0a75
fixup! refactor: remove TR_PRIsv macros ( #3842 ) ( #3992 )
...
fix: invalid format string passed to fmt::print
2022-10-18 14:57:11 -05:00
f1f55cc3df
Sync translations ( #3939 )
...
* Sync translations with code
* Sync translations with Transifex
* Remove Mac menu title that isn't displayed and shouldn't be translated
* Add context to logging level strings in GTK client
* Use "µTP" consistently in code
* Use ellipsis instead of three docs in Qt client strings
* Close HTML tags in blocklist-related strings
* Remove trailing space from a translatable string in Qt client
* Add missing plural forms for English strings in Qt client
* Fix spelling: metaInfo -> metainfo
2022-10-11 18:39:41 +03:00
f8fdc6a828
remote: fix invalid format string ( #3909 )
2022-10-08 22:10:47 +03:00
d82090658f
refactor: remove TR_PRIsv macros ( #3842 )
...
* refactor: remove TR_PRIsv from transmission-show
* refactor: remove TR_PRIsv from transmission-edit
* refactor: remove TR_PRIsv from transmission-remote
* refactor: remove TR_PRIsv from log.cc
* refactor: remove TR_PRIsv macro
* chore: remove FMT_STRING macro in transmission-edit
* refactor: use __android_log_write()
2022-09-23 14:36:37 -05:00
fe9aba702e
utils/remote: add option to dump RPC response as JSON ( #3819 )
...
Co-authored-by: LaserEyess <LaserEyess@users.noreply.github.com>
2022-09-14 17:20:40 -07:00
c532728c42
refactor: remove TR_N_ELEMENTS macro ( #3674 )
...
* refactor: use std::array for keys in transmission-remote
* refactor: use std::array for wide_module_path in platform.cc
* refactor: use std::array for value in tr_env_get_int()
* refactor: use std::array for SysStoreNames in web.cc
* chore: remove unused macro TR_N_ELEMENTS
2022-08-18 21:31:53 -05:00
c4537e6d80
Add a new flag in remote for connecting through a Unix domain socket. ( #3552 )
2022-08-18 20:09:55 -05:00
Yat Ho