19e52d8b9a
chore: sonarcloud warnings 2 ( #1496 )
...
* fix "merge nested if" sonarcloud warnings
* fix explicit constructor warnings in qt client
2020-11-01 15:47:57 -06:00
b7a8bd45b7
Reformat affected code after recent changes
2020-08-18 20:31:06 +03:00
ff8d0dbf3b
Switch from UNUSED macro to TR_UNUSED macro
...
Since there is no way to mark parameters as [potentially] unused in
standard C and when using MSVC compiler, use the widely accepted
cast-to-void approach instead.
2020-08-18 14:19:55 +03:00
10cdd7f790
Use explicit boolean conversions
2019-07-14 16:25:07 +03:00
82df3a87f4
Update to Uncrustify 0.68.1
...
Tweak a few rules in the process. Now all code in cli, daemon, gtk,
libtransmission, qt, and utils is properly formatted with no manual
intervention.
2019-02-15 09:21:48 +03:00
a762c770f2
Make conditional expressions explicitly boolean
2017-04-30 19:26:01 +03:00
dadffa2c0f
Align type qualifiers to the right (code style)
...
This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped
together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading
types right-to-left, e.g. "constant pointer to constant T" vs. "constant
pointer to T which is constant".
2017-04-20 19:53:20 +03:00
d7930984ef
Adjust uncrustify config, reformat all but Mac client
...
There're places where manual intervention is still required as uncrustify
is not ideal (unfortunately), but at least one may rely on it to do the
right thing most of the time (e.g. when sending in a patch).
The style itself is quite different from what we had before but making it
uniform across all the codebase is the key. I also hope that it'll make the
code more readable (YMMV) and less sensitive to further changes.
2017-04-20 10:01:22 +03:00
2248d3670f
Get rid of $Id$ SVN keywords in source files
2016-09-02 23:10:15 +03:00
c955c04d8f
Explicitly compare result of str(n)cmp/memcmp to signify that it's not boolean
2016-03-13 22:11:01 +00:00
f89fab72f9
Remove unused session tag
2015-10-18 18:39:14 +00:00
c1b10abe0f
Use UTF-8 for console I/O on Windows
2015-04-21 10:07:57 +00:00
3b129a72d8
#5908 : Check for `tr_loadFile` return value instead of `errno` in `tr_variantFromFile`
...
Seems like there could be a defect in uClibc making errno not
thread-local. Don't rely on errno value but check function return value
instead which is a better failure indicator.
Return errors from `tr_loadFile` and `tr_variantFromFile` via tr_error.
Fix `tr_sessionLoadSettings` to not fail on Windows if settings.json
does not exist.
2015-04-11 10:51:59 +00:00
870041d92d
(trunk) #4160 : mike.dld patch: 4160-08-args.patch
2014-09-21 18:06:28 +00:00
d9d66e3e42
(trunk, libt) #4160 - the slow slog to catch trunk up to mike.dld's 4160 diff continues. This step applies 4160-04b-dir.patch, which replaces native file operations with the tr_sys_dir_*() portability wrappers added in the previous commit.
2014-09-21 17:55:39 +00:00
0323639e57
(trunk, libT) #4160 'foreign character support' -- merge mike.dld's 4160-02b-path.patch, which updates the codebase to use the new tr_sys_path_*() portability wrappers introduced in 4160-02a
2014-07-08 00:08:43 +00:00
0e01879974
Use built-in _WIN32 macro instead of WIN32
2014-07-04 00:00:07 +00:00
027e3f3066
(trunk, libT) #4682 'Add return id from duplicate torrent torrent-add rpc' -- added.
2013-05-22 20:35:38 +00:00
96786b7fa1
(trunk) update web.h's API s.t. there's an explicit function to use when downloading webseed content.
2013-04-13 20:25:28 +00:00
69f3e31230
(libT) change the API signature for tr_torrentVerify() s.t. client code can be notified when the verify is finished
2013-01-31 21:58:25 +00:00
1676310330
(transmission-cli) fix global search-and-replace damage wreaked upon the --help text, reported by Elbandi
2013-01-22 19:02:13 +00:00
4de4322b2c
(cli) #5212 'cli fails when download directory doesn't exist' -- fix 2.76 regression introduced in r13764 (trunk) / r13772 (branches/2.7x)
2013-01-16 00:21:02 +00:00
2e7c9e15bd
(cli) #5212 'cli fails when download directory doesn't exist' -- fixed.
2013-01-04 23:58:52 +00:00
c1559f3cc4
(trunk, libT) first drop of the tr_quark patch.
2012-12-22 20:35:19 +00:00
e96ed247fe
refactor libtransmission's tr_benc class as tr_variant.
2012-12-14 04:34:42 +00:00
3d38723ad9
Follow more common whitespace style conventions in the C code (libtransmission, daemon, utils, cli, gtk).
2012-12-05 17:29:46 +00:00
42f085fa4b
#5033 cli prints wrong status on console
2012-09-07 02:45:49 +00:00
fbc7f3dc3c
(trunk) use base-10 units for network bandwidth (ie, speed) and disk sizes.
...
It looks like the Mac client is already doing this and it's clearly the trend in other apps as well. Even apt-get is using kB/s, ferchrissake... :)
Flame away.
2012-02-03 21:21:52 +00:00
b2d65db45f
(trunk) remove trailing spaces from code lines ;)
2012-02-03 16:44:07 +00:00
7f8d802405
(trunk cli) #4595 "transmission-cli does not stop on SIGINT" -- fixed with patch from dyogene
2011-10-26 17:44:28 +00:00
ff8a086fe3
(trunk cli) #4585 "use full path when download directory is specified" -- fix with patch by dyogene
2011-10-25 16:07:56 +00:00
375694eda9
(trunk) copyediting: remove some unneeded #includes, and annotate some needed ones
2011-03-24 21:49:42 +00:00
b4d36aeb54
(trunk) #4138 "use stdbool.h instead of tr_bool" -- done.
2011-03-22 15:19:54 +00:00
fee784f1d8
(trunk) #4081 "Add 'cookieString' argument 'torrent-add' method in RPC" -- done.
2011-03-15 04:22:47 +00:00
b67ca00945
(trunk) #4071 Upload and Download rates swapped in transmission-cli
2011-02-28 02:45:17 +00:00
716a3c90c2
(trunk) #4032 "Better error detection / reporting in http announces" -- added to trunk.
...
This patch adds two new flags to the callback function -- did_connect and did_timeout -- that are calculated inside of web.c using information from libcurl. This allows the announcer to detect timeouts more accurately and also to distinguish between unresponsive peers (which get the preexisting "Tracker did not respond" error message) and unconnectable peers (which get a new error message, "Could not connect to tracker").
2011-02-17 02:26:24 +00:00
879a2afcbd
Update the copyright year in the source code comments.
...
The Berne Convention says that the copyright year is moot, so instead of adding another year to each file as in previous years, I've removed the year altogether from the source code comments in libtransmission, gtk, qt, utils, daemon, and cli.
Juliusz's copyright notice in tr-dht and Johannes' copyright notice in tr-lpd have been left alone; it didn't seem appropriate to modify them.
2011-01-19 13:48:47 +00:00
4a05b4c3e6
(trunk cli) #3269 "transmission-cli 2.10 segfaults" -- r11330 wasn't the right fix. Thanks to Longinus00 for the proofreading.
2010-10-18 03:11:51 +00:00
14f8029fd1
(trunk cli) #3629 "transmission-cli 2.10 segfaults on startup" -- fixed. solution by Longinus00
2010-10-17 17:40:40 +00:00
c01c18b46b
(trunk) make --version/-V behave the same in the other apps too
2010-08-09 00:18:26 +00:00
70be70d85f
nice job.
2010-08-05 13:24:46 +00:00
807c5de5e2
(trunk cli) #3487 "transmissioncli should warn about about unrecognized commands" -- fixed.
2010-08-04 23:18:39 +00:00
e6bafdf26b
(trunk) #3045 "size units" -- sync the default units in all the apps s.t. they're consistent with each other
2010-07-28 00:31:11 +00:00
610061f79a
(trunk T) #3045 "units" -- modify the formatter functions based on feedback from BMW
2010-07-06 20:25:54 +00:00
6e5af03d78
(trunk) #3045 "speed units" -- change the public API of libtransmission based on feedback from livings
2010-07-04 06:07:21 +00:00
cdcc4705aa
(trunk) #3045 "make libtransmission's API byte-oriented instead of KiB-oriented." -- implemented. This is a largish commit and will break the mac build for a little while.
2010-07-03 00:25:22 +00:00
eda211e5ce
(trunk) #2983 : add command-line utilities for creating .torrent files, for editing passkeys, for adding/removing trackers, etc.
2010-06-16 14:27:24 +00:00
3ff784ad28
(trunk) #1796 "run script after torrent completion" -- (1) add to transmission-remote. (2) remove cli's custom script handler and have it use libtransmission instead.
2010-05-11 13:36:21 +00:00
06f044680a
(trunk) #3174 "Use IEC standard units (KiB, MiB, GiB) instead of (KB, MB, GB)" -- implemented for gtk, qt, daemon, cli, and web client
2010-04-28 01:26:46 +00:00
7feaa9faae
(trunk) #2938 -- sync gtk, mac, and cli clients with previous commit
2010-02-20 15:57:34 +00:00
Charles Kerr