Mike Gelfand
5b29fe1556
Ensure include guard is the first non-comment line
2017-11-14 23:21:28 +03:00
Mike Gelfand
5f7bc801c8
Make use of new checking capabilities in unit tests
2017-05-30 20:56:12 +03:00
Mike Gelfand
437904198e
Transform `check_uint_eq` into generic `check_uint` (libtest)
2017-05-30 17:51:50 +03:00
Mike Gelfand
9c3c6f11e0
Transform `check_int_eq` into generic `check_int` (libtest)
2017-05-30 17:51:50 +03:00
Mike Gelfand
14c30119d4
Transform `check_str_eq` into generic `check_str` (libtest)
2017-05-30 17:51:46 +03:00
Mike Gelfand
341b778099
Continue running other test-cases even if one fails (libtest)
2017-05-30 17:44:51 +03:00
Mike Gelfand
7a238e7c65
Rename `check_streq` to `check_str_eq` to be in line with other macros (libtest)
2017-05-30 17:44:42 +03:00
Mike Gelfand
295d3359b2
Little bastards keep popping up here and there :(
2017-05-23 22:17:17 +03:00
Mike Gelfand
1e3d20422a
Reduce for loop variables scope
2017-05-14 01:38:31 +03:00
Mike Gelfand
e1d53855f4
Avoid declaring multiple variables on the same line
2017-05-01 18:46:41 +03:00
Mike Gelfand
a762c770f2
Make conditional expressions explicitly boolean
2017-04-30 19:26:01 +03:00
Mike Gelfand
4f9d9ad92b
Code style change leftovers
...
For some reason, GTK client wasn't fully processed. All the rest of changes
are mostly in comments.
2017-04-21 10:40:57 +03:00
Mike Gelfand
dadffa2c0f
Align type qualifiers to the right (code style)
...
This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped
together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading
types right-to-left, e.g. "constant pointer to constant T" vs. "constant
pointer to T which is constant".
2017-04-20 19:53:20 +03:00
Mike Gelfand
d7930984ef
Adjust uncrustify config, reformat all but Mac client
...
There're places where manual intervention is still required as uncrustify
is not ideal (unfortunately), but at least one may rely on it to do the
right thing most of the time (e.g. when sending in a patch).
The style itself is quite different from what we had before but making it
uniform across all the codebase is the key. I also hope that it'll make the
code more readable (YMMV) and less sensitive to further changes.
2017-04-20 10:01:22 +03:00
Mike Gelfand
2248d3670f
Get rid of $Id$ SVN keywords in source files
2016-09-02 23:10:15 +03:00
Jordan Lee
5fbd24fda5
fix a handful of minor compiler warnings, mostly in the unit tests, eg field width shortening or implicit signed/unsigned conversions
2016-03-29 03:04:54 +00:00
Mike Gelfand
15c9e5c126
Get rid of some more warnings
2015-12-28 23:53:55 +00:00
Mike Gelfand
5de8bbe6d8
Cut internal macro names to have equal number of underscores on each side (take two)
2015-05-04 20:06:05 +00:00
Jordan Lee
02cff80c2d
Copyedit the license's revised text: (1) remove unnecessary repitition use of the word 'license' from the top of the header and source files (2) add the standard 'we hope it's useful, but no warranty' clause to COPYING (3) make explicit that linking OpenSSL is allowed (see https://people.gnome.org/~markmc/openssl-and-the-gpl.html for background) (4) sync the Qt and GTK+ clients' license popups with COPYING's revised text
2014-01-21 03:10:30 +00:00
Jordan Lee
15d11de5f4
add svn:keywords on source files that were missing them
2014-01-19 01:29:38 +00:00
Jordan Lee
4b9626bb83
Licensing changes:
...
1. add the option the code to be used under GPLv2 or GPLv3; previously only GPLv2 was allowed
2. add the "proxy option" as described in GPLv3 so we can add future licenses without having to bulk-edit everything again :)
3. remove the awkward "exception for MIT code in Mac client" clause; it was unnecessary and confusing.
2014-01-19 01:09:44 +00:00
Jordan Lee
3819360ca0
(libT) when unable to run locale-specific json tests, give a hint in the terminal about how to remedy that
2013-02-01 06:11:41 +00:00
Jordan Lee
eb4b2d609a
(libT) #5249 'error parsing json in some locales': fix the bug; the new locale unit tests in json-test pass now
2013-01-24 16:33:49 +00:00
Jordan Lee
887850a636
(libT) #5249 'error parsing json in some locales': add unit tests to test for this bug.
2013-01-24 16:04:09 +00:00
Jordan Lee
c1559f3cc4
(trunk, libT) first drop of the tr_quark patch.
2012-12-22 20:35:19 +00:00
Jordan Lee
e96ed247fe
refactor libtransmission's tr_benc class as tr_variant.
2012-12-14 04:34:42 +00:00
Jordan Lee
3d38723ad9
Follow more common whitespace style conventions in the C code (libtransmission, daemon, utils, cli, gtk).
2012-12-05 17:29:46 +00:00
Jordan Lee
dffc6343ae
(trunk, libT) #5150 'improper escaping of dirnames with new json' -- added new regression test, currently failing, to trigger this bug
2012-11-27 23:21:13 +00:00
Jordan Lee
d2ef01bc1a
add more unit tests for the json-benc glue code
2012-11-11 04:20:15 +00:00
Jordan Lee
1dafe0beef
more unit test cleanup
2012-10-14 23:38:52 +00:00
Jordan Lee
17beba3502
retrofit some of the tests to use the more expressive test API
2012-10-14 18:56:37 +00:00
Jordan Lee
74c56f27b0
(trunk, libtransmission) #4934 "Create a test harness and use it for current tests" -- patch by gvdl
2012-08-18 16:07:05 +00:00
Charles Kerr
c808cd624a
(trunk libT) #3134 "transmission-remote apparently can't handle apostrophes in errorStrings" -- I'm unable to reproduce the reported behavior, but that's no reason to let a new unit test go to waste... committing the unit test anyway
2010-04-15 19:27:47 +00:00
Charles Kerr
9238fb0299
(trunk) #2131 : clean up benc read/write API
2009-06-02 01:48:48 +00:00
Charles Kerr
7f85090587
(trunk) add a "source" argument to tr_jsonParse() so that if there's an error we can log the filename, or that it came from rpc, etc.
2009-06-01 18:57:37 +00:00
Charles Kerr
1c3f3acbca
(trunk) add an option to the JSON generator to disable the human-readable indentations. Keep indenting the data files such as settings.json, but don't indent the messages used for RPC. This cuts the cost of deflate()ing those RPC messages by about 80%...
2009-05-16 05:51:52 +00:00
Charles Kerr
dce5997f29
(trunk) fix another new bencode bug. add some more unit tests for benc.
2009-04-05 23:16:45 +00:00
Charles Kerr
b5a6f8a013
(trunk libT) #1845 : if settings.json is empty, T crashes with "Assertion: tr_bencIsDict( source ) failed"
2009-02-18 16:47:27 +00:00
Charles Kerr
13c22f88ff
(trunk libT) fix some code that the newly-added gcc warnings didn't like
2009-01-23 18:44:15 +00:00
Charles Kerr
1bcc998694
(trunk libT) fix a couple of minor memory leaks
2008-12-30 22:19:52 +00:00
Charles Kerr
6bec82d0a6
(trunk libT) have tr_bencSaveAsJSON() use an evbuffer
2008-12-30 22:07:39 +00:00
Charles Kerr
cc89872dd4
run libT, cli, daemon, gtk through the source-code formatter "uncrustify" as promised/threatened
2008-09-23 19:11:04 +00:00
Charles Kerr
dcecf09d96
bencode cleanup: remove unused functions and unnecessary #includes
2008-08-21 14:57:59 +00:00
Charles Kerr
6e23743c33
(libT) do proper JSON escaping
2008-08-19 23:11:35 +00:00
Charles Kerr
812b6a1218
roll back the last two diffs (r6582 and r6583) in favor of a simpler/cleaner/better fix
2008-08-18 03:44:09 +00:00
Charles Kerr
0396d9691f
(libT) better handling of non-ascii characters when parsing JSON files
2008-08-18 03:10:59 +00:00
Charles Kerr
51aff87443
lots of C correctness tweaks suggested by sparse/cgcc
2008-08-11 19:05:02 +00:00
Charles Kerr
2c79888a93
RPC/IPC redesign
2008-05-18 16:44:30 +00:00
Charles Kerr
e607f26893
add json-to-benc parser
2008-05-11 22:42:53 +00:00