2e46bad22d
refactor: constify the inout module ( #6328 )
...
* refactor: move tr_preallocation_mode info tr_open_files
* refactor: remove unnecessary error nullptr check
* refactor: use snake_case for private method names in inout.cc
* refactor: extract-method get_fd() from read_or_write_bytes()
* refactor: make function args const where possible
* refactor: simplify read_or_write_bytes()
* refactor: make buflen a uint64_t in read_or_write_piece()
* refactor: move tr_torrentStop() logic from read_or_write_piece() to tr_ioWrite()
* refactor: make tr_ioFoo() functions take a const torrent
* refactor: make tr_cache::close_torrent_files() take a tor_id instead of a torrent
2023-12-02 14:16:36 -06:00
ed4fad9b18
feat: support creating 0 byte files ( #6232 )
2023-11-28 10:51:13 -06:00
64d9d57363
chore: fix minor clang-tidy warnings ( #6275 )
2023-11-21 09:02:03 -06:00
40fe56f33e
refactor: thread-safe `lru-cache` and `tr_open_files` ( #6230 )
2023-11-11 21:09:23 -06:00
a2e97234d2
refactor: optionally include 0 byte files when computing file offset ( #6229 )
2023-11-09 16:49:18 -06:00
a952a0731f
refactor: remove the tr_error** idiom ( #6198 )
...
* refactor: remove the tr_error** idiom
* fix: tr_error::message() is only constexpr in c++20 and up
* chore: silence a couple of g++-12 Wshadow warnings
2023-11-04 11:39:41 -05:00
a2b547fb50
chore: iwyu ( #6201 )
2023-11-03 12:03:26 -05:00
8ac323d5d6
chore: removed copyright timespans in headers ( #4850 )
2023-11-01 16:11:11 -05:00
db96771c80
refactor: add tr_torrent::Error helper class ( #6077 )
2023-10-08 21:33:34 -05:00
5ec4ca550e
chore: iwyu ( #5746 )
2023-07-08 10:24:03 -05:00
6a2a4c3032
perf: move log strings instead of cloning them ( #5726 )
2023-07-04 14:03:45 -05:00
4c282bdbb4
fix: recent build warnings and errors ( #5711 )
...
* fix: use std::empty instead of isEmpty()
* fix: fix trivially assignable warning hicpp-move-const-arg
* fix: fix clang-diagnostic-unused-but-set-variable warning
* fix: fix readability-braces-around-statements warning
2023-07-01 10:22:15 -05:00
0d3b321bac
refactor: use snake_case for libtransmission class methods ( #5497 )
2023-05-05 23:11:05 -05:00
9d2507c7e3
refactor: snake_case in libtransmission class methods ( #5428 )
2023-04-22 20:25:55 -05:00
68e965aa28
perf: pass by reference ( #4876 )
2023-04-14 17:06:26 -05:00
d72cb67cfb
chore: include directory name in libtransmission #includes ( #5308 )
2023-04-14 14:33:23 -05:00
6224b60728
fix: wrong error message when writing to incomplete dir ( #5217 )
2023-03-13 16:20:39 -05:00
9d91d1e969
fix: checksum of pieces that don't align on block boundaries ( #4880 )
2023-02-13 20:57:20 -06:00
4b8cfa2e57
chore: update copyrights to 2023 ( #4834 )
2023-02-11 14:49:42 -06:00
7367d465b5
style: use the new paragraph comment style everywhere ( #4634 )
2023-01-22 13:21:30 -06:00
d26db72d7e
Fix "Implicit conversion loses integer precision" ( #4194 )
2022-11-21 10:19:45 -06:00
12e564096b
fix: "Implicit conversion loses integer precision" warnings ( #3960 )
2022-10-25 11:14:42 -05:00
33afdc32f9
fix: "Nullptr with nonzero offset" ( #3941 )
2022-10-11 16:52:13 -05:00
291d2fcb9b
fix: when renaming local data files fails, set the torrent error and pause the torrent ( #3717 )
2022-08-26 18:57:44 -05:00
785119f2c2
perf: sonarcloud warnings about temp objects ( #3686 )
...
* perf: sonarcloud warnings about unnecessary temporary objects
* refactor: rename tr_sha1_digest_t::final() as finish()
2022-08-20 15:57:32 -05:00
a4c1a23fae
refactor: make tr_session.is_incomplete_file_naming_enabled_ private ( #3642 )
...
* refactor: make tr_session.is_incomplete_file_naming_enabled_ private
* refactor: make session callback setters constexpr
* refactor: make tr_session.is_port_random_ private
* refactor: make tr_session.desired_ratio_ private
* refactor: make tr_session.is_pex_enabled_ private
* refactor: make tr_session.is_idle_limited_ private
2022-08-14 19:33:28 -05:00
5c8695025a
refactor: make tr_session.is_closing_private_ ( #3637 )
2022-08-13 20:04:36 -05:00
dab81c1af6
fix: readability-inconsistent-declaration-parameter-name warnings in libtransmission ( #3572 )
2022-08-03 01:15:37 -05:00
18e2a04f88
refactor: make sha1, sha256 RAII safe ( #3556 )
2022-07-31 15:58:14 -05:00
9c7fcf85cf
refactor: tr_stats ( #3542 )
2022-07-28 18:56:40 -05:00
25fdb5805c
refactor: use tr_torrent_id_t ( #3314 )
...
* refactor: use semantic type tr_torrent_type_t in libtransmission
* refactor: use semantic type tr_torrent_type_t in gtk client
* refactor: use semantic type tr_torrent_type_t in qt client
2022-06-17 10:43:04 -05:00
d34bd0b4d6
refactor: modernize cache.cc ( #3108 )
...
* Modernize cache.cc: Convert tr_cache to a class
* Modernize cache.cc: Replaced ptrArray with vector
* refactor: Cache now takes a tr_torrents reference
* refactor: add Key type to Cache
* refactor: avoid std::back_inserter
* refactor: add Cache::flushOldest()
2022-06-11 19:46:30 -05:00
cd592d0091
fix: clang-15 warnings ( #3257 )
2022-06-11 14:35:08 -05:00
256b436023
fix: clang 15 warnings ( #3172 )
...
* fix modernize-macro-to-enum libtransmission warnings
* fix readability-simplify-boolean-expr libtransmission warnings
* fix bugprone-unchecked-optional-access libtransmission warnings
2022-06-01 11:56:59 -05:00
4cc952f0ca
fixup! fixup! fix: ensure all bytes read / written to file ( #2682 ) ( #2780 ) ( #3035 )
...
fix spurious tr_error being set when reading up to eof
Fix error introduced in the previous fixup :P
2022-04-30 18:43:32 -05:00
5dbe1f4669
refactor: replace tr_fdlimit with tr_open_files ( #3016 )
2022-04-28 21:35:47 -05:00
32facb50d7
refactor: prefer tr_pathbuf over tr_strvPath() ( #2966 )
2022-04-22 11:35:56 -05:00
2866638e1b
refactor: add tr_torrent_files::move() and remove() ( #2919 )
2022-04-15 18:39:04 -05:00
9f9f60f1e3
refactor: tr_block_info ( #2908 )
2022-04-13 20:22:59 -05:00
4a65956cc9
refactor: extract some file management into tr_files class ( #2906 )
2022-04-12 10:00:02 -05:00
e4461c48d7
refactor: prefer FMT_STRING ( #2845 )
...
* use FMT_STRING in libtr client on non-i18n strings
This gives compile-time safety checks.
2022-03-30 14:59:13 -05:00
f4afb76695
perf: replace tr_torrentFindFile2() with tr_torrrent.findFile() ( #2839 )
2022-03-30 13:25:41 -05:00
71ad42b1ef
refactor: make err arg optional in tr_sys_* funcs ( #2827 )
2022-03-27 12:37:29 -05:00
0be920156b
refactor: fmt part 3 ( #2773 )
2022-03-15 19:51:36 -05:00
a942c67199
refactor: use fmt ( #2758 )
...
* deps: use fmt (8.1.1 tag) to build log strings
Co-authored-by: Mike Gelfand <mikedld@mikedld.com>
2022-03-13 23:43:35 -05:00
d2f8e1d4e0
refactor: set logging levels ( #2755 )
2022-03-11 15:09:22 -06:00
13ad2b58dc
refactor: always use a blocksize of 16 KB ( #2694 )
...
Fixes #99 .
2022-02-23 14:25:06 -06:00
e6e1e1d220
fix: ensure all bytes read / written to file ( #2682 )
2022-02-22 11:21:24 -06:00
78ad90a4c5
refactor: use tr_block_info::Location in inout.cc ( #2658 )
2022-02-19 10:07:08 -06:00
87d9f9b00a
refactor: use tr_block_info::Location in cache.cc ( #2652 )
2022-02-19 07:45:19 -06:00
Charles Kerr