Jordan Lee
01461d0b4a
(trunk gtk) more heap pruning:
...
querying gconf2 each time the curl callack function is called is expensive, so query it once -- then again later, if the proxy settings change -- and remember the values in a local struct.
2011-04-13 06:18:30 +00:00
Jordan Lee
4a15899499
(trunk gtk) transmission-gtk requires GTK+ 2.8 or higher, so remove the `#if GTK_CHECK_VERSION(2,8,0)' checks because we already know the answer.
2011-04-12 11:13:41 +00:00
Jordan Lee
eb06d81fb9
(trunk) fix a handful of small memory leaks that valgrind found.
2011-03-25 17:42:47 +00:00
Jordan Lee
b0379147d9
(trunk gtk) get everything except torrent-cell-renderer building under GTK+ 3.0.5
2011-03-25 07:32:30 +00:00
Jordan Lee
375694eda9
(trunk) copyediting: remove some unneeded #includes, and annotate some needed ones
2011-03-24 21:49:42 +00:00
Jordan Lee
5417711cd4
(trunk gtk) remove function gtr_strcmp0, which is redundant due to tr_strcmp0
2011-03-24 18:20:47 +00:00
Jordan Lee
b4d36aeb54
(trunk) #4138 "use stdbool.h instead of tr_bool" -- done.
2011-03-22 15:19:54 +00:00
Jordan Lee
9c7caec13f
(trunk gtk) minor copyediting for clarity/readability
2011-03-04 14:31:23 +00:00
Jordan Lee
9283ef2ebb
(trunk gtk) #4080 "Toggling speed limit mode from the web interface doesn't affect GUI" -- fixed.
2011-03-04 05:58:32 +00:00
Jordan Lee
dcc070c86c
(trunk gtk) some tr-core cleanup
...
Variable and function name cleanup; regrouping related functions together, etc.
2011-03-03 07:17:57 +00:00
Jordan Lee
c7006ed8b3
(trunk gtk) remove the TrTorrent GObject subclass.
2011-03-03 01:59:25 +00:00
Jordan Lee
3f1b060241
(trunk T) add preliminary enable/disable toggles in daemon, gtk, and qt clients. 'preliminary' because this may be widened to a tri-state of inabled, disabled, and incoming only
2011-02-18 00:33:29 +00:00
Jordan Lee
1fabb9b9ea
(trunk) #3675 "Not all .part files are removed" -- handle trashing files via RPC.
...
When libtransmission gets a "remove torrent" request from RPC, it tries to delegate the work. This is because the GTK+ and Mac clients don't want torrents disappearing in a different thread and causing possible thread issues. So the GTK+ and Mac clients get notification about this via libtransmission's RPC callback and remove the torrents themselves. Unfortunately, that notification doesn't include information about whether or not to delete local data.
This commit adds that information to the RPC callback so that the Mac and GTK+ clients will know whether or not to trash the local files when a third-party RPC client requests that at torrent and its files be deleted.
2011-02-06 17:30:46 +00:00
Jordan Lee
c90ddfa1c3
(trunk libT) #3980 "segfault when adding many torrents remotely" -- possible fix.
...
gtk/main.c's onRPCChanged() is called from inside the libtransmission thread, yet it still made GTK+ calls to modify the GTK+ client's tr-core object when a torrent was added. This caused a race condition inside of the GTK+ internals. onRPCChanged() already knows to delegate work back to the GTK+ thread when a torrent is removed via RPC. This commit uses the same kind of mechanism to delegate work back to the GTK+ thread when a torrent is added via RPC.
2011-02-05 05:03:00 +00:00
Jordan Lee
3f2e8b7b02
(trunk gtk) #3817 "use the OS' proxy support" -- fix memory leaks in the GTK+ implementation.
...
r11512 introduced a handful of memory leaks by not freeing the GConfValue objects after use.
2011-02-01 17:46:42 +00:00
Jordan Lee
88df1b15ee
(trunk gtk) #3970 "tr_core_update() wastes CPU cycles by toggling the sort mode" -- fix minor r11799 regression.
...
Clearing the model on shutdown generated a warning because it used the wrong cast. Rather than fixing the cast, add tr_core_clear() for symmetry with tr_core_load().
2011-02-01 01:45:41 +00:00
Jordan Lee
1127463a1c
#3042 "Open torrent dialog focus not restored" -- fixed. patch by ijuxda.
...
the callback function for GtkWidget's focus-in-event should return TRUE to stop other handlers from being invoked for the event or FALSE to propagate the event further.
2011-01-25 04:26:10 +00:00
Jordan Lee
3b28138c71
(trunk) #3926 : use "Open Torrent" instead of "Add Torrent" in GTK+ and Qt clients -- change the filename from add-dialog.[ch] to open-dialog.[ch]. whoooo
2011-01-20 19:57:42 +00:00
Jordan Lee
131afcc3a4
(trunk) #3926 : use "Open Torrent" instead of "Add Torrent" in GTK+ and Qt clients -- text changed.
2011-01-20 19:48:13 +00:00
Jordan Lee
879a2afcbd
Update the copyright year in the source code comments.
...
The Berne Convention says that the copyright year is moot, so instead of adding another year to each file as in previous years, I've removed the year altogether from the source code comments in libtransmission, gtk, qt, utils, daemon, and cli.
Juliusz's copyright notice in tr-dht and Johannes' copyright notice in tr-lpd have been left alone; it didn't seem appropriate to modify them.
2011-01-19 13:48:47 +00:00
Jordan Lee
a433b0c4cc
#3686 "add rpc command to cleanly shutdown daemon" -- added for libT, tr-daemon, tr-gtk, tr-remote, and the rpc spec
2011-01-15 18:12:45 +00:00
Jordan Lee
c7cc8301db
(trunk) update credits
2011-01-03 05:58:58 +00:00
Charles Kerr
e5bb3205a1
(trunk) Join the 21st century and use only 1 space at the end sentences. This commit is nearly as important as the semi-annual ones that remove trailing spaces from the ends of lines of code... :)
2010-12-27 19:18:17 +00:00
Charles Kerr
f5b13c46dc
(trunk gtk) #3847 "GTK+ 3 transition: Use accessor functions instead direct access" -- don't directly access GtkCellRenderer.xpad, GtkCellRenderer.ypad, or GtkWidget.window.
2010-12-24 09:04:52 +00:00
Charles Kerr
ba2e18b0c3
(trunk, gtk) some code cleanup: (1) details dialog handler, (2) selection change handler
2010-12-23 22:31:28 +00:00
Charles Kerr
a297cd328a
(trunk gtk) add GTR_UNICODE_BULLET
2010-12-22 07:00:25 +00:00
Charles Kerr
057487d18e
(trunk gtk) more gtr_ naming cleanup
2010-12-22 06:25:30 +00:00
Charles Kerr
b86e1e1056
(trunk gtk) kill "pref_flag_t" in a burlap sack and throw it off the cliff into the freezing water below
2010-12-22 06:11:49 +00:00
Charles Kerr
6627aade08
(trunk gtk) don't use the GSEAL'ed variable vbox GtkDialog directly... use gtk_dialog_get_content_area() instead
2010-12-22 03:12:47 +00:00
Charles Kerr
1b7a8cdc68
(trunk gtk) fix r11563 bug that stopped showing the Torrent Options dialog
2010-12-22 03:06:06 +00:00
Charles Kerr
5eafe91824
(trunk gtk) general cleanup to make function's naming scheme and API more consistent. This is only a fraction of what the GTK+ client's codebase needs, unfortunately.
2010-12-21 19:20:58 +00:00
Charles Kerr
3a6cf6afc9
(trunk gtk_) #3837 "Dangling pointer after quit cancel" -- fixed.
2010-12-19 09:50:28 +00:00
Charles Kerr
5bf05ab31b
(trunk gtk) #3838 "Unselected active torrents not counted for quit check" -- fixed.
2010-12-19 09:33:02 +00:00
Charles Kerr
465a2e7c90
(trunk) extremely minor manpage copyediting
2010-12-12 16:36:46 +00:00
Charles Kerr
0e9247b84a
(trunk) #3817 "use the OS' proxy support" -- implemented for libtransmission, transmission-gtk
2010-12-10 18:51:05 +00:00
Charles Kerr
92620b72b0
(trunk) #3697 "make blocklist URL configurable" -- implemented in GTK+, Qt, and RPC
2010-10-31 17:16:12 +00:00
Charles Kerr
22c622a92f
(trunk) #3688 "remove proxy support" -- remove from libtransmission
2010-10-31 17:05:31 +00:00
Charles Kerr
d365c40958
(trunk gtk) #3644 "About Dialog appear with main window" -- handle another special case. Fix confirmed by kovalev
2010-10-18 22:18:15 +00:00
Charles Kerr
ac588c4835
(trunk gtk) #3644 'about dialog keeps reappearing' - fixed.
2010-10-18 11:43:30 +00:00
Charles Kerr
d908c7fc9e
(trunk gtk) #3635 "transient children of the main window aren't hidden when the main window is hidden to the notification area" -- fixed in trunk for 2.11.
2010-10-15 23:23:57 +00:00
Charles Kerr
f3ab57e082
(trunk gtk) #3589 "drag-and-dropping a magnet link onto the GTK+ client doesn't work" -- fixed.
2010-10-01 13:50:23 +00:00
Charles Kerr
d57ba48775
(trunk) #3577 -- replace gear icon for GTK+, Qt clients
2010-09-24 15:22:53 +00:00
Charles Kerr
7f6cfb3c24
(trunk gtk) #3554 "turtle speed button doesn't update when toggled via RPC" -- fix minor bug introduced in r11215
2010-09-24 14:21:08 +00:00
Charles Kerr
60132d3781
(trunk gtk) #3543 'wrong link in the about window' -- separate gtr_open_file() from gtr_open_uri()
2010-09-22 16:44:38 +00:00
Charles Kerr
efd71c05ab
(trunk gtk) #3554 "alternate speed (turtle) button does not update when toggled via RPC" -- fixed.
2010-09-17 02:27:03 +00:00
Charles Kerr
2d5ac5b150
(trunk libT) add a string length argument to tr_urlIsValid()
2010-08-21 12:47:28 +00:00
Charles Kerr
c01c18b46b
(trunk) make --version/-V behave the same in the other apps too
2010-08-09 00:18:26 +00:00
Charles Kerr
e934290980
(trunk gtk) portability: use g_dngettext() instead of ngettext()
2010-08-06 14:38:54 +00:00
Charles Kerr
0e03b5e287
(trunk) run all our PNG files through pngout < http://advsys.net/ken/util/pngout.htm > to shrink 'em down
2010-08-06 07:51:24 +00:00
Charles Kerr
70be70d85f
nice job.
2010-08-05 13:24:46 +00:00