Commit Graph

1444 Commits

Author SHA1 Message Date
Jordan Lee eb06d81fb9 (trunk) fix a handful of small memory leaks that valgrind found. 2011-03-25 17:42:47 +00:00
Jordan Lee bd88521332 (trunk) yet more "#include" tweaks 2011-03-25 15:03:42 +00:00
Jordan Lee b0379147d9 (trunk gtk) get everything except torrent-cell-renderer building under GTK+ 3.0.5 2011-03-25 07:32:30 +00:00
Jordan Lee 4a1a4ebcc0 (trunk gtk) gtk_open_uri(): use gtk_show_uri() as the default implementation for GTK+ > 2.14.0.
gtk_show_uri() was added in 2.14.0
2011-03-25 06:40:46 +00:00
Jordan Lee 375694eda9 (trunk) copyediting: remove some unneeded #includes, and annotate some needed ones 2011-03-24 21:49:42 +00:00
Jordan Lee 433da8df9a (trunk gtk) gtr_compare_double() is only used in one place, so make it a private function there instead of leaving it public in utils.h 2011-03-24 18:32:05 +00:00
Jordan Lee a891136602 (trunk gtk) gtr_localtime() is only used in one place, so make it a private function there instead of leaving it public in util.h 2011-03-24 18:29:07 +00:00
Jordan Lee e46d0a72ba (trunk gtk) gtr_cell_renderer_get_padding() is only used in one place, so make it a private function there instead of leaving it public in util.h 2011-03-24 18:24:21 +00:00
Jordan Lee 5417711cd4 (trunk gtk) remove function gtr_strcmp0, which is redundant due to tr_strcmp0 2011-03-24 18:20:47 +00:00
Jordan Lee 0a1df687bb still trying to make hudson happy 2011-03-22 16:07:49 +00:00
Jordan Lee 034a65aaf1 (trunk gtk) revert r12201 to try & make hudson happy 2011-03-22 16:03:10 +00:00
Jordan Lee b4d36aeb54 (trunk) #4138 "use stdbool.h instead of tr_bool" -- done. 2011-03-22 15:19:54 +00:00
Jordan Lee e259d0abbe (trunk gtk) tweak Makefile.am 2011-03-21 20:45:50 +00:00
Jordan Lee 2544b4b228 (trunk gtk) dbus tweaks in Makefile.am based on examples from http://live.gnome.org/DBusGlibBindings .
1. tweak the way dbus-binding-tool is invoked... use --output=$@ $^

2. add the file generated by dbus-binding-tool to BUILT_SOURCES
2011-03-21 20:26:15 +00:00
Jordan Lee 374ed10f3b (trunk) it's bad form to #include so many system headers in libtransmission/utils.h... 2011-03-16 18:04:23 +00:00
Jordan Lee 591b95286f Show whether a tracker is http or udp. Without that context, it could be confusing to see the same tracker twice in a tier 2011-03-15 17:03:09 +00:00
Jordan Lee fee784f1d8 (trunk) #4081 "Add 'cookieString' argument 'torrent-add' method in RPC" -- done. 2011-03-15 04:22:47 +00:00
Jordan Lee 018585d3b0 (trunk gtk) fix condition that could crash in some cases when right-clicking in the file list menu. 2011-03-13 16:45:32 +00:00
Jordan Lee 55381159f6 (trunk gtk) #4075 "add x-scheme-handler/magnet to desktop file" -- fixed.
Thanks to ampelbein for the patch :)
2011-03-13 15:56:12 +00:00
Jordan Lee afe6d42ac1 (trunk gtk) when a tracker is manually added to a torrent, check the tracker's validity with tr_urlIsValidTracker() 2011-03-13 07:49:32 +00:00
Jordan Lee e45a6dabc9 (trunk gtk) fix 2.22+ time display regression in the GTK+ client. 2011-03-11 04:10:28 +00:00
Jordan Lee 9145bce9cd (trunk gtk) fix time display oops 2011-03-06 15:06:38 +00:00
Jordan Lee 05c39eaa3e add a missing icon 2011-03-06 05:41:41 +00:00
Jordan Lee 411b0bbd1a (trunk gtk) #4088 "Transmission needs 256x256 icon too" -- added large Tango icon by Andreas Nilsson. Thanks Andreas!
This larger icon is apparently needed for GNOME 3.
2011-03-05 19:15:37 +00:00
Jordan Lee 0a62f69f1c (trunk gtk) copyediting. 2011-03-04 15:49:51 +00:00
Jordan Lee ae20b67f16 (trunk gtk) remove unused code: gtr_warn_if_fail() 2011-03-04 15:21:00 +00:00
Jordan Lee 9c7caec13f (trunk gtk) minor copyediting for clarity/readability 2011-03-04 14:31:23 +00:00
Jordan Lee 9283ef2ebb (trunk gtk) #4080 "Toggling speed limit mode from the web interface doesn't affect GUI" -- fixed. 2011-03-04 05:58:32 +00:00
Jordan Lee c6dd0b0ed4 (trunk libT) fix tr_ctorFree() crash reported by Rolcol 2011-03-04 04:45:34 +00:00
Jordan Lee dcc070c86c (trunk gtk) some tr-core cleanup
Variable and function name cleanup; regrouping related functions together, etc.
2011-03-03 07:17:57 +00:00
Jordan Lee c7006ed8b3 (trunk gtk) remove the TrTorrent GObject subclass. 2011-03-03 01:59:25 +00:00
Jordan Lee 0a8535d9a5 (trunk gtk) #4040 "Show the torrent name in the Peers Tab's tooltips" -- done. 2011-02-19 13:04:09 +00:00
Jordan Lee db8b83854e (trunk gtk) Don't display uTP checkbox in non-uTP builds.
Tweak to r11976 s.t. the "Edit GNOME Proxy Settings" button doesn't get grouped in the "Peer Limits" section when uTP is disabled. :)
2011-02-19 09:30:06 +00:00
Jordan Lee 88a61d3b62 (trunk gtk) #4038 "Prefs dialog's blocklist section allows the 'update' button to be clicked when no blocklist is specified" -- fixed. 2011-02-19 09:02:39 +00:00
Juliusz Chroboczek ee86584263 Don't display uTP checkbox in non-uTP builds (gtk).
Reported by Rolcol.
2011-02-18 22:22:02 +00:00
Jordan Lee 3f1b060241 (trunk T) add preliminary enable/disable toggles in daemon, gtk, and qt clients. 'preliminary' because this may be widened to a tri-state of inabled, disabled, and incoming only 2011-02-18 00:33:29 +00:00
Jordan Lee 7df7d34f6d automake/autoconf; #includes in libtransmission 2011-02-18 00:32:19 +00:00
Juliusz Chroboczek bd0ea13701 (gtk) Add tooltip for uTP peers. 2011-02-18 00:24:33 +00:00
Jordan Lee 716a3c90c2 (trunk) #4032 "Better error detection / reporting in http announces" -- added to trunk.
This patch adds two new flags to the callback function -- did_connect and did_timeout -- that are calculated inside of web.c using information from libcurl. This allows the announcer to detect timeouts more accurately and also to distinguish between unresponsive peers (which get the preexisting "Tracker did not respond" error message) and unconnectable peers (which get a new error message, "Could not connect to tracker").
2011-02-17 02:26:24 +00:00
Jordan Lee dede299e04 (trunk gtk) #3866 "popup menu for file list manipulation" -- remove unused code in file-list.c
This code can be pulled back out of svn and readded if it's needed in the future.
2011-02-15 15:21:22 +00:00
Jordan Lee 72f9ab91fa (trunk) make tr_torrentName() a public function.
This has been a private function in libtransmission for awhile now but it makes more sense as a public function.
2011-02-15 15:18:51 +00:00
Jordan Lee 59e8348b15 (trunk gtk) #4012 "Cannot set individual seeding time in GTK+ client" -- fixed.
The code in gtk/details.c was still using the pre-release RPC key "seedInactiveLimit" when it should have been using "seedIdleLimit" instead.
2011-02-12 23:54:33 +00:00
Jordan Lee 62b732708a (trunk gtk) msgwin.c: silence compiler warning "warning: ‘pinned_to_new’ may be used uninitialized in this function" 2011-02-09 05:10:29 +00:00
Jordan Lee 24b9dc7dc2 (trunk gtk) #3866 "Popup menu for file list manipulation" -- removing from the 2.20 milestone
Looking over the 2.20 tickets, this one keeps sticking out. A popup menu may be useful if the "delete files" ticket is accepted in 2.30, but for this release (2.20) it doesn't really add anything new. One lesson from the 2.1x cycle was that features are a harder to remove than to add. So I'm going to hold off on adding this feature until it has a clear raison d'être.
2011-02-06 18:50:35 +00:00
Jordan Lee 1fabb9b9ea (trunk) #3675 "Not all .part files are removed" -- handle trashing files via RPC.
When libtransmission gets a "remove torrent" request from RPC, it tries to delegate the work. This is because the GTK+ and Mac clients don't want torrents disappearing in a different thread and causing possible thread issues. So the GTK+ and Mac clients get notification about this via libtransmission's RPC callback and remove the torrents themselves. Unfortunately, that notification doesn't include information about whether or not to delete local data.

This commit adds that information to the RPC callback so that the Mac and GTK+ clients will know whether or not to trash the local files when a third-party RPC client requests that at torrent and its files be deleted.
2011-02-06 17:30:46 +00:00
Jordan Lee c90ddfa1c3 (trunk libT) #3980 "segfault when adding many torrents remotely" -- possible fix.
gtk/main.c's onRPCChanged() is called from inside the libtransmission thread, yet it still made GTK+ calls to modify the GTK+ client's tr-core object when a torrent was added. This caused a race condition inside of the GTK+ internals. onRPCChanged() already knows to delegate work back to the GTK+ thread when a torrent is removed via RPC. This commit uses the same kind of mechanism to delegate work back to the GTK+ thread when a torrent is added via RPC.
2011-02-05 05:03:00 +00:00
Jordan Lee a358858a99 (trunk libT) #3978 "Message window column sorting fails and triggers gtk warnings" -- fixed.
I'm not sure why sorting was in there in the first place; it doesn't make sense in a message log.. Disabling sorting fixes this bug.
2011-02-04 06:12:55 +00:00
Jordan Lee 7a5f87a207 (trunk gtk) #3972 "Verify progress changes not displaying" -- fixed.
make sure to call gtk_list_store_set() on rows matching torrents whose tr_stat.recheckProgress value has changed, triggering a row change event that causes the verify progress change to be displayed.
2011-02-02 02:45:20 +00:00
Jordan Lee 3f2e8b7b02 (trunk gtk) #3817 "use the OS' proxy support" -- fix memory leaks in the GTK+ implementation.
r11512 introduced a handful of memory leaks by not freeing the GConfValue objects after use.
2011-02-01 17:46:42 +00:00
Jordan Lee 705b27d128 (trunk gtk) #3876 "Give filesize its own column in the Files tree" -- fix minor memory leak introduced by r11642
r11642 allocated a pango font description with pango_font_description_copy() but never freed it.
2011-02-01 17:42:50 +00:00