a762c770f2
Make conditional expressions explicitly boolean
2017-04-30 19:26:01 +03:00
4f9d9ad92b
Code style change leftovers
...
For some reason, GTK client wasn't fully processed. All the rest of changes
are mostly in comments.
2017-04-21 10:40:57 +03:00
dadffa2c0f
Align type qualifiers to the right (code style)
...
This way all the qualifiers (`const`, `volatile`, `mutable`) are grouped
together, e.g. `T const* const x` vs. `const T* const x`. Also helps reading
types right-to-left, e.g. "constant pointer to constant T" vs. "constant
pointer to T which is constant".
2017-04-20 19:53:20 +03:00
d7930984ef
Adjust uncrustify config, reformat all but Mac client
...
There're places where manual intervention is still required as uncrustify
is not ideal (unfortunately), but at least one may rely on it to do the
right thing most of the time (e.g. when sending in a patch).
The style itself is quite different from what we had before but making it
uniform across all the codebase is the key. I also hope that it'll make the
code more readable (YMMV) and less sensitive to further changes.
2017-04-20 10:01:22 +03:00
5f3abbd6d8
Add myself to the list of Transmission authors
2017-01-15 01:38:45 +03:00
727b9671f7
Update all website links to canonical HTTPS version.
2016-10-31 10:00:11 +01:00
2248d3670f
Get rid of $Id$ SVN keywords in source files
2016-09-02 23:10:15 +03:00
1af60ad6ad
use '#pragma once' instead of #ifndef..#define..#endif guards
2016-03-29 16:37:21 +00:00
c955c04d8f
Explicitly compare result of str(n)cmp/memcmp to signify that it's not boolean
2016-03-13 22:11:01 +00:00
91f8ceb20d
Handle potential dirname/basename errors where needed
2016-03-13 10:41:52 +00:00
eb8fc35ac6
Remove useless checks and definitions (C99)
...
Now that MSVC support for C99 is quite good, remove previously needed but
now unused checks and definitions, like PRI* format macros (including
PRIdMAX and TR_PRIuSIZE, replaced with %jd and %zu) and inline macro.
Also, remove ssize_t typedef and replace few occurences with ev_ssize_t.
Also, remove check for stdbool.h availability (guaranteed by C99) and
include it unconditionally (except when in C++ mode).
2015-12-29 19:37:31 +00:00
4a4badd4af
Ongoing refactoring (use size_t instead of int)
2015-12-25 10:19:50 +00:00
ceb19b9711
Optionally return result length from `evbuffer_free_to_str()`
2015-12-13 10:23:22 +00:00
3ea43ba778
fix const warnings
...
In particular, in passing argv around as a "const char * const *"
instead of a "const char *".
2015-12-06 22:39:14 +00:00
b559a20029
const correctness
...
silence some qual-cast warnings by sprinkling more consts throughout,
e.g. casting a const void* to a const struct foo * const *
2015-12-06 22:13:10 +00:00
b9095675ce
#6017 : Remove `-lm` from utils compile flags (but leave in linker flags)
2015-11-06 15:09:50 +00:00
c1b10abe0f
Use UTF-8 for console I/O on Windows
2015-04-21 10:07:57 +00:00
829cbffaf7
Add version info to executables (on Windows). Group projects into folders (CMake).
2015-04-14 22:46:40 +00:00
3b129a72d8
#5908 : Check for `tr_loadFile` return value instead of `errno` in `tr_variantFromFile`
...
Seems like there could be a defect in uClibc making errno not
thread-local. Don't rely on errno value but check function return value
instead which is a better failure indicator.
Return errors from `tr_loadFile` and `tr_variantFromFile` via tr_error.
Fix `tr_sessionLoadSettings` to not fail on Windows if settings.json
does not exist.
2015-04-11 10:51:59 +00:00
c7d2a7f959
#4400 : Add CyaSSL support
2015-01-07 02:04:08 +00:00
440f482d01
Replace tabs with spaces; remove trailing spaces
2015-01-02 11:15:31 +00:00
b928ae1ba8
Use libb64 instead of OpenSSL to encode/decode BASE64
...
Some crypto libraries (like CyaSSL, MatrixSSL and CommonCrypto) either
don't have or expose this functionality at all, expose only part of it,
or (like OpenSSL) have heavyweight API for it. Also, for the task as
easy as BASE64 encoding and decoding it's much better to use small and
simple specialized library.
2015-01-01 21:16:36 +00:00
83c4edb008
#5828 : Initial CMake build system support
2014-12-01 19:55:22 +00:00
870041d92d
(trunk) #4160 : mike.dld patch: 4160-08-args.patch
2014-09-21 18:06:28 +00:00
be290162c2
(trunk) #4160 : mike.dld patch: 4160-07-env.patch
2014-09-21 18:05:14 +00:00
d9d66e3e42
(trunk, libt) #4160 - the slow slog to catch trunk up to mike.dld's 4160 diff continues. This step applies 4160-04b-dir.patch, which replaces native file operations with the tr_sys_dir_*() portability wrappers added in the previous commit.
2014-09-21 17:55:39 +00:00
b325bc0a16
(trunk) #5759 compilation error, undefined reference to sqrt
2014-08-20 17:14:17 +00:00
ab24ef9fcb
use pkg-config to get the zlib cflags/libs; remove obsolete zlib.m4 macro
2014-07-13 21:54:56 +00:00
0323639e57
(trunk, libT) #4160 'foreign character support' -- merge mike.dld's 4160-02b-path.patch, which updates the codebase to use the new tr_sys_path_*() portability wrappers introduced in 4160-02a
2014-07-08 00:08:43 +00:00
0e01879974
Use built-in _WIN32 macro instead of WIN32
2014-07-04 00:00:07 +00:00
b7b11649a4
keep banging my hands against the keyboard until Jenkins is happy
2014-06-10 01:01:46 +00:00
742c2b542d
set utils/Makefile.am's noinst_HEADERS so the build doesn't break on units.h
2014-06-10 00:55:53 +00:00
e1a3f31900
tweak naming in the #include guard
2014-06-10 00:51:53 +00:00
ef9370783a
(trunk, utils) in transmission-create, return an error if a user tries to manually set a piece size that isn't a power of two.
2014-06-10 00:43:21 +00:00
02cff80c2d
Copyedit the license's revised text: (1) remove unnecessary repitition use of the word 'license' from the top of the header and source files (2) add the standard 'we hope it's useful, but no warranty' clause to COPYING (3) make explicit that linking OpenSSL is allowed (see https://people.gnome.org/~markmc/openssl-and-the-gpl.html for background) (4) sync the Qt and GTK+ clients' license popups with COPYING's revised text
2014-01-21 03:10:30 +00:00
4b9626bb83
Licensing changes:
...
1. add the option the code to be used under GPLv2 or GPLv3; previously only GPLv2 was allowed
2. add the "proxy option" as described in GPLv3 so we can add future licenses without having to bulk-edit everything again :)
3. remove the awkward "exception for MIT code in Mac client" clause; it was unnecessary and confusing.
2014-01-19 01:09:44 +00:00
4904b923fb
(trunk) restore copyright year as suggested in email by rms
2014-01-18 20:56:57 +00:00
ea7d2482dd
introduce TR_PRIuSIZE macro for portable printf()ing of size_t. mikedld
2013-09-08 17:32:09 +00:00
f75027d5e9
make all the log functions/structs/enums use a single 'tr_log' namespace, such as tr_logGetQueue, tr_logAddInfo, tr_logIsLevelActive
2013-01-25 23:34:20 +00:00
d622669b7e
(transmission-edit) fix global search-and-replace damage wreaked upon the --help text, reported by Elbandi
2013-01-22 18:59:39 +00:00
447b558cdf
(utils) #4137 'support user-defined piece sizes in transmission-create' -- done. Initial patch by lav.
2013-01-17 18:55:51 +00:00
3c9640bb8f
make tr_info.webseedCount and tr_info.trackerCount unsigned.
2012-12-30 22:06:45 +00:00
c1559f3cc4
(trunk, libT) first drop of the tr_quark patch.
2012-12-22 20:35:19 +00:00
e96ed247fe
refactor libtransmission's tr_benc class as tr_variant.
2012-12-14 04:34:42 +00:00
3d38723ad9
Follow more common whitespace style conventions in the C code (libtransmission, daemon, utils, cli, gtk).
2012-12-05 17:29:46 +00:00
357b160cde
remove trailing spaces
2012-09-07 04:25:04 +00:00
4963b65c1f
(trunk utils) #4979 "add manget link generator to transmission-show" -- done.
2012-07-23 15:28:27 +00:00
6d4858d8dd
(trunk) #4732 "allow switching between internal and system libnatpmp" -- fixed with patch scarabeus and applied by me, so any patch breakage is probably mine... ;)
2012-02-04 01:28:15 +00:00
fbc7f3dc3c
(trunk) use base-10 units for network bandwidth (ie, speed) and disk sizes.
...
It looks like the Mac client is already doing this and it's clearly the trend in other apps as well. Even apt-get is using kB/s, ferchrissake... :)
Flame away.
2012-02-03 21:21:52 +00:00
b2d65db45f
(trunk) remove trailing spaces from code lines ;)
2012-02-03 16:44:07 +00:00
01f68ca846
(trunk libT) #4323 "Allow usage of system miniupnpc" -- fixed.
2011-10-09 02:05:52 +00:00
8424c35ab3
(trunk utils) #4458 "'transmission-edit -a' overwrites the announce field" -- fixed.
2011-09-07 04:21:45 +00:00
b125cf116e
(trunk utils) add '-o' description to transmission-create's manpage.
2011-04-20 19:18:28 +00:00
87ef45cf3d
(trunk libT) copyediting: remove a bunch of seemingly-unneeded network headers in net.[ch].
...
I'm less certain that these are unneeded because networking APIs seem to have more variation between platforms, but it's better to remove the cruft and then add back whatever headers $PLATFORM users complain about, than to not remove the cruft at all...
2011-03-24 22:57:39 +00:00
b4d36aeb54
(trunk) #4138 "use stdbool.h instead of tr_bool" -- done.
2011-03-22 15:19:54 +00:00
374ed10f3b
(trunk) it's bad form to #include so many system headers in libtransmission/utils.h...
2011-03-16 18:04:23 +00:00
b46d3a2713
(trunk libT) #117 "UDP tracker protocol support (BEP #15 )" -- refactor announcer.c so that alternate tracker protocols can be supported.
...
This commit adds a set of package-visible structs and functions to allow delegating announces and scrapes to different protocol handlers. (Examples: struct tr_announce_request, struct tr_announce_response, struct tr_scrape_request, struct tr_scrape_response.) HTTP is the only protocol handler currently implemented; however, this provides a clean API for other protocol handlers, and having this in trunk will help shake out any bugs in this refactoring.
In addition, logging via the TR_DEBUG_FD environment variable is vastly improved in the announcer module now.
2011-03-11 04:19:01 +00:00
9bf2434e14
(trunk) copyediting: remove trailing spaces from source code lines in daemon/ gtk/ libtransmission/ and utils/
2011-03-04 23:26:10 +00:00
7df7d34f6d
automake/autoconf; #includes in libtransmission
2011-02-18 00:32:19 +00:00
9769e07fa9
(trunk) improvement to r11864
...
Since the contents of getcwd() are undefined on error, explicitly terminate the buffer string if getcwd() fails.
2011-02-09 06:10:01 +00:00
2fc40f4b1c
(trunk libt) silence a couple of identical compiler warnings: "ignoring return value of ‘getcwd’, declared with attribute warn_unused_result".
2011-02-09 05:42:52 +00:00
c137858b84
(trunk utils) #3964 "transmission-edit replace option cuts off strings" -- fixed.
...
The trailing text after the last substring match wasn't being retained.
2011-01-30 16:40:11 +00:00
879a2afcbd
Update the copyright year in the source code comments.
...
The Berne Convention says that the copyright year is moot, so instead of adding another year to each file as in previous years, I've removed the year altogether from the source code comments in libtransmission, gtk, qt, utils, daemon, and cli.
Juliusz's copyright notice in tr-dht and Johannes' copyright notice in tr-lpd have been left alone; it didn't seem appropriate to modify them.
2011-01-19 13:48:47 +00:00
9f424f7c9b
(trunk utils) #3873 "transmission-show should list webseeds" -- fixed.
2011-01-05 16:15:41 +00:00
c7cc8301db
(trunk) update credits
2011-01-03 05:58:58 +00:00
345b14adbc
(trunk) #3836 "libevent2 support" -- bump libevent2 requirement to 2.0.10. This will break the Mac build for a minute intil BMW applies his Mac patch
2010-12-20 02:07:51 +00:00
27a1b2dc33
(trunk) one of the periodic, banal "remove-trailing-spaces from lines of source code" cleanup commits
2010-12-12 16:43:19 +00:00
465a2e7c90
(trunk) extremely minor manpage copyediting
2010-12-12 16:36:46 +00:00
d34149f810
(trunk libT) #3712 "transmission-show's file list should be sorted alphabetically" -- done.
2010-11-03 16:59:24 +00:00
775c258bda
(trunk utils) #3659 "fox building utils/ against ublibc" -- fixed
2010-10-23 16:47:13 +00:00
eb31da8fad
(trunk utils) #3611 "utils doesn't use LIBEVENT_CFLAGS during compilation" -- fixed
2010-10-09 13:59:30 +00:00
aa605b655c
(trunk utils) fix minor memory leak in transmission-create
2010-09-27 15:07:57 +00:00
d57ba48775
(trunk) #3577 -- replace gear icon for GTK+, Qt clients
2010-09-24 15:22:53 +00:00
ac9dd13ee0
(trunk utils) add support for --version/-V
2010-08-08 22:53:24 +00:00
4cc11e47ee
(trunk) synchronize the "see also" sections of the manpages
2010-08-04 23:17:49 +00:00
e6bafdf26b
(trunk) #3045 "size units" -- sync the default units in all the apps s.t. they're consistent with each other
2010-07-28 00:31:11 +00:00
6adfcc5528
(trunk utils) fix typo
2010-07-07 16:22:07 +00:00
610061f79a
(trunk T) #3045 "units" -- modify the formatter functions based on feedback from BMW
2010-07-06 20:25:54 +00:00
6e5af03d78
(trunk) #3045 "speed units" -- change the public API of libtransmission based on feedback from livings
2010-07-04 06:07:21 +00:00
178dd336fe
(trunk) #3045 "make libtransmission's API byte-oriented instead of KiB-oriented." -- fix r10931 merge error
2010-07-03 00:33:30 +00:00
cdcc4705aa
(trunk) #3045 "make libtransmission's API byte-oriented instead of KiB-oriented." -- implemented. This is a largish commit and will break the mac build for a little while.
2010-07-03 00:25:22 +00:00
3334053843
(trunk) remove i18n markup from transmission-remote and transmission-show, which aren't currently i18nized
2010-06-25 17:53:33 +00:00
1d63aa4cda
(trunk) add tr_formatter_size() and tr_formatter_speed() so that all the client apps don't have to reinvent the wheel
2010-06-22 04:34:16 +00:00
11ccd65373
(utils) add manpage for transmission-show
2010-06-21 13:29:48 +00:00
6d0d0f9f64
(trunk) silence minor compiler warning: s/%d/%zu/
2010-06-19 23:28:12 +00:00
66650a2b62
(trunk utils) #3302 "Scraping with transmission-show grabs /scrape without any GET parameters" -- fixed in trunk for 2.10. Thanks LolCol
2010-06-17 02:49:39 +00:00
eda211e5ce
(trunk) #2983 : add command-line utilities for creating .torrent files, for editing passkeys, for adding/removing trackers, etc.
2010-06-16 14:27:24 +00:00
Mike Gelfand