ed7685dd1a
Make tr_bitfieldHas() a macro
2008-08-20 13:45:52 +00:00
d06f101e57
#220 : lazy bitfields
2008-08-16 21:06:57 +00:00
94ac86bec6
(libT) route all outbound peer protocol messages through the outMessages buffer, to ensure that they're sent in sequence. previously the outbound pex message wasn't queued in this way.
2008-08-16 05:11:28 +00:00
d7ab0d8a15
possible quick-fix for the "wasted data due to collisions" bug reported in http://forum.transmissionbt.com/viewtopic.php?f=3&t=5643 . surely it's not this easy, but let's see
2008-08-14 20:17:55 +00:00
c75c512ff1
readability improvments #1 , #2 , #3 , #4 . (muks)
2008-08-12 13:51:11 +00:00
51aff87443
lots of C correctness tweaks suggested by sparse/cgcc
2008-08-11 19:05:02 +00:00
2e6443a53d
#1168 : reading past the end of KTorrent's pex added.f strings
2008-08-10 14:58:11 +00:00
b860119cd3
minor text cleanup
2008-08-01 16:43:22 +00:00
96ae464283
rename `pulse' as peerPulse() and trackerPulse() to make backtraces easier to read
2008-07-28 19:47:16 +00:00
72880446d8
(daemon) #1107 : transmission-remote -t[n] -i should display webseeding info
2008-07-27 14:10:32 +00:00
43b99f425a
(libT) fix minor PEX memory leak reported by valgrind
2008-07-18 19:50:38 +00:00
fd06d85aee
part 1 of Aloisius' performance patch
2008-06-27 02:42:44 +00:00
dce24eb1f0
libT: first cut at implementing the internal peers' request queues as pieces rather than blocks, as discussed with erdgeist and denis, to avoid a couple of nasty CPU bottlenecks.
2008-06-09 22:53:45 +00:00
e3e3bee8b5
#800 initial support for GetRight-style fetching of data through http and ftp servers specified in the .torrent's "url-list" tag
2008-06-07 21:26:41 +00:00
041561f232
minor refactoring of tr_bitfield to (a) simplify the tests and (b) make things easier to read
2008-06-07 01:44:54 +00:00
5141a65d45
experimental message batcher as discussed in http://forum.transmissionbt.com/viewtopic.php?p=24251#24251
2008-05-31 00:16:26 +00:00
70fcc56beb
(libT) (1) shave a few bytes from tr_peer and tr_ratecontrol's footprints. (2) remove some dead code.
2008-05-26 12:14:35 +00:00
53d8574b11
* change tr_stat.activityDate's and tr_stat.startedDate's type to time_t, since that's how everyone uses them anyway
...
* add a little more documentation to tr_stat and tr_ctor in transmission.h
2008-05-23 20:04:41 +00:00
d18fb68fbc
sine we now have two public ports (peer and rpc), rename "publicPort" as "peerPort"
2008-05-23 16:18:58 +00:00
2c79888a93
RPC/IPC redesign
2008-05-18 16:44:30 +00:00
be9427931a
ipc: add session accessor/mutators.
...
transmission.h: make the session API more consistent.
2008-05-12 16:33:17 +00:00
85e66062eb
remove unused variables
2008-05-05 04:17:52 +00:00
c20b9a6df4
experimental speed tweaks:
...
(1) increase the per-peer read buffer to the size of a block message
(2) pulse the peers more often
(3) reduce the tracker delay on startup
2008-05-01 19:31:58 +00:00
a443cc3289
add #include <limits.h> to pick up a definition of INT_MAX to make Hudson happy
2008-04-19 19:39:39 +00:00
3445817a80
peer-msgs: faster upload speeds in situations with few peers. this patch needs wider testing for side-effects wrt speed limits.
2008-04-19 19:37:05 +00:00
08b27749ba
#890 : be smarter about noticing seeds from tracker & pex
2008-04-19 15:07:59 +00:00
ac921e0f82
#881 : undo r5631
2008-04-18 00:02:04 +00:00
ea9e0b260f
(1) fix choke/unchoke error. (2) if a peer keeps trying to reconnect to us, hang up during the handshake.
2008-04-17 03:48:56 +00:00
62709b7ca2
#881 : follow the transmission spec wrt extension handshake message timing
2008-04-17 02:11:29 +00:00
8a8b1fedb0
#870 : follow PEX conventions agreed upon by Azureus and uTorrent
2008-04-12 23:01:40 +00:00
fc091499cb
translators shouldn't have to translate debug messages
2008-04-06 00:38:18 +00:00
fd0e71c00a
hack on IPC a bit because it's been too long since I broke it
2008-04-03 21:38:32 +00:00
c63b548195
fix bug that caused very large torrents to crash Transmission
2008-03-22 18:10:59 +00:00
e7316dbc34
yet more string massaging
2008-03-19 02:16:07 +00:00
4fa1da4ee8
#781 : (1) fix overreporting corrupt data, and (2) fix bug added in r5172 that didn't handle sent request TTL correctly, causing too many dupliate block requests.
2008-03-18 17:46:29 +00:00
05c6938f5a
changes to message logging: (1) bring back "Torrent hasn't responded yet", but only in the message log. (2) make PEX messages debug. (3) log a message when a torrent reaches completion.
2008-03-18 16:56:01 +00:00
59fdf5dcc8
#781 : try to get a little further on this `too much corrupt' ticket by adding a more helpful log message when a downloaded piece fails its checksum test.
2008-03-18 01:39:06 +00:00
23f33e1bd1
"Got 0 peers from peer exchange" is a pretty useless message. :)
2008-03-17 02:45:09 +00:00
29f092197f
#138 : per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages#138: per-torrent messages
2008-03-13 03:53:18 +00:00
bcff72c3ad
string consistency. (gtk) move `announce url' from info tab to tracker tab.
2008-03-08 02:00:47 +00:00
5e3dcb5f6f
#751 : more digging to try to figure out where the problem is.
2008-03-06 13:24:44 +00:00
d6a6c24e18
remove more unused code in the peer-msgs module
2008-03-04 21:09:26 +00:00
2c9fef40ef
remove unused code in the peer-msgs module
2008-03-04 20:37:24 +00:00
84a8592d1d
first cut at adding i18n hooks into libtransmission.
2008-03-04 02:02:25 +00:00
08d986759b
fix r5189 typo pointed out by BentMyWookie
2008-03-04 00:55:20 +00:00
3000d67e7f
#751 : add some tracer bullets to help track down this error.
2008-03-03 21:51:45 +00:00
24e05bf3fb
harden the bitfield handling to handle corrupt messages from peers. This is in response to Ryoujin's crash report in the forums ( http://forum.transmissionbt.com/viewtopic.php?p=20414#20414 )
2008-03-02 23:44:34 +00:00
f1c3b160af
remove `banned' field for per-piece-per-peer banning. this has been unused since the three-strikes rule went in place.
2008-03-01 14:32:35 +00:00
0788bc37ed
minor cleanups to peer-msgs
2008-03-01 14:09:18 +00:00
3de06974e8
#727 : Download speed setting also affects upload speed, peer informations in torrent inspector
2008-02-29 17:09:33 +00:00
a7d087b60a
use a custom struct for the peer's four request queues since John_Clay's shark report shows it taking up about 40% of the time in malloc/free. also, maybe this will help the "idle memory" numbers some.
2008-02-29 03:41:50 +00:00
8cc587a66f
more housekeeping: benc_val_t --> tr_benc
2008-02-26 21:58:58 +00:00
deaeb24cb5
cleanup #includes for errno & strerror
2008-02-19 04:16:04 +00:00
c144470c70
make the code a little easier to read. make tr_ioFileTest()'s return value consistent with other inout funcs.
2008-02-15 18:25:42 +00:00
4f4f451c17
possible fix for http://forum.transmissionbt.com/viewtopic.php?t=3946
2008-02-14 21:48:49 +00:00
8d14a789cb
#698 : `have' gets too far ahead of `verified'
2008-02-10 04:03:19 +00:00
2085aec390
#613 : fix handshake protocol error reported by brad- and tracked down w/Lacrocivious' help.
2008-01-26 03:43:49 +00:00
d922389c9d
#613 : fix handshake error with libtorrent / mainline peers
2008-01-24 17:16:20 +00:00
3c6eeef439
fix a socket leak in peer-msgs
2008-01-19 03:30:45 +00:00
de515ee339
if the torrent's download path doesn't exist, don't create it -- it's might be a removeable disk that got unplugged.
2008-01-18 19:13:32 +00:00
e7163a5433
#593 : 1.01 crash
2008-01-13 15:52:56 +00:00
3a6396a3cb
mingw portability fixes
2008-01-10 18:52:46 +00:00
5d93bd2c93
a smaller buffer size seems, counterintuitively, to improve the overall transfer rate when speed limits are turned on, because it gives more peers a chance to be involved in xfer before we hit the limit.
2008-01-09 19:22:25 +00:00
591f7f8b10
* improve the unchoking algorithm.
...
* when deciding which peers to connect to, take peer's previous speeds into account
* longer delay interval before reconnecting to peers that didn't give us data
* added uTorrent-inspired "flags" column in tr_peer_stat and gtk's torrent details' "peer" tab
2008-01-09 17:33:43 +00:00
1e45d3e478
better lazy generation of "allowed set": wait until we get the {have-all|have-none|bitfield} from the peer so that we'll know if they qualify for an allowed set
2008-01-06 22:20:44 +00:00
35f73c097c
lazy "allowed set" generation. add regression test for "allowed set" generation.
2008-01-06 21:56:30 +00:00
6c3eab0a92
#585 : 1.00 could be sped up by elminating reconnect intervals for some peers
2008-01-05 18:17:56 +00:00
085235b10b
remove some unused #include <ctype.h> directives
2008-01-03 20:17:01 +00:00
ee2cffa196
#579 : assertion failure in ~r4410
2008-01-03 03:45:10 +00:00
c6d2e60f52
fix comment typo reported by BigBossman
2007-12-27 22:50:20 +00:00
e870440025
add a per-block request TTL of 120 seconds
2007-12-25 17:22:51 +00:00
473907d891
a little housekeeping: move tr_torrent stuff into its own header
2007-12-25 05:37:32 +00:00
401cfbdb6b
replace the per-torrent PEX setting with a global one, as per discussion with SoftwareElves and BentMyWookie
2007-12-24 05:03:40 +00:00
4ff5b472a8
raise the maximum connection limit a bit.
2007-12-15 16:36:43 +00:00
39d8c74fcd
small tweak to play nice with old C compilers. Thanks to fizz for reporting & submitting a patch
2007-12-03 19:52:55 +00:00
abef433926
improve upload speeds when the speed limits are uncapped.
2007-12-01 23:08:34 +00:00
1e4b3a0577
make the peer stats a little easier to understand
2007-11-27 21:39:41 +00:00
e354b82452
disable SWIFT on private trackers, because they are typically ratio-based sites where you *want* to upload as much as possible to deadbeats
2007-11-26 04:05:12 +00:00
8caa113d4b
fix LTEP PEX error reported by Adrian Ulrich in the BitTorrent mailing list
2007-11-22 06:48:08 +00:00
91e672d428
some progress on the overall statistics, though probably not visible to end users yet
2007-11-21 20:03:53 +00:00
9f9901b3fa
tweak the peer limits a bit for faster uploading
2007-11-20 17:29:56 +00:00
9cec81b524
fix the crash reported by pea_, Gimp, and John_Clay [ref: http://pastebin.ca/784834 ]
2007-11-19 21:44:38 +00:00
3704854654
add more asserts up the call chain to find the source of pea_ and Gimp's bug
2007-11-19 04:51:06 +00:00
a277382578
more download speed tweaks for situations where T is both uploading and downloading.
2007-11-18 04:24:17 +00:00
e371009606
this should improve download speeds. test it!
2007-11-18 03:18:26 +00:00
9a81cd7637
reintroduce the "SWIFT" algorithm
2007-11-18 01:00:49 +00:00
37969406b2
Add "Status" column to tr_peer_stat.
2007-11-17 23:43:33 +00:00
54a2bb978b
fix timeout error that caused us to drop connections prematurely
2007-11-17 17:49:30 +00:00
ef3d0df0d9
try to tickle some more information out of John_Clay's bug report
2007-11-17 07:48:51 +00:00
77d58126f4
remove yet more dead code
2007-11-17 02:47:47 +00:00
cc728b0470
progress on the "speed limits kill my transfer rate" bug.
2007-11-16 21:58:11 +00:00
0ac302b302
progress on the "speed limits kill my transfer rate" bug.
2007-11-16 20:40:03 +00:00
73680b6263
fix tr_peerMsgsAddRequest memory leak reported by tiennou
2007-11-16 15:45:26 +00:00
1ebaf597a4
fix trunk memory leak reported by tiennou
2007-11-16 15:33:57 +00:00
c3dce15a9e
if we haven't advertised that we support pex, then even if a peer sends us a pex message, don't send one back.
2007-11-16 04:42:51 +00:00
257eaee631
more of the same
2007-11-15 05:47:23 +00:00
a9e5fff2e6
* fix the `req->length == (uint32_t)( ((block)==((msgs->torrent)->blockCount-1))' bug.
...
* there seems to be a pattern for peers that were (intentionally?) giving incomplete data to trigger the bug above. when a peer does this, give them a strike on its three-strikes-and-you're-banned count
2007-11-13 05:36:43 +00:00
8516860fec
fix a bug in tr_stat's availability numbers, reported by BentMyWookie
2007-11-11 16:33:04 +00:00
c32f893038
commit tiennou's fast-peers-final patch from ticket 149
2007-11-10 16:06:00 +00:00
ca03b62a58
* fix a bug that could corrupt peer connections, causing slower speeds and/or fewer connections
...
* add more assertions to smoke out any remaining BT protocol bugs
2007-11-10 04:56:27 +00:00
fd430fde90
undoing the r3773-r3774 experiment.
2007-11-09 20:07:52 +00:00
67b719c2de
on Darwin, use NSCParameterAssert() instead of assert().
2007-11-09 19:50:40 +00:00
99ea26c1c9
* try to get peers to scale up to speed faster.
...
* remove unnecessary steps when receiving block data from peers.
2007-11-09 01:22:15 +00:00
39f9f14751
minor tweaks.
2007-11-08 21:25:17 +00:00
71f4efcbad
update our #includes now that libevent has cleaned up event.h
2007-11-07 18:26:19 +00:00
60aab6c433
remove libtransmission code that duplicates functionality in libevent
2007-11-06 21:14:30 +00:00
0f92cb7f30
fix bug reported in the forums by "grabman"
2007-11-05 03:09:27 +00:00
3e0e462b10
finish cleaning up the code that was churned during the "corruption" fix.
2007-11-01 13:47:32 +00:00
a6206b036c
"corruption" fix part 2: lots of assertions, and try to complete pieces & ban bad peers sooner
2007-10-31 04:23:51 +00:00
ab8ed6507d
#412 - 0.90 "ignores" speed limits (deanr, berkut, SineOtter)
2007-10-28 15:20:24 +00:00
92ac49d9c4
compatability with older C copmilers (ticket #422 , patch by fizz)
2007-10-27 21:29:41 +00:00
b00ee3e568
Ticket #398 (peer-msgs.c:905: failed assertion `msglen == 0' in 0.90)
2007-10-27 15:45:03 +00:00
8c0e2434f5
fix OpenBSD build error.
2007-10-25 13:59:46 +00:00
b704654275
dead code removal.
2007-10-22 23:27:47 +00:00
a5946e396c
tweak the logging a bit.
2007-10-22 18:52:36 +00:00
e1fbd16941
fix some memory leaks reported by valgrind.
2007-10-22 14:15:16 +00:00
6527f4e12a
dead code removal.
2007-10-20 15:17:36 +00:00
25fa56d294
* don't fire the "status changed" event if the status changes while a torrent's being started for the first time.
...
* cleaner setting of the DND flags in the gtk+ client.
* cpStatus cleanup.
2007-10-19 23:23:21 +00:00
911ff1cdd1
remove tr_peerMsgsSetChoke()'s return value, which was always ignored anyway
2007-10-17 18:23:59 +00:00
6eb7edf007
fix choke fibrillation bug in new connections
2007-10-15 16:01:42 +00:00
57eaa27970
Fix bug that could initiate pex in private torrents.
2007-10-14 17:21:24 +00:00
d96ed80aa2
(1) fix a bug in torrent creation. (2) fix a bug in torrent paths on startup in gtk
2007-10-14 03:26:13 +00:00
4f33a8da42
Try sharing a DH so that we don't spend so many cpu cycles making new ones when we're working through the peers trying to find good ones.
2007-10-13 23:15:43 +00:00
9211c57ad2
merge in the parts of peerutils' peer pruning code that still make sense
2007-10-13 13:54:05 +00:00
89564dc3c2
fix the "swarm speed" bug reported by Gimp_
2007-10-11 04:17:28 +00:00
3b2ef1054f
8 second timeout during handshake, 2.5 minute handshake afterwards
2007-10-11 03:54:33 +00:00
e11999243e
add more debugging messages to track down why we're disconnecting from some peers
2007-10-11 03:36:09 +00:00
cbaf1b8faa
commit more of tiennou's fastpeers patch
2007-10-10 16:39:12 +00:00
696800f369
* fix bug that sent a keepalive message too often
2007-10-10 03:03:09 +00:00
e8d19c5b03
fix stupid bug from yesterday that made uploading difficult.
2007-10-09 05:51:20 +00:00
e176a25922
* fix a bug with uploading encrypted pice data to another peer
...
* extra sanity tests when uploading data
2007-10-08 16:10:10 +00:00
1014e633ac
* don't reuse http connections to trackers. I think this is what caused most of the `no response from tracker X' messages.
...
* extra safety checks to ensure the last `stopped' message to the tracker is sent on shutdown.
2007-10-07 16:07:19 +00:00
c75f49bc26
* add a per-peer request queue to hold the next 10-15 seconds' worth of requests so that we always have more requests at hand when the current requests start to run low.
...
* increase the tracker `numwant' variable to grow our peer pool
* bugfixes in cancelling requests.
* make the debug log sexy and readable like uTorrent's ;)
2007-10-06 18:20:52 +00:00
b6483cbf3f
don't allow duplicate requests to the same peer, even during endgame. (alus)
2007-10-05 00:16:47 +00:00
5f2bd1d950
speed improvements... this is getting me 700 KiB/s (which is near to my speed cap) in the ubuntu torrent test
2007-10-03 19:00:51 +00:00
877e2bb86e
some more peer tweaks
2007-10-03 18:19:51 +00:00
a3d1a254d1
minor source code cleanup...
2007-10-03 16:42:43 +00:00
3d2e3cfdfb
add pass subscription info into the peer-msgs constructor so that we can start getting information immediately
2007-10-03 04:04:34 +00:00
1f1605986c
tear out some now-exterraneous code.
2007-10-02 20:55:14 +00:00
3dbaa7d673
make the peer manager a little greedier w.r.t. keeping connections alive.
2007-10-02 19:25:18 +00:00
f237bf7047
* simplify the the choking intervals
...
* fix peer-mgr destructor bug
* send debugging messagese to TR_DEBUG_FD instead of the console
2007-10-02 14:35:02 +00:00
84ab0092fb
some cleanup... remove some dead/obsolete code
2007-10-02 00:05:40 +00:00
75ff12faba
don't log BT protocol messages in UL/DL speed -- only log piece data transfers.
2007-10-01 16:31:17 +00:00
6bef7def52
tweaks
2007-10-01 00:08:12 +00:00
7cc6771318
experimental better peer management.
2007-09-30 23:55:49 +00:00
dad333ceec
more work on the locks
2007-09-29 14:55:30 +00:00
04f6847004
take out the `thawing out' console messages
2007-09-29 00:47:33 +00:00
3f1d888354
improved uTorrent handshaking, after talking to #utorrent-dev about minutae...
2007-09-29 00:46:41 +00:00
79973a8a93
commit the next step of tiennou's fastpeers code.
2007-09-28 16:40:21 +00:00
198d2c256e
fix John_Clay's tracker assertion failure.
2007-09-28 16:14:19 +00:00
Mukund Sivaraman